Jonathan Druart
a844a2211f
There are two things here: * Branches.pickup_location has a default = 1 in DB, we should not set to undef if 0 or it will be set to 1 when stored. * The other fields are all text (varchar, mediumtext or longtext) and can be NULL. They are correct set to NULL when a new library is created but set to an empty string when the library is modified. That's not consistent Test plan: 0. Don't apply the patch 1. Create a new library, set pickup location to "No" 2. Save => Pickup location is set to YES => In DB notice that the different values you didn't fill in are set to NULL 3. Edit the library 4. Save => In DB notice that the different values you didn't fill in are now set to an empty string 5. Apply the patch, restart_all 6. Run the updatedatabase script => In DB all the empty string values are set to NULL 7. Repeat 1 to 4 and confirm that everything is now working as expected Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> |
||
|---|---|---|
| .. | ||
| searchengine/elasticsearch | ||
| add_user_search.pl | ||
| additional-fields.pl | ||
| admin-home.pl | ||
| adveditorshortcuts.pl | ||
| aqbudgetperiods.pl | ||
| aqbudgets.pl | ||
| aqcontract.pl | ||
| aqplan.pl | ||
| audio_alerts.pl | ||
| auth_subfields_structure.pl | ||
| auth_tag_structure.pl | ||
| authorised_values.pl | ||
| authtypes.pl | ||
| background_jobs.pl | ||
| biblio_framework.pl | ||
| branch_transfer_limits.pl | ||
| branches.pl | ||
| cash_registers.pl | ||
| categories.pl | ||
| check_budget_parent.pl | ||
| check_parent_total.pl | ||
| checkmarc.pl | ||
| cities.pl | ||
| classsources.pl | ||
| clone-rules.pl | ||
| columns_settings.pl | ||
| columns_settings.yml | ||
| credit_types.pl | ||
| currency.pl | ||
| debit_types.pl | ||
| desks.pl | ||
| didyoumean.pl | ||
| edi_accounts.pl | ||
| edi_ean_accounts.pl | ||
| import_export_framework.pl | ||
| item_circulation_alerts.pl | ||
| items_search_field.pl | ||
| items_search_fields.pl | ||
| itemtypes.pl | ||
| koha2marclinks.pl | ||
| library_groups.pl | ||
| localization.pl | ||
| marc_subfields_structure.pl | ||
| marctagstructure.pl | ||
| matching-rules.pl | ||
| oai_set_mappings.pl | ||
| oai_sets.pl | ||
| overdrive.pl | ||
| patron-attr-types.pl | ||
| preferences.pl | ||
| share_content.pl | ||
| smart-rules.pl | ||
| sms_providers.pl | ||
| smtp_servers.pl | ||
| sru_modmapping.pl | ||
| systempreferences.pl | ||
| transfer_limits.pl | ||
| transport-cost-matrix.pl | ||
| usage_statistics.pl | ||
| z3950servers.pl | ||