Koha/debian/scripts/koha-foreach
David Cook 4c548cb08f Bug 25634: Warn if koha-shell returns non-zero in koha-foreach
By putting koha-shell in an if statement, "set -e" will no longer
cause the entire koha-foreach program to exit, if koha-shell
returns a non-zero status.

If a non-zero status is returned, we warn on it, and the caller
of koha-foreach can interpret that command visually.

To Test:
1) Write a shell script that says "Hello" and then exits with a 1
status
2) Run koha-foreach against that shell script with multiple instances
available to koha-foreach
3) Before the patch, koha-foreach will die after the first "Hello"
4) After the patch, koha-foreach will continue, through all the
instances, and report which instances returned non-zero statuses
by which command.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-06-12 10:32:30 +02:00

74 lines
2.3 KiB
Bash
Executable file

#!/bin/sh
# koha-foreach -- run a command for each Koha instance
# Copyright 2010 Catalyst IT, Ltd
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
set -e
# Read configuration variable file if it is present
[ -r /etc/default/koha-common ] && . /etc/default/koha-common
# include helper functions
if [ -f "/usr/share/koha/bin/koha-functions.sh" ]; then
. "/usr/share/koha/bin/koha-functions.sh"
else
echo "Error: /usr/share/koha/bin/koha-functions.sh not present." 1>&2
exit 1
fi
chdir="no"
starting_dir=$(pwd)
listopts=""
while [ ! -z "$1" ]
do
case "$1" in
--chdir) chdir="yes";;
--email) listopts="$listopts --email";;
--noemail) listopts="$listopts --noemail";;
--enabled) listopts="$listopts --enabled";;
--disabled) listopts="$listopts --disabled";;
--sip) listopts="$listopts --sip";;
--nosip) listopts="$listopts --nosip";;
--plack) listopts="$listopts --plack";;
--noplack) listopts="$listopts --noplack";;
--letsencrypt) listopts="$listopts --letsencrypt" ;;
--noletsencrypt) listopts="$listopts --noletsencrypt" ;;
*) break;;
esac
shift
done
for name in $(koha-list $listopts)
do
# Replace the __instancename__ placeholder for the instance name (Bug 8566)
cmd=`echo "$@" | sed -e s/__instancename__/${name}/g`
if [ "${cmd}" != "" ]; then
# Change to the instance's home dir if required
[ "$chdir" != "no" ] && eval cd ~$name"-koha"
if koha-shell ${name} -c "${cmd}"; then
: #noop
else
rv=$?
echo "${name}: $rv status returned by \"${cmd}\""
fi
# Go back to the original dir if required
[ "$chdir" != "no" ] && cd "$starting_dir"
fi
done