Koha/misc/devel/install_plugins.pl
Magnus Enger 4848def5e2
Bug 36517: Fix output from install_plugins.pl
When misc/devel/install_plugins.pl does not find any plugins, it prints
the list of pluginsdir, but with a literal \n separating the dirs, and
no newline at the end.

To test:
- Edit koha-conf.xml and add a second entry for <pluginsdir>, so there
  are two entries. The second one could just be a copy of the original.
- Run "perl misc/devel/install_plugins.pl"
- Note the output looks something like this:

No plugins found
pluginsdir contains:
/var/lib/koha/kohadev/plugins\n/var/lib/koha/kohadev/pluginsroot@kohadevbox:koha(master)$

- Apply the patch and run the script again. Output should be:

No plugins found
pluginsdir contains:
/var/lib/koha/kohadev/plugins
/var/lib/koha/kohadev/plugins
root@kohadevbox:koha(master)$

- Sign off

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-04-12 11:26:01 +02:00

109 lines
2.8 KiB
Perl
Executable file

#!/usr/bin/perl
# This file is part of Koha.
#
# Copyright 2019 Koha Development Team
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use Getopt::Long qw( GetOptions );
use Pod::Usage qw( pod2usage );
use Koha::Script;
use C4::Context;
use Koha::Plugins;
my ($help);
GetOptions( 'help|?' => \$help );
pod2usage(1) if $help;
unless ( C4::Context->config("enable_plugins") ) {
print
"The plugin system must be enabled for one to be able to install plugins\n";
exit 1;
}
my @existing_plugins = Koha::Plugins->new()->GetPlugins({
all => 1,
verbose => 1, # warns about plugins failing to load
});
my $existing_plugins;
for my $existing_plugin (@existing_plugins) {
$existing_plugins->{ $existing_plugin->{metadata}->{name} } = $existing_plugin->{metadata}->{version};
}
my @installed_plugins = Koha::Plugins->new()->InstallPlugins( { verbose => 0 } );
unless (@installed_plugins) {
my $plugins_dir = C4::Context->config("pluginsdir");
if ( ref($plugins_dir) eq 'ARRAY' ) {
print "No plugins found\n";
print "pluginsdir contains: \n" . join( "\n", @{$plugins_dir} ) . "\n";
}
else {
print "No plugins found at $plugins_dir\n";
}
exit 0;
}
for my $installed_plugin (@installed_plugins) {
if ( !exists( $existing_plugins->{ $installed_plugin->{metadata}->{name} } )
)
{
print "Installed "
. $installed_plugin->{metadata}->{name}
. " version "
. $installed_plugin->{metadata}->{version} . "\n";
}
elsif ( $existing_plugins->{ $installed_plugin->{metadata}->{name} } ne
$installed_plugin->{metadata}->{version} )
{
print "Upgraded "
. $installed_plugin->{metadata}->{name}
. " from version "
. $existing_plugins->{ $installed_plugin->{metadata}->{name} }
. " to version "
. $installed_plugin->{metadata}->{version} . "\n";
}
}
print "All plugins successfully re-initialised\n";
=head1 NAME
install_plugins.pl - install all plugins found in plugins_dir
=head1 SYNOPSIS
install_plugins.pl
Options:
-?|--help brief help message
=head1 OPTIONS
=over 8
=item B<--help|-?>
Print a brief help message and exits
=back
=head1 DESCRIPTION
A simple script to install plugins from the command line
=cut