dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
93 lines
4.4 KiB
Text
93 lines
4.4 KiB
Text
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Attach an item to [% bibliotitle | html %]</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
</head>
|
|
<body id="catalog_moveitem" class="catalog">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'cat-search.inc' %]
|
|
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/cataloguing/addbooks.pl">Cataloging</a> › Attach an item to <i>[% bibliotitle | html %][% IF ( itemsloo.subtitle ) %][% itemsloo.subtitle | html %][% END %]</i></div>
|
|
<div id="doc" class="yui-t7">
|
|
|
|
[% BLOCK actions %]
|
|
[% IF ( BiblioDefaultViewmarc ) %]
|
|
<form action="/cgi-bin/koha/catalogue/MARCdetail.pl" method="post">
|
|
[% ELSIF ( BiblioDefaultViewlabeled_marc ) %]
|
|
<form action="/cgi-bin/koha/catalogue/labeledMARCdetail.pl" method="post">
|
|
[% ELSIF ( BiblioDefaultViewisbd ) %]
|
|
<form action="/cgi-bin/koha/catalogue/ISBDdetail.pl" method="post">
|
|
[% ELSE %]
|
|
<form action="/cgi-bin/koha/catalogue/detail.pl" method="post">
|
|
[% END %]
|
|
[% END %]
|
|
|
|
[% BLOCK fail %]
|
|
<button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> OK</button>
|
|
<input type="hidden" name="biblionumber" value="[% biblionumber | html %]" />
|
|
</form>
|
|
<form method="get" action="/cgi-bin/koha/cataloguing/moveitem.pl?biblionumber=[% biblionumber | html %]">
|
|
<button type="submit" class="new"><i class="fa fa-fw fa-plus"></i> Try again with a different barcode</button>
|
|
<input type="hidden" name="biblionumber" value="[% biblionumber | html %]" />
|
|
</form>
|
|
[% END %]
|
|
|
|
[% IF ( error ) %]
|
|
<div class="dialog alert">
|
|
|
|
[% IF ( errornonewitem ) %]ERROR: Unable to create the new item.<p>
|
|
[% INCLUDE actions %]
|
|
[% INCLUDE fail %]
|
|
</p>
|
|
[% END %]
|
|
|
|
[% IF ( errornoitem ) %]ERROR: Unable to get the item.<p>
|
|
[% INCLUDE actions %]
|
|
[% INCLUDE fail %]
|
|
</p>
|
|
[% END %]
|
|
</div>
|
|
|
|
[% ELSE %]
|
|
[% IF ( success ) %]
|
|
<div class="dialog message">The item has successfully been attached to [% INCLUDE 'biblio-default-view.inc' %]<i>[% bibliotitle | html %]</i></a>.
|
|
<p>
|
|
[% INCLUDE actions %]
|
|
<button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> OK</button>
|
|
<input type="hidden" name="biblionumber" value="[% biblionumber | html %]" />
|
|
</form>
|
|
<form method="get" action="/cgi-bin/koha/cataloguing/moveitem.pl?biblionumber=[% biblionumber | html %]"/>
|
|
<button type="submit" class="new"><i class="fa fa-fw fa-plus"></i> Attach another item</button>
|
|
<input type="hidden" name="biblionumber" value="[% biblionumber | html %]" />
|
|
</form>
|
|
</p>
|
|
</div>
|
|
[% ELSE %]
|
|
[% IF ( missingparameter ) %]
|
|
<form method="post" action="/cgi-bin/koha/cataloguing/moveitem.pl">
|
|
[% IF ( missingbiblionumber ) %]
|
|
<fieldset id="biblionumber_fieldset">
|
|
<label for="biblionumber">Select the biblionumber to attach the item to</label>
|
|
<div class="hint">Enter biblionumber:</div>
|
|
<input type="text" name="biblionumber" id="biblionumber" class="focus" size="14" />
|
|
<fieldset class="action"><input type="submit" value="Submit" /></fieldset>
|
|
</fieldset>
|
|
[% ELSE %]
|
|
<input type="hidden" name="biblionumber" id="biblionumber" value="[% biblionumber | html %]" />
|
|
[% END %]
|
|
|
|
[% IF ( missingbarcode ) %]
|
|
<h3>Attach an item[% IF ( bibliotitle ) %] to <i>[% bibliotitle | html %]</i>[% END %]</h3>
|
|
<fieldset id="barcode_fieldset">
|
|
<label for="barcode">Enter the barcode of the item to attach:</label>
|
|
<p class="hint">The item you select will be moved to the target record.</p>
|
|
<input type="text" name="barcode" id="barcode" class="barcode focus" size="14" />
|
|
<fieldset class="action"><input type="submit" value="Submit" /></fieldset>
|
|
</fieldset>
|
|
[% ELSE %]
|
|
<input type="hidden" name="barcode" id="barcode" value="[% barcode | html %]" />
|
|
[% END %]
|
|
|
|
</form>
|
|
[% END %]
|
|
[% END %]
|
|
[% END %]
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|