Jonathan Druart
9d6d641d1f
On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. This patch is a squashed version of: Bug 17600: After export.pl Bug 17600: After perlimport Bug 17600: Manual changes Bug 17600: Other manual changes after second perlimports run Bug 17600: Fix tests And a lot of other manual changes. export.pl is a dirty script that can be found on bug 17600. "perlimport" is: git clone https://github.com/oalders/App-perlimports.git cd App-perlimports/ cpanm --installdeps . export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib" find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \; The ideas of this patch are to: * use EXPORT_OK instead of EXPORT * perltidy the EXPORT_OK list * remove '&' before the subroutine names * remove some uneeded use statements * explicitely import the subroutines we need within the controllers or modules Note that the private subroutines (starting with _) should not be exported (and not used from outside of the module except from tests). EXPORT vs EXPORT_OK (from https://www.thegeekstuff.com/2010/06/perl-exporter-examples/) """ Export allows to export the functions and variables of modules to user’s namespace using the standard import method. This way, we don’t need to create the objects for the modules to access it’s members. @EXPORT and @EXPORT_OK are the two main variables used during export operation. @EXPORT contains list of symbols (subroutines and variables) of the module to be exported into the caller namespace. @EXPORT_OK does export of symbols on demand basis. """ If this patch caused a conflict with a patch you wrote prior to its push: * Make sure you are not reintroducing a "use" statement that has been removed * "$subroutine" is not exported by the C4::$MODULE module means that you need to add the subroutine to the @EXPORT_OK list * Bareword "$subroutine" not allowed while "strict subs" means that you didn't imported the subroutine from the module: - use $MODULE qw( $subroutine list ); You can also use the fully qualified namespace: C4::$MODULE::$subroutine Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
87 lines
2.2 KiB
Perl
Executable file
87 lines
2.2 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
# Small script that rebuilds the non-MARC DB
|
|
# Formerly named rebuildnonmarc.pl
|
|
|
|
use strict;
|
|
#use warnings; FIXME - Bug 2505
|
|
|
|
BEGIN {
|
|
# find Koha's Perl modules
|
|
# test carefully before changing this
|
|
use FindBin ();
|
|
eval { require "$FindBin::Bin/kohalib.pl" };
|
|
}
|
|
|
|
# Koha modules used
|
|
use Koha::Script;
|
|
use MARC::Record;
|
|
use C4::Charset;
|
|
use C4::Context;
|
|
use C4::Biblio qw(
|
|
GetXmlBiblio
|
|
TransformMarcToKoha
|
|
);
|
|
use Time::HiRes qw( gettimeofday );
|
|
|
|
use Getopt::Long qw( GetOptions );
|
|
|
|
my ($version, $confirm);
|
|
GetOptions(
|
|
'c' => \$confirm,
|
|
'h' => \$version
|
|
);
|
|
|
|
if ($version || (!$confirm)) {
|
|
print <<EOF
|
|
This script rebuilds the non-MARC fields from the MARC values.
|
|
You can/must use it when you change your mapping.
|
|
|
|
Example: you decide to map biblio.title to 200\$a (it was previously mapped to 610\$a).
|
|
Run this script or you will have strange results in the UI!
|
|
|
|
Syntax:
|
|
\t./batchRebuildBiblioTables.pl -h (or without arguments => show this screen)
|
|
\t./batchRebuildBiblioTables.pl -c (c like confirm => rebuild non-MARC fields (may take long)
|
|
EOF
|
|
;
|
|
exit;
|
|
}
|
|
|
|
$|=1; # non-buffered output
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
my $i=0;
|
|
my $starttime = gettimeofday;
|
|
my $marcflavour = C4::Context->preference('marcflavour');
|
|
my $sth = $dbh->prepare('SELECT biblionumber, frameworkcode FROM biblio');
|
|
$sth->execute();
|
|
|
|
my @errors;
|
|
while (my ($biblionumber, $frameworkcode) = $sth->fetchrow) {
|
|
my $marcxml = GetXmlBiblio($biblionumber);
|
|
if (not defined $marcxml) {
|
|
push @errors, $biblionumber;
|
|
next;
|
|
}
|
|
|
|
$marcxml = C4::Charset::StripNonXmlChars( $marcxml );
|
|
my $record = eval {
|
|
MARC::Record::new_from_xml($marcxml, 'UTF-8', $marcflavour);
|
|
};
|
|
if ($@) {
|
|
push @errors, $biblionumber;
|
|
next;
|
|
}
|
|
|
|
my $biblio = TransformMarcToKoha($record);
|
|
C4::Biblio::_koha_modify_biblio($dbh, $biblio, $frameworkcode);
|
|
C4::Biblio::_koha_modify_biblioitem_nonmarc($dbh, $biblio);
|
|
|
|
$i++;
|
|
printf("%lu records processed in %.2f seconds\n", $i, gettimeofday() - $starttime) unless ($i % 100);
|
|
}
|
|
|
|
printf("\n%lu records processed in %.2f seconds\n", $i, gettimeofday() - $starttime);
|
|
if (scalar(@errors) > 0) {
|
|
print "Some records could not be processed though: ", join(' ', @errors);
|
|
}
|