Main Koha release repository https://koha-community.org
Find a file
Aleisha Amohia 930ad0178d
Bug 35587: Do not trigger transfer if lost item returned and BlockReturnOfLostItems enabled
This fixes current buggy behaviour - when BlockReturnOfLostItems is enabled, no transfer should be triggered and the lost status should be retained.

To test:

1. Go to Koha Administration -> Global system preferences
2. Set the BlockReturnOfLostItems system preference to Block
3. Enable the AutomaticItemReturn system preference (this is simply to make testing a bit faster)
4. Take note of your logged in library
5. Search for an item where the home library is NOT the same as your logged in library
6. Edit this item and give it a lost status
7. Check in the item
8. Notice the item is returned and a transfer is automatically triggered
9. If you go to the item record page, the lost status has been remove

10. Apply the patch and restart services

11. Edit the item again and give it a lost status. This will also cancel the transfer
12. Check in the item
13. Confirm the transfer is NOT triggered and the lost status is retained as expected.
14. Go back to system preferences and disable the BlockReturnOfLostItems system preference (set to "Don't block")
15. Check in the item
16. Confirm the transfer is triggered and lost status is removed

17. Confirm tests pass

prove t/db_dependent/Circulation/Returns.t
prove t/db_dependent/Circulation/Branch.t

Sponsored-by: Pymble Ladies' College
Signed-off-by: Esther <esther@bywatersolutions.com>
Signed-off-by: Kelly <kelly@bywatersolutions.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-01-05 14:04:04 +01:00
acqui Bug 34708: Add ability to modify orderline to increase quantity 2023-11-09 10:15:05 -03:00
admin Bug 35460: Fix add and edit of hold rules in circulation rules table 2023-12-11 19:41:26 +01:00
api Bug 35658: Fix misaligned collectionFormat in patron_holds.yaml 2024-01-04 16:51:43 +01:00
authorities Bug 33406: (QA follow-up) Adjust tests and tidy 2023-09-15 15:50:43 -03:00
basket Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
bin
bookings Bug 35574: Bookings tab from biblio details should only require manage_bookings permission 2023-12-18 15:21:04 +01:00
C4 Bug 35587: Do not trigger transfer if lost item returned and BlockReturnOfLostItems enabled 2024-01-05 14:04:04 +01:00
catalogue Bug 35618: Remove deprecated parameter "type" from showelastic.pl page 2023-12-28 12:16:12 +01:00
cataloguing Bug 35414: Silence warn related to number_of_copies 2023-12-11 19:41:24 +01:00
circ Bug 35216: Rename error to issuingimpossible 2023-12-19 13:42:09 +01:00
clubs Bug 25079: Show club enrollment question answers in staff client 2023-06-23 11:00:54 -03:00
course_reserves Bug 20256: Use new methods 2023-02-02 11:59:26 -03:00
debian Bug 35174: update control files for koha-l10n dependency package 2023-11-16 11:31:55 +01:00
docs 23.11.00: Update history.txt 2023-11-30 14:58:48 -03:00
erm Bug 32922: Remove space in shebang 2023-02-20 09:44:06 -03:00
errors
etc Bug 35455: Remove = in ICU for indexing/searching 2023-12-20 15:13:46 +01:00
ill Bug 30719: ILL Batches 2023-10-17 14:45:15 -03:00
installer Bug 35698: (bug 32162 follow-up) fix bug number in db rev 2024-01-04 16:51:44 +01:00
Koha Bug 35579: Cache authorised value lookup by MARC field 2023-12-28 12:16:09 +01:00
koha-tmpl Bug 35696: Fix regression caused by bug 33167 2024-01-05 14:04:04 +01:00
labels Bug 10762: (QA follow-up) Perltidy 2023-10-25 10:35:31 -03:00
lib/CGI/Session/Serialize
members Bug 30287: Conditionally render notice preview 2023-12-19 13:42:10 +01:00
misc Bug 34091: Fix typo log-modules in help for cleanupdatabase.pl 2023-12-11 19:41:27 +01:00
offline_circ Bug 34529: Offline circulation should be able to accept userid as well as cardnumber 2023-11-06 11:34:44 -03:00
opac Bug 35496: (QA follow-up): tidy up code 2023-12-14 16:29:22 +01:00
patron_lists Bug 34977: (QA follow-up) Tidy code 2023-11-08 11:41:33 -03:00
patroncards
plugins Bug 25672: Fix double output_html_with_http_headers 2023-10-31 11:02:45 -03:00
pos Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
preservation Bug 34030: Add a "print slips" action links to print in batch 2023-10-23 11:33:55 -03:00
recalls Bug 34013: Recalls awaiting pickup doesn't show count on each tab 2023-06-23 10:01:04 -03:00
reports Bug 34456: (QA follow-up) perltidy code 2023-11-01 17:23:18 -03:00
reserve Bug 34519: Add a template plugin for fetch searchable patron attributes 2023-11-08 17:52:37 -03:00
reviews
rotating_collections
serials Bug 28012: Use definedness test instead of bool when checking whether to null fields 2023-12-27 19:06:06 +01:00
services
skel
suggestion Bug 35276: Remove authentication params from suggestion hash 2023-11-14 10:32:38 -03:00
svc Bug 35181: Don't pass undef to header 2023-11-06 08:42:46 -03:00
t Bug 35587: Do not trigger transfer if lost item returned and BlockReturnOfLostItems enabled 2024-01-05 14:04:04 +01:00
tags
tools Bug 35291: (QA follow-up) Tidying script for QA test tools 2023-11-24 16:43:25 -03:00
virtualshelves Bug 35547: Show public "staff only" lists in addbybiblionumber.pl 2023-12-27 19:06:03 +01:00
xt Bug 34911: Test files from HEAD instead of 'master' 2023-10-04 09:15:35 -04:00
.editorconfig
.eslintrc.json
.gitignore Bug 35174: Add misc/translator/po to .gitignore 2023-11-16 08:56:36 +01:00
.htaccess
.mailmap 23.11.00: Update mailmap 2023-11-30 14:58:47 -03:00
.perlcriticrc
.perltidyrc Bug 30002: Adjust perltidy 2023-06-08 08:32:42 -03:00
.proverc.dist
.stylelintrc.json
about.pl Bug 35174: Add a warning to the about page 2023-11-16 08:56:36 +01:00
app.psgi
build-resources.PL Bug 32609: Use the current yarn.lock to generate node_modules 2023-02-10 11:07:57 -03:00
changelanguage.pl
cpanfile Bug 34064: Add SQL::Translator dependency to cpanfile 2023-10-10 10:54:04 -03:00
cypress.config.ts Bug 34319: Upgrade cypress 9.7.0 to 12.17.2 2023-09-05 11:52:25 -03:00
fix-perl-path.PL
gulpfile.js Bug 35428: Remove temporary files for gulp po tasks 2023-12-12 15:04:54 +01:00
help.pl
INSTALL
Koha.pm Bug 31297: DBRev 23.12.00.002 2023-12-27 19:06:05 +01:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 35019: Add a CSRF token when deleting news 2023-10-20 17:22:02 -03:00
Makefile.PL Bug 29002: Update Makefile 2023-11-03 12:04:27 -03:00
MANIFEST.SKIP
package.json Bug 34319: Upgrade cypress 9.7.0 to 12.17.2 2023-09-05 11:52:25 -03:00
README
README.md
README.robots
rewrite-config.PL
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
webpack.config.js Bug 30708: Vue app 2023-10-18 15:41:40 -03:00
yarn.lock Bug 34319: Update yarn.lock 2023-09-05 11:52:25 -03:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo