Koha/C4/Installer/PerlModules.pm
Jonathan Druart 9d6d641d1f Bug 17600: Standardize our EXPORT_OK
On bug 17591 we discovered that there was something weird going on with
the way we export and use subroutines/modules.
This patch tries to standardize our EXPORT to use EXPORT_OK only.

That way we will need to explicitely define the subroutine we want to
use from a module.

This patch is a squashed version of:
Bug 17600: After export.pl
Bug 17600: After perlimport
Bug 17600: Manual changes
Bug 17600: Other manual changes after second perlimports run
Bug 17600: Fix tests

And a lot of other manual changes.

export.pl is a dirty script that can be found on bug 17600.

"perlimport" is:
git clone https://github.com/oalders/App-perlimports.git
cd App-perlimports/
cpanm --installdeps .
export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib"
find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \;

The ideas of this patch are to:
* use EXPORT_OK instead of EXPORT
* perltidy the EXPORT_OK list
* remove '&' before the subroutine names
* remove some uneeded use statements
* explicitely import the subroutines we need within the controllers or
modules

Note that the private subroutines (starting with _) should not be
exported (and not used from outside of the module except from tests).

EXPORT vs EXPORT_OK (from
https://www.thegeekstuff.com/2010/06/perl-exporter-examples/)
"""
Export allows to export the functions and variables of modules to user’s namespace using the standard import method. This way, we don’t need to create the objects for the modules to access it’s members.

@EXPORT and @EXPORT_OK are the two main variables used during export operation.

@EXPORT contains list of symbols (subroutines and variables) of the module to be exported into the caller namespace.

@EXPORT_OK does export of symbols on demand basis.
"""

If this patch caused a conflict with a patch you wrote prior to its
push:
* Make sure you are not reintroducing a "use" statement that has been
removed
* "$subroutine" is not exported by the C4::$MODULE module
means that you need to add the subroutine to the @EXPORT_OK list
* Bareword "$subroutine" not allowed while "strict subs"
means that you didn't imported the subroutine from the module:
  - use $MODULE qw( $subroutine list );
You can also use the fully qualified namespace: C4::$MODULE::$subroutine

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-07-16 08:58:47 +02:00

205 lines
5.9 KiB
Perl

package C4::Installer::PerlModules;
use warnings;
use strict;
use File::Basename qw( dirname );
use Module::CPANfile;
sub new {
my $invocant = shift;
my $self = {
missing_pm => [],
upgrade_pm => [],
current_pm => [],
};
my $type = ref($invocant) || $invocant;
bless ($self, $type);
return $self;
}
sub prereqs {
my $self = shift;
unless (defined $self->{prereqs}) {
my $filename = $INC{'C4/Installer/PerlModules.pm'};
my $path = dirname(dirname(dirname($filename)));
$self->{prereqs} = Module::CPANfile->load("$path/cpanfile")->prereqs;
}
return $self->{prereqs};
}
sub prereq_pm {
my $self = shift;
my $prereq_pm = {};
my $reqs = $self->prereqs->merged_requirements;
foreach my $module ($reqs->required_modules) {
$prereq_pm->{$module} = $reqs->requirements_for_module($module);
}
return $prereq_pm;
}
sub versions_info {
my $self = shift;
# Reset these arrayref each pass through to ensure current information
$self->{'missing_pm'} = [];
$self->{'upgrade_pm'} = [];
$self->{'current_pm'} = [];
foreach my $phase ($self->prereqs->phases) {
foreach my $type ($self->prereqs->types_in($phase)) {
my $reqs = $self->prereqs->requirements_for($phase, $type);
foreach my $module ($reqs->required_modules) {
no warnings; # perl throws warns for invalid $VERSION numbers which some modules use
my $module_infos = {
cur_ver => 0,
required => $type eq 'requires',
};
my $vers = $reqs->structured_requirements_for_module($module);
for my $req (@$vers) {
if ( $req->[0] eq '>=' || $req->[0] eq '>' ) {
$module_infos->{min_ver} = $req->[1];
} elsif ( $req->[0] eq '<=' || $req->[0] eq '<' ) {
$module_infos->{max_ver} = $req->[1];
} else {
push @{$module_infos->{exc_ver}}, $req->[1];
}
}
my $attr;
$Readonly::XS::MAGIC_COOKIE="Do NOT use or require Readonly::XS unless you're me.";
eval "require $module";
if ($@) {
$attr = 'missing_pm';
} else {
my $pkg_version = $module->can("VERSION") ? $module->VERSION : 0;
$module_infos->{cur_ver} = $pkg_version;
if ($reqs->accepts_module($module => $pkg_version)) {
$attr = 'current_pm';
} else {
$attr = 'upgrade_pm';
}
}
push @{ $self->{$attr} }, { $module => $module_infos };
}
}
}
}
sub get_attr {
return $_[0]->{$_[1]};
}
1;
__END__
=head1 NAME
C4::Installer::PerlModules
=head1 ABSTRACT
A module for manipulating Koha Perl dependency list objects.
=head1 METHODS
=head2 new()
Creates a new PerlModules object
example:
C<my $perl_modules = C4::Installer::PerlModules->new;>
=head2 prereq_pm()
Returns a hashref of a hash of module information suitable for use in Makefile.PL
example:
C<my $perl_modules = C4::Installer::PerlModules->new;
...
PREREQ_PM => $perl_modules->prereq_pm,>
=head2 versions_info
C<$perl_modules->versions_info;>
This loads info of required modules into three accessors: missing_pm,
upgrade_pm, and current_pm. Each of these may be accessed by using the
C<get_attr> method. Each accessor returns an anonymous array who's
elements are anonymous hashes. They follow this format (NOTE: Upgrade
status is indicated by the accessor name.):
[
{
'Text::CSV::Encoded' => {
'required' => 1,
'cur_ver' => 0.09,
'min_ver' => '0.09'
}
},
{
'Biblio::EndnoteStyle' => {
'required' => 1,
'cur_ver' => 0,
'min_ver' => '0.05'
}
},
}
=head2 get_attr(attr_name)
Returns an anonymous array containing the contents of the passed in accessor. Valid accessors are:
missing_pm - Perl modules used by Koha but not currently installed.
upgrade_pm - Perl modules currently installed but below the minimum version required by Koha.
current_pm - Perl modules currently installed and up to date as required by Koha.
example:
C<my $missing_pm = $perl_modules->get_attr('missing_pm');>
=head1 AUTHOR
Chris Nighswonger <cnighswonger AT foundations DOT edu>
=head1 COPYRIGHT
Copyright 2010 Foundations Bible College.
=head1 LICENSE
This file is part of Koha.
Koha is free software; you can redistribute it and/or modify it
under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
Koha is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Koha; if not, see <http://www.gnu.org/licenses>.
=head1 DISCLAIMER OF WARRANTY
Koha is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
A PARTICULAR PURPOSE. See the GNU General Public License for more details.
=cut