Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Robin Sheat 95056d17b7 Bug 11947 - renumber reserves when hold is confirmed 
Currently when a reserve is moved to "waiting" status because it's
acknowledged on checkin, the reserve priorities aren't renumbered. This
causes things to go a bit haywire in the UI, in particular, some
reserves can unjustly end up with priority 1 when they shouldn't. It
also seemed to mess with the logic of who should get it next, but I
didn't look too closely at that.

This patch forces a renumbering so that all the priorities remain
copacetic.

Test plan:
* have a few borrowers, say 4.
* have a biblio with a single item (you can scale this up, it should
  work just the same.)
* issue the item to borrower A
* have borrowers B, C, and D place a hold on the item
* return the item, acknowledge that it'll be put aside for B.
* view the holds on the item.
Without the patch:
* the hold priorities in the UI end up being "waiting, 2, 1" when they
  should be "waiting, 1, 2".
* in the database "reserves" table, they're really "0, 2, 3" when they
  should be "0, 1, 2".
With the patch:
* the hold priorities in the UI end up being "waiting, 1, 2"
* in the database, they're "0, 1, 2"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Test plan confirms that the problem exists and that the patch corrects
it.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script, especially t/db_dependent/Reserves.t.
Improves priority calculation.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2014-04-15 14:18:19 +00:00
..
Acquisition Bug 11549: Add regression test 2014-01-23 16:17:24 +00:00
Circulation Bug 11338: add unit tests for DelItemCheck 2013-12-25 17:07:53 +00:00
data Bug 11096: add regression tests for indexing/retrieving large MARC records 2014-02-28 19:48:37 +00:00
Koha Bug 11279: (follow-up) remove unnecessary check on number of quotes 2013-12-19 15:06:39 +00:00
Labels Bug 10333: Labels/t_Batch.t needs to create its own data 2013-09-08 02:07:19 +00:00
LDAP DB-dependent tests moved 2008-01-08 14:07:38 -06:00
Members Bug 10481: Unit tests for C4::Members::AddEnrolmentFeeIfNeeded 2013-08-16 15:08:41 +00:00
Record 7661 Followup for resolving moved Record test 2012-03-14 14:59:46 +01:00
Reports Bug 8594 - prevent the report system from breaking some subqueries 2012-09-05 10:12:06 +02:00
Serials Bug 7688: (follow-up) rewrite 'for' loop in unit tests 2013-10-30 00:38:52 +00:00
www Bug 8300: Add mechanized unit test for batch import 2013-05-01 07:57:11 -04:00
00-strict.t Bug 8383: Add test to check that Perl scripts compile 2012-07-10 11:13:40 +02:00
Accounts.t Bug 5327 Made test file for Accounts.pm 2011-01-20 19:57:50 +13:00
Acquisition.t Bug 11550: Add UT for C4::Acquisition::GetOrder 2014-03-12 14:16:20 +00:00
Amazon.t Bug 5327 - Now we are doing db calls, we need to shift this to t/db_dependent 2011-01-19 13:38:52 +13:00
Auth.t Bug 10952: (follow-up) remove mention of KohaOpacRecentSearches cookie 2014-01-10 16:55:37 +00:00
Auth_SearchHistorySession.t Bug 10952: (follow-up) comments fixes and unit tests 2014-01-10 16:21:18 +00:00
Auth_with_cas.t Bug 5477 [SIGN-OFF] Fix test cases that require database access 2011-01-29 17:02:31 +13:00
AuthoritiesMarc.t Bug 8890 - move two more db dependent tests 2012-10-24 17:52:42 +02:00
BackgroundJob.t Bug 10601: (follow-up) unit tests for new ->set() and ->get() 2013-09-18 17:21:47 +00:00
Barcodes.t Bug 6448 [2/3] Barcodes::EAN13 autoBarcode 2012-08-02 18:41:44 +02:00
Biblio.t Bug 7576: Add ISSN to SearchForTitleIn preference 2012-02-27 11:44:20 +01:00
Bookseller.t Bug 11457: avoid spurious test failure in t/db_dependent/Bookseller.t 2014-01-09 19:09:56 +00:00
Borrower_Debarments.t Bug 2720: (follow-up) improve unit tests 2013-10-31 01:55:04 +00:00
Branch.t Bug 10508: (follow-up) remove Perl 5.14 construct 2013-08-28 14:24:34 +00:00
Budgets.t Bug 8037: (follow-up) improve GetBudgetByOrderNumber test 2013-10-31 14:57:18 +00:00
Category.t Bug 11543: (followup) add one more test 2014-01-15 19:58:30 +00:00
check_sysprefs.t Bug 8353 follow-up: Perltidy new test 2012-07-13 14:42:52 +02:00
Circulation.t Bug 7413: (follow-up) add direct unit tests 2014-04-08 23:05:13 +00:00
Circulation_Branch.t Bug 10683: (follow-up) improvements to the unit tests 2013-10-09 03:51:55 +00:00
Circulation_issue.t Bug 10493: (follow-up) fix test errors 2013-10-23 04:25:34 +00:00
Circulation_Issuingrule.t Bug 7413: Unit test 2014-04-07 18:28:58 +00:00
Circulation_issuingrules.t Bug 11934: (follow-up) tidy up whitespace 2014-03-13 15:18:49 +00:00
Circulation_OfflineOperation.t Bug 10710: (follow-up) perltidy new code 2013-08-28 14:52:43 +00:00
Circulation_transfers.t Bug 11470: fix occassional spurious test failure in Circulation_transfers.t 2014-01-06 05:31:21 +00:00
ClassSource.t Bug 10644: (follow-up) remove inadvertant dependence on Perl 5.14 2013-08-09 18:53:20 +00:00
Context.t Bug 11701: (follow-up) move unit tests to t/db_dependent 2014-03-25 14:41:07 +00:00
CourseReserves.t Bug 10332: further improvements to course reserves tests 2013-06-18 16:40:43 -07:00
Csv.t Bug 10853: (follow-up) expand unit tests for C4::Csv 2013-10-11 03:25:42 +00:00
External_BakerTaylor.t Bug 5327: Unit tests for C4/Exteral/BakerTaylor.pm 2011-12-07 16:17:05 +01:00
Heading_MARC21.t Merge remote-tracking branch 'origin/new/bug_7284' 2012-04-04 18:18:26 +02:00
Holds.t Bug 10452: [QA Followup] - Unit tests 2014-03-10 18:15:33 +00:00
HoldsQueue.t Bug 10243: (follow-up) add unit tests 2013-10-30 03:13:23 +00:00
Holidays.t Bug 11112: (follow-up) repair Koha::Calendar->add_holiday() 2013-12-10 18:19:15 +00:00
ILSDI_Services.t Bug 10667: (follow-up) fix reference to UT library in test case 2013-09-16 19:22:22 +00:00
Installer.t Bug 11541: (follow-up) move Installer.t to t/db_dependent 2014-01-14 21:43:56 +00:00
Items.t Bug 10872: UT for GetHiddenItemnumbers and POD fix 2013-09-18 15:55:46 +00:00
KitchenSinkPlugin.kpz Bug 7804 - Add Koha Plugin System - QA Followup 3 - Additional Unit Tests 2013-03-20 14:50:38 -04:00
Koha.t Bug 10078: (follow-up) add regression test 2013-10-30 05:02:45 +00:00
Koha_Authority.t Bug 5202: merge authorities from the authority file and reservoir 2013-10-10 21:32:27 +00:00
Koha_borrower_modifications.t Bug 7067 - QA Followup - Fix failing tests 2012-12-14 08:09:01 -05:00
Koha_Database.t Bug 11906: regression test for using DBIC to store & fetch UTF8 strings 2014-03-27 14:44:39 +00:00
Koha_template_plugin_Branches.t Bug 11779: (follow-up) improve GetLoggedInBranchcode() and add test cases 2014-02-19 16:40:06 +00:00
Koha_template_plugin_KohaDates.t Bug 929 : Follow up, shifting test 2012-02-07 16:42:22 +01:00
Languages.t Bug 11545: (follow-up) move Languages.t to t/db_dependent 2014-01-14 20:48:33 +00:00
Letters.t Bug 11208: regression test for failing SMS messages 2013-12-30 16:45:45 +00:00
Linker_FirstMatch.t Bug 7724: Skip Linker test if Zebra isn't set up 2012-03-20 11:21:10 +01:00
Log.t Fixing a broken test 2011-09-26 11:55:58 +13:00
MarcModificationTemplates.t Bug 8015: Add unit tests for SimpleMARC and MarcModificationTemplates routines 2013-10-31 22:50:11 +00:00
Members.t Bug 108661: (follow-up) enshrine letting CardnumberLength specify just a maximum 2014-03-12 04:07:03 +00:00
Members_columns.t Bug 7785: (follow-up) standardize POD 2013-08-13 16:15:30 +00:00
NewsChannels.t Bug 7567: (follow-up) make tests of get_opac_new more readable 2014-04-07 18:14:20 +00:00
PatronLists.t Bug 10565: (follow-up) don't assume borrowernumber 1 exists in unit test 2013-10-14 21:30:34 +00:00
Plugins.t Bug 9909: Don't install KitchenSink plugin if plugin dir isn't writable 2013-03-22 21:52:41 -04:00
Ratings.t Bug 5668 - Star ratings in the opac 2012-04-10 14:40:49 +02:00
Record.t Bug 11066: (follow-up) add regression test 2014-01-03 15:54:45 +00:00
RecordProcessor_EmbedSeeFromHeadings.t Bug 7417: Include see from references in bibliographic searches 2012-09-13 14:19:28 +02:00
Reports.t Bug 5327: Shifting a db dependent test to the right place 2012-02-01 18:15:19 +01:00
Reports_Guided.t Bug 10761: (follow-up) remove inadvertant dependence on Perl 5.14 2013-08-21 16:29:18 +00:00
ReportsGuided.t Bug 9659 follow-up: correct syntax for older Perl 2013-04-26 21:32:49 -04:00
Reserves.t Bug 11947 - renumber reserves when hold is confirmed 2014-04-15 14:18:19 +00:00
rollingloans.t Bug 5549 : Fixing the test to only run if the test data exists 2012-03-27 09:18:37 +02:00
RotatingCollections.t Bug 10653: (follow-up) minor tweaks to RotatingCollections tests 2013-08-16 16:09:13 +00:00
Search.t Bug 11096: support the retrieval of large MARCXML records 2014-02-28 19:50:09 +00:00
Search_SearchHistory.t Bug 10361: (follow-up) add tests for search history functions 2013-09-04 14:22:50 +00:00
Serials.t Bug 7688: (follow-up) have Serials.t create its test subscription 2013-10-31 05:07:44 +00:00
Serials_2.t Bug 8435: (follow-up) handle lack of userenv gracefully 2013-10-31 15:29:42 +00:00
Service.t Bug 5477 [SIGN-OFF] Fix test cases that require database access 2011-01-29 17:02:31 +13:00
ShelfBrowser.t Bug 10856: Improve the previous and next items on the shelf browser 2013-10-04 15:56:35 +00:00
SIP_ILS.t Bug 5327 : Removing a broken test 2012-02-13 15:04:43 +01:00
SQLHelper.t Bug 5327 : Fixing unit test for SQLHelper.pm 2011-12-07 16:17:10 +01:00
SuggestionEngine_ExplodedTerms.t Bug 8846 conflict resolution: correct path 2012-11-01 08:41:30 -04:00
Suggestions.t Bug 5346: Linking suggestions and orders. 2012-02-17 10:27:52 +01:00
sysprefs.t Bug 10325: (follow-up) add test for overriding system preferences 2013-09-08 02:28:45 +00:00
Tags.t Bug 7642 - fix the lost display of tag sizes 2012-10-01 17:38:27 +02:00
UploadedFile.t t/UploadedFile, updated comment 2011-12-07 16:37:31 +01:00
VirtualShelves.t Bug 10499: VirtualShelves.t - wrap tests in a database transaction 2013-07-16 14:17:27 +00:00
VirtualShelves_Page.t Bug 5477 [SIGN-OFF] Fix test cases that require database access 2011-01-29 17:02:31 +13:00
XISBN.t Bug 11439: (follow-up) adjust for change in list returned by OCLC XISBN 2014-01-30 15:48:48 +00:00
zebra_config.pl Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00