Koha/Koha/REST/V1.pm
Marcel de Rooy a3ce05012b
Bug 34271: Remove a few Logger statements from REST API
See also bug 22678.
We should call app->log->warn, ->debug, etc. instead of Logger.

Test plan:
The simplest way I tested V1, is add a app->log->warn in the try
blocks, restart all and check that your log4perl is set correctly
too.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-18 10:26:03 -03:00

161 lines
4.8 KiB
Perl

package Koha::REST::V1;
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use Mojo::Base 'Mojolicious';
use C4::Context;
use Koha::Logger;
use Koha::Auth::Identity::Providers;
use Mojolicious::Plugin::OAuth2;
use JSON::Validator::Schema::OpenAPIv2;
use Try::Tiny qw( catch try );
use JSON qw( decode_json );
=head1 NAME
Koha::REST::V1 - Main v.1 REST api class
=head1 API
=head2 Class Methods
=head3 startup
Overloaded Mojolicious->startup method. It is called at application startup.
=cut
sub startup {
my $self = shift;
my $logger = Koha::Logger->get({ interface => 'api' });
$self->log($logger);
$self->hook(
before_dispatch => sub {
my $c = shift;
# Remove /api/v1/app.pl/ from the path
$c->req->url->base->path('/');
# Handle CORS
$c->res->headers->header( 'Access-Control-Allow-Origin' =>
C4::Context->preference('AccessControlAllowOrigin') )
if C4::Context->preference('AccessControlAllowOrigin');
}
);
# Force charset=utf8 in Content-Type header for JSON responses
$self->types->type( json => 'application/json; charset=utf8' );
# MARC-related types
$self->types->type( marcxml => 'application/marcxml+xml' );
$self->types->type( mij => 'application/marc-in-json' );
$self->types->type( marc => 'application/marc' );
my $secret_passphrase = C4::Context->config('api_secret_passphrase');
if ($secret_passphrase) {
$self->secrets([$secret_passphrase]);
}
my $spec_file = $self->home->rel_file("api/v1/swagger/swagger.yaml");
push @{$self->routes->namespaces}, 'Koha::Plugin';
# Try to load and merge all schemas first and validate the result just once.
try {
my $schema = JSON::Validator::Schema::OpenAPIv2->new;
$schema->resolve( $spec_file );
my $spec = $schema->bundle->data;
$self->plugin(
'Koha::REST::Plugin::PluginRoutes' => {
spec => $spec,
validate => 0,
}
) unless C4::Context->needs_install; # load only if Koha is installed
$self->plugin(
OpenAPI => {
spec => $spec,
route => $self->routes->under('/api/v1')->to('Auth#under'),
}
);
$self->plugin('RenderFile');
}
catch {
# Validation of the complete spec failed. Resort to validation one-by-one
# to catch bad ones.
# JSON::Validator uses confess, so trim call stack from the message.
$self->app->log->error("Warning: Could not load REST API spec bundle: " . $_);
try {
my $schema = JSON::Validator::Schema::OpenAPIv2->new;
$schema->resolve( $spec_file );
my $spec = $schema->bundle->data;
$self->plugin(
'Koha::REST::Plugin::PluginRoutes' => {
spec => $spec,
validate => 1
}
) unless C4::Context->needs_install; # load only if Koha is installed
$self->plugin(
OpenAPI => {
spec => $spec,
route => $self->routes->under('/api/v1')->to('Auth#under'),
}
);
}
catch {
# JSON::Validator uses confess, so trim call stack from the message.
$self->app->log->error("Warning: Could not load REST API spec bundle: " . $_);
};
};
my $oauth_configuration = {};
try {
my $search_options = { protocol => [ "OIDC", "OAuth" ] };
my $providers = Koha::Auth::Identity::Providers->search($search_options);
while ( my $provider = $providers->next ) {
$oauth_configuration->{ $provider->code } = decode_json( $provider->config );
}
} catch {
$self->app->log->warn( "Warning: Failed to fetch oauth configuration: " . $_ );
};
$self->plugin( 'Koha::REST::Plugin::Pagination' );
$self->plugin( 'Koha::REST::Plugin::Query' );
$self->plugin( 'Koha::REST::Plugin::Objects' );
$self->plugin( 'Koha::REST::Plugin::Exceptions' );
$self->plugin( 'Koha::REST::Plugin::Auth::IdP' );
$self->plugin( 'Mojolicious::Plugin::OAuth2' => $oauth_configuration );
}
1;