Jonathan Druart
9d6d641d1f
On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. This patch is a squashed version of: Bug 17600: After export.pl Bug 17600: After perlimport Bug 17600: Manual changes Bug 17600: Other manual changes after second perlimports run Bug 17600: Fix tests And a lot of other manual changes. export.pl is a dirty script that can be found on bug 17600. "perlimport" is: git clone https://github.com/oalders/App-perlimports.git cd App-perlimports/ cpanm --installdeps . export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib" find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \; The ideas of this patch are to: * use EXPORT_OK instead of EXPORT * perltidy the EXPORT_OK list * remove '&' before the subroutine names * remove some uneeded use statements * explicitely import the subroutines we need within the controllers or modules Note that the private subroutines (starting with _) should not be exported (and not used from outside of the module except from tests). EXPORT vs EXPORT_OK (from https://www.thegeekstuff.com/2010/06/perl-exporter-examples/) """ Export allows to export the functions and variables of modules to user’s namespace using the standard import method. This way, we don’t need to create the objects for the modules to access it’s members. @EXPORT and @EXPORT_OK are the two main variables used during export operation. @EXPORT contains list of symbols (subroutines and variables) of the module to be exported into the caller namespace. @EXPORT_OK does export of symbols on demand basis. """ If this patch caused a conflict with a patch you wrote prior to its push: * Make sure you are not reintroducing a "use" statement that has been removed * "$subroutine" is not exported by the C4::$MODULE module means that you need to add the subroutine to the @EXPORT_OK list * Bareword "$subroutine" not allowed while "strict subs" means that you didn't imported the subroutine from the module: - use $MODULE qw( $subroutine list ); You can also use the fully qualified namespace: C4::$MODULE::$subroutine Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
210 lines
5.2 KiB
Perl
210 lines
5.2 KiB
Perl
package Koha::RecordProcessor;
|
|
|
|
# Copyright 2012 C & P Bibliography Services
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
=head1 NAME
|
|
|
|
Koha::RecordProcessor - Dispatcher class for record normalization
|
|
|
|
=head1 SYNOPSIS
|
|
|
|
use Koha::RecordProcessor;
|
|
my $normalizer = Koha::RecordProcessor(%params);
|
|
$normalizer->process($record)
|
|
|
|
=head1 DESCRIPTION
|
|
|
|
Dispatcher class for record normalization. RecordProcessors must
|
|
extend Koha::RecordProcessor::Base, be in the Koha::Filter namespace,
|
|
and provide the following methods:
|
|
|
|
B<filter ($record)> - apply the filter and return the result. $record
|
|
may be either a scalar or an arrayref, and the return result will be
|
|
the same type.
|
|
|
|
These methods may be overriden:
|
|
|
|
B<initialize (%params)> - initialize the filter
|
|
|
|
B<destroy ()> - destroy the filter
|
|
|
|
These methods should not be overridden unless you are very sure of what
|
|
you are doing:
|
|
|
|
B<new ()> - create a new filter object
|
|
|
|
Note that the RecordProcessor will not clone the record that is
|
|
passed in. If you do not want to change the original MARC::Record
|
|
object (or whatever type of object you are passing in), you must
|
|
clone it I<prior> to passing it off to the RecordProcessor.
|
|
|
|
=head1 FUNCTIONS
|
|
|
|
=cut
|
|
|
|
use Modern::Perl;
|
|
|
|
use Module::Load::Conditional qw( can_load );
|
|
use Module::Pluggable::Object;
|
|
|
|
use base qw(Class::Accessor);
|
|
|
|
__PACKAGE__->mk_accessors(qw( schema filters options record ));
|
|
|
|
=head2 new
|
|
|
|
my $normalizer = Koha::RecordProcessor->new(%params);
|
|
|
|
Create a new normalizer. Available parameters are:
|
|
|
|
=over 8
|
|
|
|
=item B<schema>
|
|
|
|
Which metadata schema is in use. At the moment the only supported schema
|
|
is 'MARC'.
|
|
|
|
=item B<filters>
|
|
|
|
What filter(s) to use. This must be an arrayref to a list of filters. Filters
|
|
can be specified either with a complete class path, or, if they are in the
|
|
Koha::Filter::${schema} namespace, as only the filter name, and
|
|
"Koha::Filter::${schema}" will be prepended to it before the filter is loaded.
|
|
|
|
=back
|
|
|
|
=cut
|
|
sub new {
|
|
|
|
my $class = shift;
|
|
my $param = shift;
|
|
|
|
|
|
my $schema = $param->{schema} || 'MARC';
|
|
my $options = $param->{options} || '';
|
|
|
|
my $req_filters = ( ref($param->{filters}) ne 'ARRAY' )
|
|
? [ $param->{filters} ]
|
|
: $param->{filters};
|
|
my @filters = ( );
|
|
|
|
foreach my $filter_name (@{ $req_filters }) {
|
|
next unless $filter_name;
|
|
# Fully qualify the module name.
|
|
my $filter_module = $filter_name =~ m/:/ ? $filter_name : "Koha::Filter::${schema}::${filter_name}";
|
|
if (can_load( modules => { $filter_module => undef } )) {
|
|
my $filter = $filter_module->new();
|
|
$filter->initialize($param);
|
|
push @filters, $filter;
|
|
}
|
|
}
|
|
|
|
my $self = $class->SUPER::new( { schema => $schema,
|
|
filters => \@filters,
|
|
options => $options });
|
|
bless $self, $class;
|
|
return $self;
|
|
}
|
|
|
|
=head3 options
|
|
|
|
$processor->options( $new_options );
|
|
|
|
Overloaded accessor, that spreads the new options to the filter objects when set
|
|
|
|
=cut
|
|
|
|
sub options {
|
|
my ( $self, $options ) = @_;
|
|
|
|
if ( $options ) { # Set
|
|
foreach my $filter ( @{$self->filters} ) {
|
|
$filter->params->{options} = $options;
|
|
}
|
|
|
|
$self->{options} = $options;
|
|
return $self;
|
|
}
|
|
|
|
return $self->{options};
|
|
}
|
|
|
|
=head2 bind
|
|
|
|
$normalizer->bind($record)
|
|
|
|
Bind a normalizer to a particular record.
|
|
|
|
=cut
|
|
sub bind {
|
|
my $self = shift;
|
|
my $record = shift;
|
|
|
|
$self->{record} = $record;
|
|
return;
|
|
}
|
|
|
|
=head2 process
|
|
|
|
my $newrecord = $normalizer->process([$record])
|
|
|
|
Run the record(s) through the normalization pipeline. If $record is
|
|
not specified, process the record the normalizer is bound to.
|
|
Note that $record may be either a scalar or an arrayref, and the
|
|
return value will be of the same type.
|
|
|
|
=cut
|
|
sub process {
|
|
my $self = shift;
|
|
my $record = shift || $self->record;
|
|
|
|
return unless defined $record;
|
|
|
|
foreach my $filterobj (@{$self->filters}) {
|
|
next unless $filterobj;
|
|
$filterobj->filter($record);
|
|
}
|
|
|
|
return $record;
|
|
}
|
|
|
|
sub DESTROY {
|
|
my $self = shift;
|
|
|
|
foreach my $filterobj (@{$self->filters}) {
|
|
$filterobj->destroy();
|
|
}
|
|
}
|
|
|
|
=head2 AvailableFilters
|
|
|
|
my @available_filters = Koha::RecordProcessor::AvailableFilters([$schema]);
|
|
|
|
Get a list of available filters. Optionally specify the metadata schema.
|
|
At present only MARC is supported as a schema.
|
|
|
|
=cut
|
|
sub AvailableFilters {
|
|
my $schema = pop || '';
|
|
my $path = 'Koha::Filter';
|
|
$path .= "::$schema" if ($schema eq 'MARC');
|
|
my $finder = Module::Pluggable::Object->new(search_path => $path);
|
|
return $finder->plugins;
|
|
}
|
|
|
|
1;
|