dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
190 lines
9.4 KiB
Text
190 lines
9.4 KiB
Text
[% SET footerjs = 1 %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Tools › Patron card creator › Images</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
</head>
|
|
|
|
<body id="pcard_image-manage" class="tools pcard">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'cat-search.inc' %]
|
|
<div id="breadcrumbs">
|
|
<a href="/cgi-bin/koha/mainpage.pl">Home</a> ›
|
|
<a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> ›
|
|
<a href="/cgi-bin/koha/patroncards/home.pl">Patron card creator</a> ›
|
|
Images
|
|
</div>
|
|
<div id="doc3" class="yui-t2">
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
<div class="yui-b">
|
|
<div class="yui-g">
|
|
[% INCLUDE 'patroncards-toolbar.inc' %]
|
|
<div class="yui-u first">
|
|
|
|
</div>
|
|
</div>
|
|
[% INCLUDE 'patroncards-errors.inc' %]
|
|
<div class="yui-g">
|
|
<div class="yui-u first">
|
|
<h1>Upload additional images for patron cards</h1>
|
|
<p>Manage additional images to use as logo, decoration or background on a patron card layout.</p>
|
|
<form name="upload_images" method="post" action="/cgi-bin/koha/patroncards/image-manage.pl" enctype="multipart/form-data">
|
|
<fieldset class="brief">
|
|
<div class="hint">Only PNG, GIF, JPEG, XPM formats are supported. Maximum image size is 500KB.</div>
|
|
<ol>
|
|
<li>
|
|
<label for="uploadfile">Select the file to upload: </label>
|
|
<input type="file" id="uploadfile" name="uploadfile" />
|
|
<input type="hidden" id="image" name="filetype" value="image" />
|
|
</li>
|
|
<li>
|
|
<label for="image_name">Image name: </label>
|
|
<div class="hint">
|
|
This will be the name by which you will refer to this image in the patron card layout editor.
|
|
</div>
|
|
<div class="hint">
|
|
To replace an image, delete it, upload a new file and give it the same image name.
|
|
</div>
|
|
|
|
<input type="text" id="image_name" name="image_name" size="20" />
|
|
</li>
|
|
</ol>
|
|
<div class="action">
|
|
<input type="hidden" name="op" value="upload" />
|
|
<input class="btn btn-default btn-default" id="uploadsu" type="submit" value="Upload" />
|
|
</div>
|
|
[% IF ( IMPORT_SUCCESSFUL ) %]
|
|
<div class="dialog message">
|
|
<h3>Image successfully uploaded</h3>
|
|
<ul><li>File: [% SOURCE_FILE | html %]</li>
|
|
<li>Image name: [% IMAGE_NAME | html %]</li></ul>
|
|
</div>
|
|
[% END %]
|
|
</fieldset>
|
|
|
|
</form>
|
|
</div>
|
|
<div class="yui-u">
|
|
<h1>Delete Images</h1>
|
|
[% IF ( TABLE ) %]
|
|
<form name="delete_images" method="post" action="/cgi-bin/koha/patroncards/image-manage.pl" enctype="multipart/form-data">
|
|
<fieldset class="brief">
|
|
<div class="hint">
|
|
Select one or more images to delete.
|
|
</div>
|
|
<table>
|
|
[% FOREACH TABL IN TABLE %]
|
|
|
|
[% IF ( TABL.header_fields ) %]
|
|
|
|
<tr>
|
|
[% FOREACH header_field IN TABL.header_fields %]
|
|
[% SWITCH header_field.field_label -%]
|
|
[% CASE "ID" %]
|
|
<th>Image ID</th>
|
|
[% CASE "Name" %]
|
|
<th>Name</th>
|
|
[% CASE " " %]
|
|
<th>Delete</th>
|
|
[% CASE %]
|
|
<th>[% header_field.field_label | html %]</th>
|
|
[% END %]
|
|
[% END %]
|
|
</tr>
|
|
[% ELSE %]
|
|
<tr>
|
|
[% FOREACH text_field IN TABL.text_fields %]
|
|
[% IF ( text_field.select_field ) %]
|
|
<td>
|
|
<a class="delete_image btn btn-default btn-xs" href="/cgi-bin/koha/patroncards/image-manage.pl?op=delete&image_id=[% text_field.field_value | html %]"><i class="fa fa-trash"></i> Delete</a>
|
|
</td>
|
|
<td align="center"><input type="checkbox" name="action" value="[% text_field.field_value | html %]" /></td>
|
|
[% ELSIF ( text_field.field_value ) %]
|
|
<td>[% text_field.field_value | html %]</td>
|
|
[% ELSE %]
|
|
<td> </td>
|
|
[% END %]
|
|
[% END %]
|
|
</tr>
|
|
[% END %]
|
|
[% END %]
|
|
</table>
|
|
<div class="action">
|
|
<input type="hidden" name="op" value="delete" />
|
|
<input class="btn btn-default btn-default" type="button" id="delete" value="Delete selected" />
|
|
</div>
|
|
[% IF ( DELETE_SUCCESSFULL ) %]
|
|
<div id="dialog" class="dialog message">
|
|
<h3>Image(s) successfully deleted</h3>
|
|
</div>
|
|
[% END %]
|
|
</fieldset>
|
|
</form>
|
|
[% ELSE %]
|
|
<fieldset class="brief">
|
|
<div class="hint">
|
|
No images are currently available.
|
|
</div>
|
|
[% IF ( DELETE_SUCCESSFULL ) %]
|
|
<div id="dialog" class="dialog message">
|
|
<h3>Image(s) successfully deleted</h3>
|
|
</div>
|
|
[% END %]
|
|
</fieldset>
|
|
[% END %]
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<div class="yui-b">
|
|
[% INCLUDE 'tools-menu.inc' %]
|
|
</div>
|
|
</div>
|
|
|
|
[% MACRO jsinclude BLOCK %]
|
|
<script>
|
|
function DeleteConfirm() {
|
|
var results = selected_images("delete");
|
|
if (results.images) {
|
|
var msg = _("Are you sure you want to delete image(s): %s?").format(results.image_ids);
|
|
var answer = confirm(msg);
|
|
if (answer) {
|
|
window.location = "/cgi-bin/koha/patroncards/image-manage.pl?op=delete&" + results.images;
|
|
} else {
|
|
return; // abort delete
|
|
}
|
|
} else {
|
|
alert(_("Please select image(s) to delete."));
|
|
}
|
|
}
|
|
|
|
function selected_images(op) {
|
|
var selected = new Array;
|
|
var image_ids = new Array;
|
|
if (document.delete_images.action.length) {
|
|
for (i=0;i<document.delete_images.action.length;i++){
|
|
if (document.delete_images.action[i].checked){
|
|
selected.push("image_id=" + document.delete_images.action[i].value);
|
|
image_ids.push(document.delete_images.action[i].value);
|
|
}
|
|
}
|
|
images = selected.join("&");
|
|
return {images:images, image_ids:image_ids};
|
|
}
|
|
else if (document.delete_images.action.checked){
|
|
return {images:"image_id="+document.delete_images.action.value, image_ids:document.delete_images.action.value};
|
|
}
|
|
return (-1);
|
|
}
|
|
$(document).ready(function() {
|
|
$("#delete").click(function(){
|
|
return DeleteConfirm();
|
|
});
|
|
$(".delete_image").on("click", function(){
|
|
return confirmDelete( _("Are you sure you want to delete this image?") );
|
|
});
|
|
});
|
|
</script>
|
|
[% END %]
|
|
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|