252f4674a5
So far the administration module only allowed for 2 permissions:
- circulation conditions (manage_circ_rules)
- everything else (parameters_remaining_permissions)
With this patch almost every section of the administration page
will have its own granular permission.
To test:
- Create different staff users:
1) One with parameters_remaining_permissions
2) One with parameters
3) One with catalogue and no parameters
4) One superlibrarian
- Apply the patch
- Run the database update
- Check the staff users:
1) All subpermissions, but manage_circ_rules
should be checked
2) Nothing should have changed
3) manage_item_serach_fields shoudl be checked
(page had catalogue permission before)
4) Nothing should have changed
- Try different settings of the permissions and
verify that
- Administration page behaves correctly
- Administration menu behaves correctly
! You shoudl only see what you have permission for
https://bugs.koha-community.org/show_bug.cgi?id=14391
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
119 lines
3.8 KiB
Perl
Executable file
119 lines
3.8 KiB
Perl
Executable file
#! /usr/bin/perl
|
|
|
|
# Copyright 2016 ByWater Solutions
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
use CGI qw ( -utf8 );
|
|
use C4::Context;
|
|
use C4::Auth;
|
|
use C4::Output;
|
|
|
|
use Koha::Libraries;
|
|
use Koha::Library::Group;
|
|
use Koha::Library::Groups;
|
|
|
|
my $cgi = new CGI;
|
|
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "admin/library_groups.tt",
|
|
query => $cgi,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { parameters => 'manage_libraries' },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my $action = $cgi->param('action') || q{};
|
|
|
|
if ( $action eq 'add' ) {
|
|
my $parent_id = $cgi->param('parent_id') || undef;
|
|
my $title = $cgi->param('title') || undef;
|
|
my $description = $cgi->param('description') || undef;
|
|
my $branchcode = $cgi->param('branchcode') || undef;
|
|
my $ft_hide_patron_info = $cgi->param('ft_hide_patron_info') || 0;
|
|
my $ft_search_groups_opac = $cgi->param('ft_search_groups_opac') || 0;
|
|
my $ft_search_groups_staff = $cgi->param('ft_search_groups_staff') || 0;
|
|
|
|
if ( !$branchcode && Koha::Library::Groups->search( { title => $title } )->count() ) {
|
|
$template->param( error_duplicate_title => $title );
|
|
}
|
|
else {
|
|
my $group = Koha::Library::Group->new(
|
|
{
|
|
parent_id => $parent_id,
|
|
title => $title,
|
|
description => $description,
|
|
ft_hide_patron_info => $ft_hide_patron_info,
|
|
ft_search_groups_opac => $ft_search_groups_opac,
|
|
ft_search_groups_staff => $ft_search_groups_staff,
|
|
branchcode => $branchcode,
|
|
}
|
|
)->store();
|
|
|
|
$template->param( added => $group );
|
|
}
|
|
}
|
|
elsif ( $action eq 'edit' ) {
|
|
my $id = $cgi->param('id') || undef;
|
|
my $title = $cgi->param('title') || undef;
|
|
my $description = $cgi->param('description') || undef;
|
|
my $ft_hide_patron_info = $cgi->param('ft_hide_patron_info') || 0;
|
|
my $ft_search_groups_opac = $cgi->param('ft_search_groups_opac') || 0;
|
|
my $ft_search_groups_staff = $cgi->param('ft_search_groups_staff') || 0;
|
|
|
|
if ($id) {
|
|
my $group = Koha::Library::Groups->find($id);
|
|
|
|
$group->set(
|
|
{
|
|
title => $title,
|
|
description => $description,
|
|
ft_hide_patron_info => $ft_hide_patron_info,
|
|
ft_search_groups_opac => $ft_search_groups_opac,
|
|
ft_search_groups_staff => $ft_search_groups_staff,
|
|
}
|
|
)->store();
|
|
|
|
$template->param( edited => $group );
|
|
}
|
|
}
|
|
elsif ( $action eq 'delete' ) {
|
|
my $id = $cgi->param('id');
|
|
|
|
my $group = Koha::Library::Groups->find($id);
|
|
|
|
if ($group) {
|
|
$group->delete();
|
|
$template->param(
|
|
deleted => {
|
|
title => $group->title(),
|
|
library => $group->library()
|
|
? $group->library()->branchname
|
|
: undef
|
|
}
|
|
);
|
|
}
|
|
}
|
|
|
|
my $root_groups = Koha::Library::Groups->get_root_groups();
|
|
|
|
$template->param( root_groups => $root_groups, );
|
|
|
|
output_html_with_http_headers $cgi, $cookie, $template->output;
|