Main Koha release repository https://koha-community.org
Find a file
Owen Leonard 98a269669c
Bug 34082: Cut some redundancy in OPAC JavaScript string translations
This patch consolidates some JS code so that we're not defining a string
ine one place and using it once elsewhere. With JS-friendly translations
tools we don't need this workaround.

To test, apply the patch and go to Administration -> Circulation and
fine rules.

- Configure an item type rule with the "OPAC item level holds" setting
  set to "Force."
- Log in to the OPAC and locate a record with that item type and
  multiple items. An example in the sample data:
  /cgi-bin/koha/opac-detail.pl?biblionumber=12
- Place a hold on the item.
  - The holds screen should show a table of items.
  - Open your browser's developer tools.
  - In the Console tab, paste in this code and hit ENTER:

    $(".checkitem").prop("checked", false);

  - All radio buttons in the table of items should be cleared.
- Click the "Confirm hold" button. You should get an alert:
  "Expecting a specific item selection."

- Log in to the OPAC and click the "Search history" tab from the user
  summary page.
- Check one or more checkboxes next to search history items and click
  the "Remove selected searches."
  - You should get an alert: "Are you sure you want to delete selected
    search history entries?"

- Log in to the OPAC, create a new list if necessary, and add some
  titles to the list.
- Test that confirmation messages show correctly:
  - Deleting a single title by clicking the "Remove
    from this list" link.
  - Deleting multiple titles by checking boxes and
    clicking "Remove from list."
  - Deleting a list.

- In Administration -> System preferences, enable TagsEnabled if
  necessary.
- Log in to the OPAC and tag one or more items.
- From the Tag cloud page, check one or more boxes for your tags, and
  click the "Delete selected tags" button at the bottom of the page.
- The confirmation message should display correctly.

- To test the change to opac-account.tt you have to install a payment
  plugin, e.g.
  https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal,
  and attempt to submit a payment which is below the minimum payment
  threshold set in the plugin's configuration.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-04-29 09:35:39 +02:00
acqui Bug 35363: Update transfer order pop-up window with consistent footer markup 2024-04-22 08:57:39 +02:00
admin Bug 35919: Add record sources admin page 2024-04-26 17:06:04 +02:00
api Bug 36565: EDI files API docs fixes (bug 30070 follow-up) 2024-04-29 09:35:36 +02:00
authorities Bug 36552: (QA follow-up) Add a theoretical check on $record 2024-04-12 14:02:44 +02:00
basket
bin
bookings
C4 Bug 34032: (QA follow-up) Tidy code 2024-04-29 09:35:38 +02:00
catalogue Bug 35558: Do not retrieve the local image if none exists 2024-04-26 18:06:07 +02:00
cataloguing Bug 31791: Limit editing locked records 2024-04-26 20:15:37 +02:00
circ Bug 33478: Apply formatting to AR_SLIP 2024-04-26 20:15:46 +02:00
clubs
course_reserves
debian Bug 35919: Add record sources admin page 2024-04-26 17:06:04 +02:00
docs
erm
errors
etc Bug 30897: (QA follow-up) Enable graceful restart by default 2024-04-11 16:53:43 +02:00
ill Bug 36416: Fix cud-check_out 2024-04-26 08:52:49 +02:00
installer Bug 33478: DBRev 23.12.00.032 2024-04-26 20:15:48 +02:00
Koha Bug 34032: (QA follow-up) Tidy code 2024-04-29 09:35:38 +02:00
koha-tmpl Bug 34082: Cut some redundancy in OPAC JavaScript string translations 2024-04-29 09:35:39 +02:00
labels
lib/CGI/Session/Serialize
members Bug 33478: Apply formatting to ACCOUNTS_SUMMARY 2024-04-26 20:15:45 +02:00
misc Bug 35996: Make it clear that --category-code can not be used alone 2024-04-29 09:35:37 +02:00
offline_circ
opac Bug 35558: Do not retrieve the local image if none exists - OPAC 2024-04-26 18:06:08 +02:00
patron_lists
patroncards
plugins Bug 30897: Add option to disable automated restart 2024-04-11 16:53:42 +02:00
pos Bug 33478: Apply formatting to RECEIPT 2024-04-26 20:15:44 +02:00
preservation
recalls Bug 33478: Apply formatting to RECALL_REQUESTER_DET 2024-04-26 20:15:45 +02:00
reports Bug 35746: add multiselect to report dropdowns 2024-04-26 18:06:19 +02:00
reserve Bug 35979: Check pref before inserting holds_queue background jobs 2024-04-26 08:52:54 +02:00
reviews
rotating_collections
serials Bug 31335: Remove unnecessary holds fetch from routing-preview 2024-04-26 18:06:20 +02:00
services
skel
suggestion Bug 34963: Restore the ability to blank fields when editing a suggestion 2024-04-19 18:06:36 +02:00
svc
t Bug 34032: (QA follow-up) Tidy code 2024-04-29 09:35:38 +02:00
tags
tools Bug 33478: Consider TranslateNotices when saving notice styles 2024-04-26 20:15:47 +02:00
virtualshelves
xt Bug 36565: Unit tests 2024-04-29 09:35:34 +02:00
.editorconfig
.eslintrc.json Bug 36400: Centralize {js,ts,vue} formatting config in .prettierrc.js 2024-04-22 08:57:39 +02:00
.gitignore
.htaccess
.mailmap
.perlcriticrc
.perltidyrc
.prettierrc.js Bug 36400: (follow-up) remove option editorconfig from .prettierrc.js 2024-04-22 08:57:40 +02:00
.proverc.dist
.stylelintrc.json
about.pl Bug 32693: About script: Process only the tab being queried 2024-04-22 12:39:24 +02:00
app.psgi
build-resources.PL
changelanguage.pl
cpanfile Bug 35826: optimize on transport cost when building holds queue 2024-04-26 18:06:16 +02:00
cypress.config.ts
fix-perl-path.PL
gulpfile.js
help.pl
INSTALL
Koha.pm Bug 33478: DBRev 23.12.00.032 2024-04-26 20:15:48 +02:00
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL Bug 36400: (RM follow-up) Add .prettierrc to Makefile 2024-04-24 10:13:13 +01:00
MANIFEST.SKIP
package.json Bug 36400: Centralize {js,ts,vue} formatting config in .prettierrc.js 2024-04-22 08:57:39 +02:00
README
README.md
README.robots
rewrite-config.PL
tsconfig.json
webpack.config.js Bug 35919: Add record sources admin page 2024-04-26 17:06:04 +02:00
yarn.lock Bug 36400: Centralize {js,ts,vue} formatting config in .prettierrc.js 2024-04-22 08:57:39 +02:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo