Koha/opac
Jonathan Druart b64e6be1c4 Bug 16157: Move the selected flag from GetAuthorisedValues to the templates
From C4::Koha::GetAuthorisedValues

    # TODO: the "selected" feature should be replaced by a utility function
    # somewhere else, it doesn't belong in here. For starters it makes
    # caching much more complicated. Or just let the UI logic handle it, it's
    # what it's for.

Indeed, it's not a job for a subroutine, the template should take care of that.
Note that a perf gain could be won with this patch \o/

Test plan:
- Edit an itemtype and check the value of the "Search category" dropdown list
- Edit a patron attribute type and check the value of the "Class" dropdown list
- Detail for a catalogue record, the Status column should be correctly
  populated if items are damaged and/or lost
- Item details for a catalogue record, the lost, damaged and withdrawn
  value should be correctly displayed
- Edit a patron, the "street type" should be correctly selected
- Create a patron attribute type linked to an authorised value list.
- Edit a patron, set a value for this attribute, edit it again. The
  correct value should be selected.
- Search for subscriptions. The 'Location' dropdown list should behave
  correctly (select the entry you have choosen before, etc.)
- Edit a subscription, the location dropdown list should select the
  correct value.
- Edit and view a suggestion with a 'reason for suggestion' set (you
  should have at least 1 OPAC_SUG AV defined)

Followed test plan, works as expected
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
2016-04-07 00:16:09 +00:00
..
errors Bug 15288: Error pages: Code duplication removal and better translatability 2016-01-27 05:57:34 +00:00
rss adding file just for creating the rss directory 2007-08-02 08:50:43 +00:00
sco Bug 15635: Koha::Patron::Images - Remove GetPatronImage 2016-03-04 12:54:15 +00:00
svc Bug 10988 - Fix some wording Fix some outdated wording in googleopenidconnect 2016-04-01 19:25:36 +00:00
ilsdi.pl Bug 14257 - Add show_attributes to GetPatronInfo 2016-03-31 20:31:06 +00:00
maintenance.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
oai.pl Bug 14939: Modularize OAI Server existing classes 2015-12-31 15:15:05 +00:00
opac-account-pay-paypal-return.pl Bug 16129: Remove URL::Encode dependency 2016-04-01 18:48:18 +00:00
opac-account-pay.pl Bug 16129: Remove URL::Encode dependency 2016-04-01 18:48:18 +00:00
opac-account.pl Bug 11622 [QA Followup] - Payment message always displays on opac-account.pl 2015-12-31 13:28:02 +00:00
opac-addbybiblionumber.pl Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off 2016-01-27 02:31:42 +00:00
opac-alert-subscribe.pl Bug 14956: C4::Dates from files opac/*.pl 2015-11-06 15:01:28 -03:00
opac-authorities-home.pl Bug 14076: Do not use CGI->param in list context - opac-authorities-home.pl 2016-03-25 21:28:06 +00:00
opac-authoritiesdetail.pl Bug 15550: Fix authority search and detail at the OPAC 2016-01-23 18:34:06 +00:00
opac-basket.pl Bug 5371: Force no caching for private pages at the OPAC 2015-10-02 11:06:17 -03:00
opac-blocked.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
opac-browser.pl Bug 5371: Force no caching for private pages at the OPAC 2015-10-02 11:06:17 -03:00
opac-changelanguage.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-course-details.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-course-reserves.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-detail.pl Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page 2015-11-05 09:58:02 -03:00
opac-discharge.pl Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
opac-downloadcart.pl Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page 2015-11-05 09:58:02 -03:00
opac-downloadshelf.pl Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off 2016-01-27 02:31:42 +00:00
opac-export.pl Bug 13642 - Adding new features for Dublin Core metadata 2016-01-27 06:23:07 +00:00
opac-ics.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-30 11:53:18 +00:00
opac-idref.pl Bug 8992: Interfacing with the Idref webservice 2015-04-28 15:46:26 -03:00
opac-image.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-imageviewer.pl Bug 7976: Remove the borrow permission 2015-06-05 13:43:34 -03:00
opac-ISBDdetail.pl Bug 16169: Change prototype for C4::Biblio::TransformMarcToKoha 2016-04-07 00:04:21 +00:00
opac-main.pl Bug 15613: Fix 2 other occurrences of paramter vs parameter 2016-01-27 05:16:23 +00:00
opac-MARCdetail.pl Bug 16169: Change prototype for C4::Biblio::TransformMarcToKoha 2016-04-07 00:04:21 +00:00
opac-memberentry.pl Bug 15635: Koha::Patron::Images - Remove GetPatronImage 2016-03-04 12:54:15 +00:00
opac-messaging.pl Bug 9021: Save the provider even if the sms number is not modified 2016-02-14 12:40:08 +00:00
opac-modrequest-suspend.pl Bug 7976: Remove the borrow permission 2015-06-05 13:43:34 -03:00
opac-modrequest.pl Bug 7976: Remove the borrow permission 2015-06-05 13:43:34 -03:00
opac-mymessages.pl Bug 5371: Force no caching for private pages at the OPAC 2015-10-02 11:06:17 -03:00
opac-news-rss.pl Bug 7843: (QA followup) Make news selection persistant 2015-04-30 16:33:21 -03:00
opac-overdrive-search.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
opac-passwd.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-30 11:53:18 +00:00
opac-password-recovery.pl Bug 15585 - Move C4::Passwordrecovery to the new namespace Koha::Patron::Password::Reset 2016-03-22 23:08:21 +00:00
opac-patron-image.pl Bug 15635: Koha::Patron::Images - Remove GetPatronImage 2016-03-04 12:54:15 +00:00
opac-privacy.pl Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
opac-ratings-ajax.pl Bug 14553: Silencing warn triggered when clearing item rating on OPAC 2015-11-11 11:08:50 -03:00
opac-ratings.pl Bug 14440: get_template_and_user can not have an empty template_name (opac-ratings.pl) 2015-06-25 14:41:21 -03:00
opac-readingrecord.pl Bug 14100: Fix 3 occurrences more 2015-10-27 12:34:07 -03:00
opac-registration-verify.pl Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
opac-renew.pl Bug 7976: Remove the borrow permission 2015-06-05 13:43:34 -03:00
opac-reserve.pl Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
opac-restrictedpage.pl Bug 13485: Use the Koha template plugin to access syspref values 2015-08-11 15:15:36 -03:00
opac-retrieve-file.pl Bug 14321: Integrate Upload.pm into Koha 2015-09-25 12:02:52 -03:00
opac-review.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-search-history.pl Bug 14956: C4::Dates from files opac/*.pl 2015-11-06 15:01:28 -03:00
opac-search.pl Bug 16157: Move the selected flag from GetAuthorisedValues to the templates 2016-04-07 00:16:09 +00:00
opac-sendbasket.pl Bug 14306: Show URL from MARC21 field 555$u under Title Notes/Descriptions 2016-03-07 17:58:32 +00:00
opac-sendshelf.pl Bug 14306: Remove call to GetMarcNotes from sendshelf 2016-03-07 17:58:33 +00:00
opac-serial-issues.pl Bug 14956: C4::Dates from files opac/*.pl 2015-11-06 15:01:28 -03:00
opac-shareshelf.pl Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off 2016-01-27 02:31:42 +00:00
opac-shelves.pl Bug 16143: Make opac-shelves.pl generate OPAC itype images path 2016-03-24 15:34:38 +00:00
opac-showmarc.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
opac-showreviews.pl Bug 14956: C4::Dates from files opac/*.pl 2015-11-06 15:01:28 -03:00
opac-suggestions.pl Bug 16198: Fix regression in OPAC suggestions 2016-04-06 22:05:49 +00:00
opac-tags.pl Bug 14589: Adjust authorities_merge_ajax and replace some indirect syntax 2015-11-02 12:49:13 -03:00
opac-tags_subject.pl Bug 14412: SQL injection possible 2015-06-22 11:00:10 -03:00
opac-topissues.pl Bug 14100: Fix some missing occurrences 2015-10-27 12:34:07 -03:00
opac-user.pl Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
tracklinks.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
unapi Bug 15162 Add for Unimarc XSL trans for RDF-DC & SRW-DC 2016-01-27 06:00:35 +00:00