Koha/installer
Martin Renvoize 3c4232e746 Bug 22489: Update onboarding tool for bug 18925
When going through the onboarding process, the tool fails on submit of step 5,
due to changes made in the database structure and rule definitions by bug
18925.

This patch fixes this, adding code that creates a circulation rule where an
issuing rule is also created in onboarding.pl. It removes maxissueqty from
being sent with params to make an issuing rule, and adds it instead to the
params to make a circulation rule, to reflect the changes that have been made
in the database.

Test plan:
1) Drop and recreate your database
2) Reload the staff client and follow the installer and onboarding
process
3) Confirm that the process finishes without errors

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Bug 22489: (follow-up) Correctly set success messages

The original patch was duplicating the success message upon successful
circ rule insertion. This corrects that.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Patches squashed for readability

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-03-15 11:33:09 +00:00
..
data/mysql Bug 22368: DBRev 18.12.00.024 2019-03-11 13:03:37 +00:00
externalmodules.pl Bug 20000: Use Modern::Perl in installer scripts 2019-02-04 16:57:14 +00:00
html-template-to-template-toolkit.pl Bug 20000: Use Modern::Perl in installer scripts 2019-02-04 16:57:14 +00:00
install.pl Bug 20000: Use Modern::Perl in installer scripts 2019-02-04 16:57:14 +00:00
onboarding.pl Bug 22489: Update onboarding tool for bug 18925 2019-03-15 11:33:09 +00:00