Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent/Koha.t
Jonathan Druart 091d6c513b Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes 
The C4::Koha::getitemtypeinfo subroutine did the almost same job as
GetItemTypes. On top of that it returned the imageurl value processed by
C4::Koha::getitemtypeimagelocation.
This value is only used from the 2 [opac-]shelves.pl scripts. Then it's
better not retrieve it only when we need it.

Test plan:
Play with the different scripts touched by this patch and focus on item
types. The same description as prior to this patch must be displayed.
Note that sometimes it is not the translated description which is
displayed, but that should be fixed on another bug report. Indeed we do
not expect this patch to change any behaviors.

Signed-off-by: Lari Taskula <lari.taskula@jns.fi>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
2017-07-05 13:42:21 -03:00

297 lines
11 KiB
Perl
Raw Blame History

#!/usr/bin/perl
#
# This is to test C4/Koha
# It requires a working Koha database with the sample data
use Modern::Perl;
use DateTime::Format::MySQL;
use Test::More tests => 6;
use t::lib::TestBuilder;
use C4::Context;
use Koha::Database;
use Koha::DateUtils qw(dt_from_string);
use Koha::AuthorisedValue;
use Koha::AuthorisedValueCategories;
BEGIN {
use_ok('C4::Koha', qw( :DEFAULT GetDailyQuote GetItemTypesCategorized));
use_ok('C4::Members');
}
my $schema = Koha::Database->new->schema;
$schema->storage->txn_begin;
my $builder = t::lib::TestBuilder->new;
my $dbh = C4::Context->dbh;
our $itype_1 = $builder->build({ source => 'Itemtype' });
subtest 'Authorized Values Tests' => sub {
plan tests => 3;
my $data = {
category => 'CATEGORY',
authorised_value => 'AUTHORISED_VALUE',
lib => 'LIB',
lib_opac => 'LIBOPAC',
imageurl => 'IMAGEURL'
};
my $avc = Koha::AuthorisedValueCategories->find($data->{category});
Koha::AuthorisedValueCategory->new({ category_name => $data->{category} })->store unless $avc;
# Insert an entry into authorised_value table
my $insert_success = Koha::AuthorisedValue->new(
{ category => $data->{category},
authorised_value => $data->{authorised_value},
lib => $data->{lib},
lib_opac => $data->{lib_opac},
imageurl => $data->{imageurl}
}
)->store;
ok( $insert_success, "Insert data in database" );
# Clean up
if($insert_success){
my $query = "DELETE FROM authorised_values WHERE category=? AND authorised_value=? AND lib=? AND lib_opac=? AND imageurl=?;";
my $sth = $dbh->prepare($query);
$sth->execute($data->{category}, $data->{authorised_value}, $data->{lib}, $data->{lib_opac}, $data->{imageurl});
}
SKIP: {
eval { require Test::Deep; import Test::Deep; };
skip "Test::Deep required to run the GetAuthorisedValues() tests.", 2 if $@;
Koha::AuthorisedValueCategory->new({ category_name => 'BUG10656' })->store;
Koha::AuthorisedValue->new(
{ category => 'BUG10656',
authorised_value => 'ZZZ',
lib => 'Z_STAFF',
lib_opac => 'A_PUBLIC',
imageurl => ''
}
)->store;
Koha::AuthorisedValue->new(
{ category => 'BUG10656',
authorised_value => 'AAA',
lib => 'A_STAFF',
lib_opac => 'Z_PUBLIC',
imageurl => ''
}
)->store;
# the next one sets lib_opac to NULL; in that case, the staff
# display value is meant to be used.
Koha::AuthorisedValue->new(
{ category => 'BUG10656',
authorised_value => 'DDD',
lib => 'D_STAFF',
lib_opac => undef,
imageurl => ''
}
)->store;
my $authvals = GetAuthorisedValues('BUG10656');
cmp_deeply(
$authvals,
[
{
id => ignore(),
category => 'BUG10656',
authorised_value => 'AAA',
lib => 'A_STAFF',
lib_opac => 'Z_PUBLIC',
imageurl => '',
},
{
id => ignore(),
category => 'BUG10656',
authorised_value => 'DDD',
lib => 'D_STAFF',
lib_opac => undef,
imageurl => '',
},
{
id => ignore(),
category => 'BUG10656',
authorised_value => 'ZZZ',
lib => 'Z_STAFF',
lib_opac => 'A_PUBLIC',
imageurl => '',
},
],
'list of authorised values in staff mode sorted by staff label (bug 10656)'
);
$authvals = GetAuthorisedValues('BUG10656', 1);
cmp_deeply(
$authvals,
[
{
id => ignore(),
category => 'BUG10656',
authorised_value => 'ZZZ',
lib => 'A_PUBLIC',
lib_opac => 'A_PUBLIC',
imageurl => '',
},
{
id => ignore(),
category => 'BUG10656',
authorised_value => 'DDD',
lib => 'D_STAFF',
lib_opac => undef,
imageurl => '',
},
{
id => ignore(),
category => 'BUG10656',
authorised_value => 'AAA',
lib => 'Z_PUBLIC',
lib_opac => 'Z_PUBLIC',
imageurl => '',
},
],
'list of authorised values in OPAC mode sorted by OPAC label (bug 10656)'
);
}
};
### test for C4::Koha->GetDailyQuote()
SKIP:
{
eval { require Test::Deep; import Test::Deep; };
skip "Test::Deep required to run the GetDailyQuote tests.", 1 if $@;
subtest 'Daily Quotes Test' => sub {
plan tests => 4;
SKIP: {
skip "C4::Koha can't \'GetDailyQuote\'!", 3 unless can_ok('C4::Koha','GetDailyQuote');
# Fill the quote table with the default needed and a spare
$dbh->do("DELETE FROM quotes WHERE id=3 OR id=25;");
my $sql = "INSERT INTO quotes (id,source,text,timestamp) VALUES
(25,'Richard Nixon','When the President does it, that means that it is not illegal.','0000-00-00 00:00:00'),
(3,'Abraham Lincoln','Four score and seven years ago our fathers brought forth on this continent, a new nation, conceived in Liberty, and dedicated to the proposition that all men are created equal.','0000-00-00 00:00:00');";
$dbh->do($sql);
my $expected_quote = {
id => 3,
source => 'Abraham Lincoln',
text => 'Four score and seven years ago our fathers brought forth on this continent, a new nation, conceived in Liberty, and dedicated to the proposition that all men are created equal.',
timestamp => re('\d{4}-\d{2}-\d{2}\s\d{2}:\d{2}:\d{2}'), #'0000-00-00 00:00:00',
};
# test quote retrieval based on id
my $quote = GetDailyQuote('id'=>3);
cmp_deeply ($quote, $expected_quote, "Got a quote based on id.") or
diag('Be sure to run this test on a clean install of sample data.');
# test quote retrieval based on today's date
my $query = 'UPDATE quotes SET timestamp = ? WHERE id = ?';
my $sth = C4::Context->dbh->prepare($query);
$sth->execute(DateTime::Format::MySQL->format_datetime( dt_from_string() ), $expected_quote->{'id'});
DateTime::Format::MySQL->format_datetime( dt_from_string() ) =~ m/(\d{4}-\d{2}-\d{2})/;
$expected_quote->{'timestamp'} = re("^$1");
# $expected_quote->{'timestamp'} = DateTime::Format::MySQL->format_datetime( dt_from_string() ); # update the timestamp of expected quote data
$quote = GetDailyQuote(); # this is the "default" mode of selection
cmp_deeply ($quote, $expected_quote, "Got a quote based on today's date.") or
diag('Be sure to run this test on a clean install of sample data.');
# test random quote retrieval
$quote = GetDailyQuote('random'=>1);
ok ($quote, "Got a random quote.");
}
};
}
subtest 'ISBN tests' => sub {
plan tests => 6;
my $isbn13 = "9780330356473";
my $isbn13D = "978-0-330-35647-3";
my $isbn10 = "033035647X";
my $isbn10D = "0-330-35647-X";
is( xml_escape(undef), '',
'xml_escape() returns empty string on undef input' );
my $str = q{'"&<>'};
is(
xml_escape($str),
'&apos;&quot;&amp;&lt;&gt;&apos;',
'xml_escape() works as expected'
);
is( $str, q{'"&<>'}, '... and does not change input in place' );
is( C4::Koha::_isbn_cleanup('0-590-35340-3'),
'0590353403', '_isbn_cleanup removes hyphens' );
is( C4::Koha::_isbn_cleanup('0590353403 (pbk.)'),
'0590353403', '_isbn_cleanup removes parenthetical' );
is( C4::Koha::_isbn_cleanup('978-0-321-49694-2'),
'0321496949', '_isbn_cleanup converts ISBN-13 to ISBN-10' );
};
subtest 'GetItemTypesCategorized test' => sub{
plan tests => 7;
my $avc = Koha::AuthorisedValueCategories->find('ITEMTYPECAT');
Koha::AuthorisedValueCategory->new({ category_name => 'ITEMTYPECAT' })->store unless $avc;
my $insertGroup = Koha::AuthorisedValue->new(
{ category => 'ITEMTYPECAT',
authorised_value => 'Quertyware',
}
)->store;
ok($insertGroup, "Create group Qwertyware");
my $query = "INSERT into itemtypes (itemtype, description, searchcategory, hideinopac) values (?,?,?,?)";
my $insertSth = C4::Context->dbh->prepare($query);
$insertSth->execute('BKghjklo1', 'One type of book', '', 0);
$insertSth->execute('BKghjklo2', 'Another type of book', 'Qwertyware', 0);
$insertSth->execute('BKghjklo3', 'Yet another type of book', 'Qwertyware', 0);
# Azertyware should not exist.
my @itemtypes = Koha::ItemTypes->search({ searchcategory => 'Azertyware' });
is( @itemtypes, 0, 'Search item types by searchcategory: Invalid category returns nothing');
@itemtypes = Koha::ItemTypes->search({ searchcategory => 'Qwertyware' });
my @got = map { $_->itemtype } @itemtypes;
my @expected = ( 'BKghjklo2', 'BKghjklo3' );
is_deeply(\@got,\@expected,'Search item types by searchcategory: valid category returns itemtypes');
# add more data since GetItemTypesCategorized's search is more subtle
$insertGroup = Koha::AuthorisedValue->new(
{ category => 'ITEMTYPECAT',
authorised_value => 'Varyheavybook',
}
)->store;
$insertSth->execute('BKghjklo4', 'Another hidden book', 'Veryheavybook', 1);
my $hrCat = GetItemTypesCategorized();
ok(exists $hrCat->{Qwertyware}, 'GetItemTypesCategorized: fully visible category exists');
ok($hrCat->{Veryheavybook} &&
$hrCat->{Veryheavybook}->{hideinopac}==1, 'GetItemTypesCategorized: non-visible category hidden' );
$insertSth->execute('BKghjklo5', 'An hidden book', 'Qwertyware', 1);
$hrCat = GetItemTypesCategorized();
ok(exists $hrCat->{Qwertyware}, 'GetItemTypesCategorized: partially visible category exists');
my @only = ( 'BKghjklo1', 'BKghjklo2', 'BKghjklo3', 'BKghjklo4', 'BKghjklo5', 'Qwertyware', 'Veryheavybook' );
my @results = ();
foreach my $key (@only) {
push @results, $key if exists $hrCat->{$key};
}
@expected = ( 'BKghjklo1', 'Qwertyware', 'Veryheavybook' );
is_deeply(\@results,\@expected, 'GetItemTypesCategorized: grouped and ungrouped items returned as expected.');
};
$schema->storage->txn_rollback;
View git blame Copy permalink