Jonathan Druart
4353cd1958
The patrons search used by the checkout tab and the autocomplete is not the same as the "search patrons" tab. The main difference is the "contain" vs "start with". So that if you have a patron with a patron with a surname "foo bar" and you search for "foo bar", the autocomplete and the result of a search by the checkout tab will search for "foo%" or "bar%" which won't return the patron you are search for. This patch replaces both autocomplete and checkout tab searches with a "contain" search. The search will be "%foo%" or "%bar%". Note that on big DB, this can cause unexpected results. Test plan: Create a patron with a surname "foo bar" Search for "bar" using the checkout tab. You should see the patron in the autocomplete result and the result page after submitting the search form. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
93 lines
2.6 KiB
Perl
Executable file
93 lines
2.6 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This software is placed under the gnu General Public License, v2 (http://www.gnu.org/licenses/gpl.html)
|
|
|
|
# Copyright 2007 Tamil s.a.r.l.
|
|
# Parts copyright 2010-2012 Athens County Public Libraries
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
=head1 ysearch.pl
|
|
|
|
=cut
|
|
|
|
use Modern::Perl;
|
|
use CGI qw ( -utf8 );
|
|
use C4::Context;
|
|
use C4::Auth qw/check_cookie_auth/;
|
|
use Koha::Borrowers;
|
|
|
|
use JSON qw( to_json );
|
|
|
|
my $input = new CGI;
|
|
my $query = $input->param('term');
|
|
|
|
binmode STDOUT, ":encoding(UTF-8)";
|
|
print $input->header( -type => 'text/plain', -charset => 'UTF-8' );
|
|
|
|
my ( $auth_status, $sessionID ) = check_cookie_auth( $input->cookie('CGISESSID'), { circulate => '*' } );
|
|
if ( $auth_status ne "ok" ) {
|
|
exit 0;
|
|
}
|
|
|
|
my $limit_on_branch;
|
|
if ( C4::Context->preference("IndependentBranches")
|
|
&& C4::Context->userenv
|
|
&& !C4::Context->IsSuperLibrarian()
|
|
&& C4::Context->userenv->{'branch'} ) {
|
|
$limit_on_branch = 1;
|
|
}
|
|
|
|
my @parts = split( / /, $query );
|
|
my @params;
|
|
foreach my $p (@parts) {
|
|
push(
|
|
@params,
|
|
-or => [
|
|
surname => { -like => "%$p%" },
|
|
firstname => { -like => "%$p%" },
|
|
cardnumber => { -like => "$p%" },
|
|
]
|
|
);
|
|
}
|
|
|
|
push( @params, { branchcode => C4::Context->userenv->{branch} } ) if $limit_on_branch;
|
|
|
|
my $borrowers_rs = Koha::Borrowers->search(
|
|
{ -and => \@params },
|
|
{
|
|
# Get the first 10 results
|
|
page => 1,
|
|
rows => 10,
|
|
order_by => [ 'surname', 'firstname' ],
|
|
},
|
|
);
|
|
|
|
my @borrowers;
|
|
while ( my $b = $borrowers_rs->next ) {
|
|
push @borrowers,
|
|
{ borrowernumber => $b->borrowernumber,
|
|
surname => $b->surname // '',
|
|
firstname => $b->firstname // '',
|
|
cardnumber => $b->cardnumber // '',
|
|
address => $b->address // '',
|
|
city => $b->city // '',
|
|
zipcode => $b->zipcode // '',
|
|
country => $b->country // '',
|
|
};
|
|
}
|
|
|
|
print to_json( \@borrowers );
|