Marcel de Rooy
eb8666357c
Moving timeout logic to one routine (with unit test).
This further implements two suggestions from Kyle and Larry:
[1] You could use a client_timeout of 0 to specify no timeout at all.
[2] Have the client_timeout default to the timeout if not defined.
Test plan:
[1] Run t/db_dependent/SIP/SIPServer.t.
[2] Test login timeout for raw and telnet.
[3] Check ACS status message for timeout value. Should match policy
timeout from institution.
[4] Test client timeout (zero and non-zero).
[5] Remove client timeout. Test fallback to service.
[6] Remove service timeout too. Test fallback to 30 at login.
Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Amended to incorporate Srdjan's suggestion to move get_timeout to
SIPServer.pm; this requires some additional mocking in the unit test.
And even makes the test db dependent, as documented.
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
78 lines
2.9 KiB
Perl
Executable file
78 lines
2.9 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This test is db dependent: SIPServer needs MsgType which needs Auth.
|
|
# And Auth needs config vars and prefences in its BEGIN block.
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use Test::More tests => 1;
|
|
use Test::Warn;
|
|
|
|
my ( $mockConfig, $mockPrefork );
|
|
|
|
BEGIN {
|
|
# In order to test SIPServer::get_timeout, we need to mock
|
|
# Configuration->new and PreFork->run.
|
|
use Test::MockModule;
|
|
use C4::SIP::Sip::Configuration;
|
|
$mockConfig = Test::MockModule->new( 'C4::SIP::Sip::Configuration' );
|
|
$mockConfig->mock( 'new', sub { return {}; } );
|
|
use Net::Server::PreFork;
|
|
$mockPrefork = Test::MockModule->new( 'Net::Server::PreFork' );
|
|
$mockPrefork->mock( 'run', sub {} );
|
|
}
|
|
|
|
use C4::SIP::SIPServer;
|
|
|
|
# Start testing !
|
|
# TODO We should include more tests here.
|
|
|
|
subtest 'Get_timeout' => sub {
|
|
plan tests => 11;
|
|
|
|
my $server = { policy => { timeout => 1 },
|
|
config => { timeout => 2 },
|
|
service => {
|
|
timeout => 3,
|
|
client_timeout => 4,
|
|
},
|
|
};
|
|
|
|
is( C4::SIP::SIPServer::get_timeout(), 30, "Default fallback" );
|
|
is( C4::SIP::SIPServer::get_timeout( undef, { fallback => 25 } ), 25, "Fallback parameter" );
|
|
is( C4::SIP::SIPServer::get_timeout( $server, { transport => 1 } ), 3, "Transport value" );
|
|
is( C4::SIP::SIPServer::get_timeout( $server, { client => 1 } ), 4, "Client value" );
|
|
is( C4::SIP::SIPServer::get_timeout( $server, { policy => 1 } ), '001', "Policy value" );
|
|
|
|
delete $server->{policy}->{timeout};
|
|
is( C4::SIP::SIPServer::get_timeout( $server, { policy => 1 } ), '000', "No policy" );
|
|
|
|
$server->{service}->{client_timeout} = '0';
|
|
is( C4::SIP::SIPServer::get_timeout( $server, { client => 1 } ), 0, "Client zero" );
|
|
$server->{service}->{client_timeout} = 'no';
|
|
is( C4::SIP::SIPServer::get_timeout( $server, { client => 1 } ), 0, "Client no" );
|
|
delete $server->{service}->{client_timeout};
|
|
is( C4::SIP::SIPServer::get_timeout( $server, { client => 1 } ), 3, "Fallback to service" );
|
|
|
|
delete $server->{service}->{timeout};
|
|
is( C4::SIP::SIPServer::get_timeout( $server, { transport => 1 } ), 2, "Back to old config" );
|
|
delete $server->{config}->{timeout};
|
|
is( C4::SIP::SIPServer::get_timeout( $server, { transport => 1 } ), 30, "Fallback again" );
|
|
};
|
|
|
|
1;
|