Kyle M Hall 662da18be2 Bug 34279: Don't enforce overduefinescap unless it is greater than 0 ... When creating a circ rule, we can set overduefinescap to blank or 0 and no cap is enforced. If we edit that rule, the blank/0 is converted to "0.00" which perl considers true, thus zero-ing out any calculated fine. Considering we've always ignored an overdue fines cap of 0, we should also ignore 0.00. However, perl is evaluating it as a string which makes it true instead of false as 0 is. Test Plan: 1) Apply the first patch ( unit tests ) 2) prove t/db_dependent/Circulation/CalcFine.t 3) Note the test fails 4) Apply the second patch as well 5) prove t/db_dependent/Circulation/CalcFine.t 6) Note the test passes Test Plan 2: 1) Create an all/all/all rule with an overduefinescap of 0.00, with a daily fine. Enable CalculateFinesOnReturn 2) Backdate a checkout so it is overdue 3) Return this item, note the lack of a fine 4) Apply this patch set 5) Backdate a checkout and return it again 6) Note the fine is generated! Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (cherry picked from commit 1763b136d1) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>		2023-08-07 20:05:46 -10:00
..
AuthoritiesMarc
Barcodes	Bug 30718: Use flatpickr's altInput	2022-08-19 08:26:31 -03:00
ClassSortRoutine
ClassSplitRoutine
Creators	Bug 32222: Fix capitalization in various "id is invalid"	2023-02-07 10:29:35 -03:00
External
Form
Heading	Bug 33277: Add comments and missing thesauri	2023-05-10 15:26:23 -03:00
ILSDI	Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines	2023-05-12 12:40:21 -03:00
Installer	Bug 30731: Remove Readonly::XS::MAGIC_COOKIE	2022-06-01 16:15:26 -03:00
Labels	Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record	2022-07-22 15:24:11 -03:00
Linker	Bug 30280: Add support for subject headings from different thesaurus when using Elasticsearch	2022-10-03 10:00:04 -03:00
Members
OAI	Bug 30308: Fix bulkmarcimport.pl broken by OAI-PMH:AutoUpdateSets(EmbedItemData)	2022-07-29 15:43:39 -03:00
Output
Patroncards	Bug 31259: Escape infinite loop when lime cannot wrap enough	2023-03-31 13:13:39 +02:00
Reports	Bug 30718: Use flatpickr's altInput	2022-08-19 08:26:31 -03:00
Search	Bug 30718: Use flatpickr's altInput	2022-08-19 08:26:31 -03:00
Serials
SIP	Bug 34101: Limit items types that can be checked out via SIP2	2023-07-17 16:35:05 +01:00
Utils
Accounts.pm	Bug 29184: Fix warn about undefined replacecost	2022-09-08 10:50:30 -07:00
Acquisition.pm	Bug 11844: Use additional fields for order lines	2023-05-16 12:58:38 +02:00
Auth.pm	Bug 33881: Clear self-check JWT during auth kick out	2023-07-28 09:12:39 -10:00
Auth_cas_servers.yaml.sample
Auth_with_cas.pm	Bug 27342: Remove dbh from C4::Auth	2022-08-16 10:45:41 -03:00
Auth_with_ldap.pm	Bug 30646: (follow-up) Set to send immediately	2022-10-03 14:02:40 -03:00
Auth_with_shibboleth.pm	Bug 31651: Replaced duplicate error message	2023-07-17 13:43:17 +01:00
AuthoritiesMarc.pm	Bug 30358: Strip leading/trailing whitespace characters from input fields when cataloguing	2023-05-16 15:17:26 -03:00
BackgroundJob.pm
Barcodes.pm
Biblio.pm	Bug 34182: Don't set biblio.serial based on biblio.seriestitle in AddBiblio	2023-07-18 12:43:58 +01:00
Breeding.pm	Bug 33404: Fix serverhost and init $page	2023-07-17 16:33:29 +01:00
Budgets.pm	Bug 27550: "Duplicate budget" does not keep users associated with that budget	2022-09-22 08:18:33 -03:00
Calendar.pm
Charset.pm
Circulation.pm	Bug 34178: Cache ItemsAnyAvailableAndNotRestricted in memory and don't precalculate	2023-07-25 10:20:51 -10:00
ClassSortRoutine.pm	Bug 29951: Fix EXPORT for C4::ClassS*Routine modules	2022-07-08 15:29:56 -03:00
ClassSource.pm	Bug 29951: Fix EXPORT for C4::ClassS*Routine modules	2022-07-08 15:29:56 -03:00
ClassSplitRoutine.pm	Bug 29951: Fix EXPORT for C4::ClassS*Routine modules	2022-07-08 15:29:56 -03:00
Context.pm	Bug 32478: (QA follow-up) Keep current hashref behavior	2023-06-09 16:05:07 -03:00
Contract.pm
CourseReserves.pm	Bug 30016: Remove GetOpenIssue subroutine	2022-08-31 08:50:37 -03:00
Creators.pm
Heading.pm	Bug 33557: Add LinkerConsiderThesaurus system preference	2023-05-10 15:26:26 -03:00
HoldsQueue.pm	Bug 33761: Alter query to remove items with active transfers from available list	2023-05-18 10:54:28 -03:00
HTML5Media.pm
ImportBatch.pm	Bug 33972: Remove settings of batch status to importing	2023-07-17 15:46:45 +01:00
ImportExportFramework.pm
InstallAuth.pm
Installer.pm	Bug 34174: (bug 33341 follow-up) Fix Ris export	2023-07-17 16:43:20 +01:00
ItemCirculationAlertPreference.pm
Items.pm	Bug 33739: Only trigger indexing on last item modification at ModItemTransfer	2023-05-16 11:26:06 +02:00
Koha.pm	Bug 33341: Address some perlcritic errors in 5.36	2023-03-28 14:50:33 +02:00
Labels.pm
Languages.pm	Bug 32775: (QA follow-up) Fix tab and indenting issues	2023-05-15 18:23:54 -03:00
Letters.pm	Bug 33360: (follow-up) Adjust wording in verbose mode	2023-04-14 11:35:34 -03:00
Linker.pm
Log.pm	Bug 32057: (QA follow-up) Remove pretty flag	2023-03-14 08:49:34 -03:00
MarcModificationTemplates.pm
Matcher.pm	Bug 26611: Make authority record matching use required match checks	2023-05-24 11:21:31 -03:00
Members.pm	Bug 33937: Remove incorrect export in C4::Members	2023-07-12 08:07:53 +01:00
Message.pm	Bug 18398: (follow-up) Update POD & Unit tests	2023-03-31 13:13:35 +02:00
Output.pm	Bug 30524: Core CSRF checking code	2023-07-28 09:12:39 -10:00
Overdues.pm	Bug 34279: Don't enforce overduefinescap unless it is greater than 0	2023-08-07 20:05:46 -10:00
Patroncards.pm
Record.pm	Bug 29697: Fix t/db_dependent/Exporter/Record.t	2022-07-25 09:30:35 -03:00
Reports.pm
Reserves.pm	Bug 34178: (QA follow-up) Tidy	2023-07-25 10:20:52 -10:00
Ris.pm	Bug 34174: (bug 33341 follow-up) Fix Ris export	2023-07-17 16:43:20 +01:00
RotatingCollections.pm	Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines	2023-05-12 12:40:21 -03:00
Scheduler.pm
Scrubber.pm
Search.pm	Bug 33725: (follow-up) Add ccode to grouping logic	2023-06-09 16:05:10 -03:00
Serials.pm	Bug 23775: Claiming a serial issue doesn't create the next one	2023-07-17 15:55:19 +01:00
Service.pm
ShelfBrowser.pm	Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record	2022-07-22 15:24:11 -03:00
SMS.pm
SocialData.pm
Stats.pm	Bug 30928: Add interface to statistics	2023-05-10 14:19:22 -03:00
Suggestions.pm	Bug 33236: (follow-up) Remove export of NewSuggestion	2023-06-09 12:04:47 -03:00
Tags.pm	Bug 31517: (QA follow-up) Fix indentation	2022-11-04 19:30:56 -03:00
Templates.pm	Bug 31390: Remove noisy warns in C4::Templates	2022-08-22 13:25:00 -03:00
TmplToken.pm
TmplTokenType.pm
TTParser.pm
UsageStats.pm	Bug 33961: Remove built-in offline circ tool	2023-07-17 08:18:59 +01:00
XISBN.pm	Bug 30813: (QA follow-up) Adjust three use statements	2022-06-08 11:40:32 -03:00
XSLT.pm	Bug 33567: Remove hardcoded fallback in module	2023-05-12 11:22:42 -03:00