Jonathan Druart
9c9dddeaa4
Most of the time the tests are failing because the item is not created
correctly (missing biblio and/or biblioitem).
The usual error is:
t/db_dependent/selenium/regressions.t ..... 5/5 Can't call method "leader" on an undefined value at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch.pm line 534.
In this patch we are making sure $builder->build({ source => 'Item' })
is replace with $builder->build_sample_item
Test plan:
Turn on Elastic and confirm that all the tests pass!
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
77 lines
2.2 KiB
Perl
77 lines
2.2 KiB
Perl
#!/usr/bin/perl
|
|
|
|
use Modern::Perl;
|
|
use C4::Context;
|
|
use C4::Circulation;
|
|
use C4::Members;
|
|
use C4::Items;
|
|
use Koha::DateUtils;
|
|
use Koha::Libraries;
|
|
use Koha::Patrons;
|
|
use t::lib::TestBuilder;
|
|
use t::lib::Mocks qw(mock_preference);
|
|
|
|
use Test::More tests => 8;
|
|
|
|
my $schema = Koha::Database->new->schema;
|
|
$schema->storage->txn_begin;
|
|
|
|
my $builder = t::lib::TestBuilder->new;
|
|
$builder->build({ source => 'Branch', value => { branchcode => 'CPL' } })
|
|
unless Koha::Libraries->find('CPL');
|
|
|
|
t::lib::Mocks::mock_userenv({ branchcode => 'CPL' });
|
|
|
|
t::lib::Mocks::mock_preference('BlockReturnOfWithdrawnItems',0);
|
|
my $test_patron = '23529001223651';
|
|
my $test_item_fic = '502326000402';
|
|
my $test_item_24 = '502326000404';
|
|
my $test_item_48 = '502326000403';
|
|
|
|
my $borrower1 = $builder->build_object({ class => 'Koha::Patrons', value => { cardnumber => $test_patron } });
|
|
my $item1 = $builder->build_sample_item(
|
|
{
|
|
barcode => $test_item_fic,
|
|
}
|
|
);
|
|
my $item2 = $builder->build_sample_item(
|
|
{
|
|
barcode => $test_item_24,
|
|
}
|
|
);
|
|
my $item3 = $builder->build_sample_item(
|
|
{
|
|
barcode => $test_item_48,
|
|
}
|
|
);
|
|
|
|
SKIP: {
|
|
skip 'Missing test borrower or item, skipping tests', 8
|
|
unless ( defined $borrower1 && defined $item1 );
|
|
|
|
for my $item_barcode ( $test_item_fic, $test_item_24, $test_item_48 ) {
|
|
my $duedate = try_issue( $test_patron, $item_barcode );
|
|
isa_ok( $duedate, 'DateTime' );
|
|
if ( $item_barcode eq $test_item_fic ) {
|
|
is( $duedate->hour(), 23, "daily loan hours = 23" );
|
|
is( $duedate->minute(), 59, "daily loan mins = 59" );
|
|
}
|
|
my $ret_ok = try_return($item_barcode);
|
|
is( $ret_ok, 1, 'Return succeeded' );
|
|
}
|
|
}
|
|
|
|
sub try_issue {
|
|
my ($cardnumber, $item ) = @_;
|
|
my $issuedate = '2011-05-16';
|
|
my $patron = Koha::Patrons->find( { cardnumber => $cardnumber } );
|
|
my ($issuingimpossible,$needsconfirmation) = CanBookBeIssued( $patron, $item );
|
|
my $issue = AddIssue($patron->unblessed, $item, undef, 0, $issuedate);
|
|
return dt_from_string( $issue->date_due );
|
|
}
|
|
|
|
sub try_return {
|
|
my $barcode = shift;
|
|
my ($ret, $messages, $iteminformation, $borrower) = AddReturn($barcode);
|
|
return $ret;
|
|
}
|