bef18fad1e
When having more than 20 (or numSearchResults) reviews waiting to be approved in <site>/cgi-bin/koha/reviews/reviewswaiting.pl?status=1, the paging at the bottom only offset by 1 entry, instead of moving a full page (20 entries) ahead. The simple fix uses 'page' instead of 'offset'. TEST: 1) Modify numSearchResult preference to a low (5?) value. 2) create X comments, where X is greater than the value above. 3) approve them all (although this step is probably unnecessary) 4) Go to tools >> comments (approved comments tab) 5) You see X entries. Click on page 2 at bottom. Link should show "offset=2") 6) You get same results, except the first one which "slided out". Apply patch, redo step 4-5. With patch, paging works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
79 lines
2.4 KiB
Perl
Executable file
79 lines
2.4 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use strict;
|
|
use warnings;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use C4::Auth;
|
|
use C4::Output;
|
|
use C4::Context;
|
|
use C4::Review;
|
|
use C4::Members;
|
|
use C4::Biblio;
|
|
|
|
my $query = new CGI;
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "reviews/reviewswaiting.tt",
|
|
query => $query,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { tools => 'moderate_comments' },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my $op = $query->param('op') || '';
|
|
my $status = $query->param('status') || 0;
|
|
my $reviewid = $query->param('reviewid');
|
|
my $page = $query->param('page') || 1;
|
|
my $count = C4::Context->preference('numSearchResults') || 20;
|
|
my $offset = ($page-1) * $count;
|
|
my $total = numberofreviews($status);
|
|
|
|
if ( $op eq 'approve' ) {
|
|
approvereview($reviewid);
|
|
}
|
|
elsif ( $op eq 'unapprove' ) {
|
|
unapprovereview($reviewid);
|
|
}
|
|
elsif ( $op eq 'delete' ) {
|
|
deletereview($reviewid);
|
|
}
|
|
|
|
my $reviews = getallreviews($status,$offset,$count);
|
|
|
|
foreach ( @$reviews ) {
|
|
my $borrowernumber = $_->{borrowernumber};
|
|
my $borrowerData = GetMember('borrowernumber' => $borrowernumber);
|
|
my $biblioData = GetBiblioData($_->{biblionumber});
|
|
# setting some borrower info into this hash
|
|
$_->{bibliotitle} = $biblioData->{'title'};
|
|
$_->{surname} = $borrowerData->{'surname'};
|
|
$_->{firstname} = $borrowerData->{'firstname'};
|
|
}
|
|
|
|
my $url = "/cgi-bin/koha/reviews/reviewswaiting.pl?status=$status";
|
|
|
|
$template->param(
|
|
status => $status,
|
|
reviews => $reviews,
|
|
pagination_bar => pagination_bar( $url, ( int( $total / $count ) ) + ( ( $total % $count ) > 0 ? 1 : 0 ), $page, "page" )
|
|
);
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|