Jonathan Druart
9d6d641d1f
On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. This patch is a squashed version of: Bug 17600: After export.pl Bug 17600: After perlimport Bug 17600: Manual changes Bug 17600: Other manual changes after second perlimports run Bug 17600: Fix tests And a lot of other manual changes. export.pl is a dirty script that can be found on bug 17600. "perlimport" is: git clone https://github.com/oalders/App-perlimports.git cd App-perlimports/ cpanm --installdeps . export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib" find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \; The ideas of this patch are to: * use EXPORT_OK instead of EXPORT * perltidy the EXPORT_OK list * remove '&' before the subroutine names * remove some uneeded use statements * explicitely import the subroutines we need within the controllers or modules Note that the private subroutines (starting with _) should not be exported (and not used from outside of the module except from tests). EXPORT vs EXPORT_OK (from https://www.thegeekstuff.com/2010/06/perl-exporter-examples/) """ Export allows to export the functions and variables of modules to user’s namespace using the standard import method. This way, we don’t need to create the objects for the modules to access it’s members. @EXPORT and @EXPORT_OK are the two main variables used during export operation. @EXPORT contains list of symbols (subroutines and variables) of the module to be exported into the caller namespace. @EXPORT_OK does export of symbols on demand basis. """ If this patch caused a conflict with a patch you wrote prior to its push: * Make sure you are not reintroducing a "use" statement that has been removed * "$subroutine" is not exported by the C4::$MODULE module means that you need to add the subroutine to the @EXPORT_OK list * Bareword "$subroutine" not allowed while "strict subs" means that you didn't imported the subroutine from the module: - use $MODULE qw( $subroutine list ); You can also use the fully qualified namespace: C4::$MODULE::$subroutine Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
251 lines
10 KiB
Perl
Executable file
251 lines
10 KiB
Perl
Executable file
#!/usr/bin/perl
|
||
|
||
# This file is part of Koha.
|
||
#
|
||
# Koha is free software; you can redistribute it and/or modify it
|
||
# under the terms of the GNU General Public License as published by
|
||
# the Free Software Foundation; either version 3 of the License, or
|
||
# (at your option) any later version.
|
||
#
|
||
# Koha is distributed in the hope that it will be useful, but
|
||
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
# GNU General Public License for more details.
|
||
#
|
||
# You should have received a copy of the GNU General Public License
|
||
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
||
|
||
use Modern::Perl;
|
||
|
||
use Koha::Script;
|
||
use Koha::AuthorisedValues;
|
||
use Koha::Authorities;
|
||
use Koha::Biblios;
|
||
use Koha::BiblioFrameworks;
|
||
use Koha::Biblioitems;
|
||
use Koha::Items;
|
||
use Koha::ItemTypes;
|
||
use C4::Biblio qw( GetMarcFromKohaField );
|
||
|
||
{
|
||
my $items = Koha::Items->search({ -or => { homebranch => undef, holdingbranch => undef }});
|
||
if ( $items->count ) { new_section("Not defined items.homebranch and/or items.holdingbranch")}
|
||
while ( my $item = $items->next ) {
|
||
if ( not $item->homebranch and not $item->holdingbranch ) {
|
||
new_item(sprintf "Item with itemnumber=%s does not have homebranch and holdingbranch defined", $item->itemnumber);
|
||
} elsif ( not $item->homebranch ) {
|
||
new_item(sprintf "Item with itemnumber=%s does not have homebranch defined", $item->itemnumber);
|
||
} else {
|
||
new_item(sprintf "Item with itemnumber=%s does not have holdingbranch defined", $item->itemnumber);
|
||
}
|
||
}
|
||
if ( $items->count ) { new_hint("Edit these items and set valid homebranch and/or holdingbranch")}
|
||
}
|
||
|
||
{
|
||
# No join possible, FK is missing at DB level
|
||
my @auth_types = Koha::Authority::Types->search->get_column('authtypecode');
|
||
my $authorities = Koha::Authorities->search({authtypecode => { 'not in' => \@auth_types } });
|
||
if ( $authorities->count ) {new_section("Invalid auth_header.authtypecode")}
|
||
while ( my $authority = $authorities->next ) {
|
||
new_item(sprintf "Authority with authid=%s does not have a code defined (%s)", $authority->authid, $authority->authtypecode);
|
||
}
|
||
if ( $authorities->count ) {new_hint("Go to 'Home › Administration › Authority types' to define them")}
|
||
}
|
||
|
||
{
|
||
if ( C4::Context->preference('item-level_itypes') ) {
|
||
my $items_without_itype = Koha::Items->search( { -or => [itype => undef,itype => ''] } );
|
||
if ( $items_without_itype->count ) {
|
||
new_section("Items do not have itype defined");
|
||
while ( my $item = $items_without_itype->next ) {
|
||
if (defined $item->biblioitem->itemtype && $item->biblioitem->itemtype ne '' ) {
|
||
new_item(
|
||
sprintf "Item with itemnumber=%s does not have a itype value, biblio's item type will be used (%s)",
|
||
$item->itemnumber, $item->biblioitem->itemtype
|
||
);
|
||
} else {
|
||
new_item(
|
||
sprintf "Item with itemnumber=%s does not have a itype value, additionally no item type defined for biblionumber=%s",
|
||
$item->itemnumber, $item->biblioitem->biblionumber
|
||
);
|
||
}
|
||
}
|
||
new_hint("The system preference item-level_itypes expects item types to be defined at item level");
|
||
}
|
||
}
|
||
else {
|
||
my $biblioitems_without_itemtype = Koha::Biblioitems->search( { itemtype => undef } );
|
||
if ( $biblioitems_without_itemtype->count ) {
|
||
new_section("Biblioitems do not have itemtype defined");
|
||
while ( my $biblioitem = $biblioitems_without_itemtype->next ) {
|
||
new_item(
|
||
sprintf "Biblioitem with biblioitemnumber=%s does not have a itemtype value",
|
||
$biblioitem->biblioitemnumber
|
||
);
|
||
}
|
||
new_hint("The system preference item-level_itypes expects item types to be defined at biblio level");
|
||
}
|
||
}
|
||
|
||
my @itemtypes = Koha::ItemTypes->search->get_column('itemtype');
|
||
if ( C4::Context->preference('item-level_itypes') ) {
|
||
my $items_with_invalid_itype = Koha::Items->search( { -and => [itype => { not_in => \@itemtypes }, itype => { '!=' => '' }] } );
|
||
if ( $items_with_invalid_itype->count ) {
|
||
new_section("Items have invalid itype defined");
|
||
while ( my $item = $items_with_invalid_itype->next ) {
|
||
new_item(
|
||
sprintf "Item with itemnumber=%s, biblionumber=%s does not have a valid itype value (%s)",
|
||
$item->itemnumber, $item->biblionumber, $item->itype
|
||
);
|
||
}
|
||
new_hint("The items must have a itype value that is defined in the item types of Koha (Home › Administration › Item types administration)");
|
||
}
|
||
}
|
||
else {
|
||
my $biblioitems_with_invalid_itemtype = Koha::Biblioitems->search(
|
||
{ itemtype => { not_in => \@itemtypes } }
|
||
);
|
||
if ( $biblioitems_with_invalid_itemtype->count ) {
|
||
new_section("Biblioitems do not have itemtype defined");
|
||
while ( my $biblioitem = $biblioitems_with_invalid_itemtype->next ) {
|
||
new_item(
|
||
sprintf "Biblioitem with biblioitemnumber=%s does not have a valid itemtype value",
|
||
$biblioitem->biblioitemnumber
|
||
);
|
||
}
|
||
new_hint("The biblioitems must have a itemtype value that is defined in the item types of Koha (Home › Administration › Item types administration)");
|
||
}
|
||
}
|
||
|
||
my @decoding_errors;
|
||
my $biblios = Koha::Biblios->search;
|
||
while ( my $biblio = $biblios->next ) {
|
||
eval{$biblio->metadata->record;};
|
||
push @decoding_errors, $@ if $@;
|
||
}
|
||
if ( @decoding_errors ) {
|
||
new_section("Bibliographic records have invalid MARCXML");
|
||
new_item($_) for @decoding_errors;
|
||
new_hint("The bibliographic records must have a valid MARCXML or you will face encoding issues or wrong displays");
|
||
}
|
||
}
|
||
|
||
{
|
||
my $frameworks = Koha::BiblioFrameworks->search;
|
||
my $invalid_av_per_framework = {};
|
||
while ( my $framework = $frameworks->next ) {
|
||
my $msss = Koha::MarcSubfieldStructures->search({ frameworkcode => $framework->frameworkcode, authorised_value => { '!=' => [ -and => ( undef, '' ) ]} });
|
||
while ( my $mss = $msss->next ) {
|
||
my $kohafield = $mss->kohafield;
|
||
my $av = $mss->authorised_value;
|
||
next if grep {$_ eq $av} qw( branches itemtypes cn_source ); # internal categories
|
||
|
||
my $avs = Koha::AuthorisedValues->search_by_koha_field(
|
||
{
|
||
frameworkcode => $framework->frameworkcode,
|
||
kohafield => $kohafield,
|
||
}
|
||
);
|
||
my $tmp_kohafield = $kohafield;
|
||
if ( $tmp_kohafield =~ /^biblioitems/ ) {
|
||
$tmp_kohafield =~ s|biblioitems|biblioitem|;
|
||
} else {
|
||
$tmp_kohafield =~ s|items|me|;
|
||
}
|
||
# replace items.attr with me.attr
|
||
my $items = Koha::Items->search(
|
||
{
|
||
$tmp_kohafield =>
|
||
{
|
||
-not_in => [ $avs->get_column('authorised_value'), '' ],
|
||
'!=' => undef,
|
||
},
|
||
'biblio.frameworkcode' => $framework->frameworkcode
|
||
},
|
||
{ join => [ 'biblioitem', 'biblio' ] }
|
||
);
|
||
if ( $items->count ) {
|
||
$invalid_av_per_framework->{ $framework->frameworkcode }->{$av} =
|
||
{ items => $items, kohafield => $kohafield };
|
||
}
|
||
}
|
||
}
|
||
if (%$invalid_av_per_framework) {
|
||
new_section('Wrong values linked to authorised values');
|
||
for my $frameworkcode ( keys %$invalid_av_per_framework ) {
|
||
my $output;
|
||
while ( my ( $av_category, $v ) = each %{$invalid_av_per_framework->{$frameworkcode}} ) {
|
||
my $items = $v->{items};
|
||
my $kohafield = $v->{kohafield};
|
||
my ( $table, $column ) = split '\.', $kohafield;
|
||
while ( my $i = $items->next ) {
|
||
my $value = $table eq 'items' ? $i->$column : $i->biblioitem->$column;
|
||
$output .= " {" . $i->itemnumber . " => " . $value . "}";
|
||
}
|
||
new_item(
|
||
sprintf(
|
||
"The Framework *%s* is using the authorised value's category *%s*, "
|
||
. "but the following %s do not have a value defined ({itemnumber => value }):\n%s",
|
||
$frameworkcode, $av_category, $kohafield, $output
|
||
)
|
||
);
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
{
|
||
my $biblios = Koha::Biblios->search({
|
||
-or => [
|
||
title => '',
|
||
title => undef,
|
||
]
|
||
});
|
||
if ( $biblios->count ) {
|
||
my ( $title_tag, $title_subtag ) = C4::Biblio::GetMarcFromKohaField( 'biblio.title' );
|
||
my $title_field = $title_tag // '';
|
||
$title_field .= '$'.$title_subtag if $title_subtag;
|
||
new_section("Biblio without title $title_field");
|
||
while ( my $biblio = $biblios->next ) {
|
||
new_item(sprintf "Biblio with biblionumber=%s does not have title defined", $biblio->biblionumber);
|
||
}
|
||
new_hint("Edit these biblio records to defined a title");
|
||
}
|
||
}
|
||
|
||
sub new_section {
|
||
my ( $name ) = @_;
|
||
say "\n== $name ==";
|
||
}
|
||
|
||
sub new_item {
|
||
my ( $name ) = @_;
|
||
say "\t* $name";
|
||
}
|
||
sub new_hint {
|
||
my ( $name ) = @_;
|
||
say "=> $name";
|
||
}
|
||
|
||
=head1 NAME
|
||
|
||
search_for_data_inconsistencies.pl
|
||
|
||
=head1 SYNOPSIS
|
||
|
||
perl search_for_data_inconsistencies.pl
|
||
|
||
=head1 DESCRIPTION
|
||
|
||
Catch data inconsistencies in Koha database
|
||
|
||
* Items with undefined homebranch and/or holdingbranch
|
||
* Authorities with undefined authtypecodes/authority types
|
||
* Item types:
|
||
* if item types are defined at item level (item-level_itypes=specific item),
|
||
then items.itype must be set else biblioitems.itemtype must be set
|
||
* Item types defined in items or biblioitems must be defined in the itemtypes table
|
||
* Invalid MARCXML in bibliographic records
|
||
|
||
=cut
|