Srdjan a0b00e4c8b Bug 11077: Correct more warnings in C4/Auth.pm ... This gets rid of some more warnings. It also corrects a noisy ne condition. $userid = $retuserid if ( $retuserid ne ''); became $userid = $retuserid if ( $retuserid ); It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's patch, while correcting the problems found. This includes: my $q_userid = $query->param('userid') // ''; along with: my $s_userid = ''; and: my $s_userid = $session->param('id') // ''; Indentation does not reflect actual scoping. A missing system preference would have triggered a ubiquitous undef compare check failure message. This makes the flooding message more useful, so as to help correct it. The change to accomplish this was: my $pki_field = C4::Context->preference('AllowPKIAuth'); if (!defined($pki_field)) { print STDERR "Error: Missing AllowPKIAuth System Preference!\n"; $pki_field = 'None'; } Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Galen Charlton <gmc@esilibrary.com>		2013-12-05 15:17:33 +00:00
..
AuthoritiesMarc	Bug 7941 : Fix version numbers in modules	2012-06-11 17:29:38 +02:00
Barcodes
ClassSortRoutine	Bug 9770: fix sorting of Dewey call numbers that contain prefixes	2013-07-15 16:12:47 +00:00
Creators
External	Bug 10320: (follow-up) correct license statement	2013-09-08 07:04:45 +00:00
Form
Heading	Bug 7941 : Fix version numbers in modules	2012-06-11 17:29:38 +02:00
ILSDI
Installer	Bug 8798: (follow-up) remove tabs	2013-10-14 21:08:02 +00:00
Labels
Linker
Members
OAI	Bug 9295: Introduce operator equal/ notequal to OAI set mapping instead of hardcoded 'equal' value.	2013-10-10 23:03:30 +00:00
Output
Patroncards	Bug 8315 - remove use C4::* version	2012-07-13 14:17:20 +02:00
Reports
Search	Bug 5385: POD Cleanups (part 1)	2010-11-12 10:06:55 +13:00
Serials
SIP
Utils
VirtualShelves	Bug 10853: All existing routing to get a CSV should return a MARC csv	2013-10-11 02:16:33 +00:00
Accounts.pm
Acquisition.pm
Auth.pm	Bug 11077: Correct more warnings in C4/Auth.pm	2013-12-05 15:17:33 +00:00
Auth_cas_servers.yaml.orig	Bug 5630 CAS improvements	2011-10-13 10:49:49 +13:00
Auth_with_cas.pm
Auth_with_ldap.pm
AuthoritiesMarc.pm	Bug 10602: Set default value for authority fields via the framework	2013-10-10 23:25:47 +00:00
BackgroundJob.pm
Barcodes.pm	Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Barcodes.pm	2012-09-20 12:01:36 +02:00
Biblio.pm
Bookseller.pm
Boolean.pm
Branch.pm
Breeding.pm	Bug 10096 - (follow-up) various QA improvements	2013-10-04 14:29:18 +00:00
Budgets.pm
Calendar.pm
Category.pm
Charset.pm
Circulation.pm
ClassSortRoutine.pm
ClassSource.pm	Bug 10643: fix inappropriate uses of $sth->finish() in C4::ClassSource.pm	2013-08-09 15:32:22 +00:00
Context.pm	Bug 8798: moving code to Koha::Database and adding tests	2013-10-14 21:08:02 +00:00
Contract.pm
CourseReserves.pm	bug 8215: (followup) rename GetItemReservesInfo	2013-05-21 15:51:03 -07:00
Creators.pm	Bug 8315 - remove use C4::* version	2012-07-13 14:17:20 +02:00
Csv.pm	Bug 10853: All existing routing to get a CSV should return a MARC csv	2013-10-11 02:16:33 +00:00
Dates.pm
Debug.pm	Bug 7941 : Fix version numbers in modules	2012-06-11 17:29:38 +02:00
Heading.pm
HoldsQueue.pm
HTML5Media.pm	Bug 8377: Followup move style in a css file and do not pass template to a pm	2012-12-27 09:28:00 -05:00
Images.pm
ImportBatch.pm	Bug 8015: (follow-up) trap exceptions thrown by SetUTF8Flag()	2013-10-31 22:48:59 +00:00
ImportExportFramework.pm
Input.pm
Installer.pm
ItemCirculationAlertPreference.pm
Items.pm
ItemType.pm	Bug 10513: display a warning/message when returning a chosen item type	2013-09-16 17:45:31 +00:00
Koha.pm	Bug 8015: (follow-up) remove references to C4::Koha::Log	2013-10-31 22:50:29 +00:00
Labels.pm	Bug 8315 - remove use C4::* version	2012-07-13 14:17:20 +02:00
Languages.pm	Bug 10309 - New OPAC theme based on Bootstrap	2013-10-14 23:13:05 +00:00
Letters.pm	Bug 10843: fix crash that can occur when confirming hold if ReservesMaxPickUpDelay is undefined	2013-10-18 06:16:57 +00:00
Linker.pm
Log.pm	Bug 7067 - OPAC Borrower Self Registration	2012-12-14 08:08:59 -05:00
Maintainance.pm
MarcModificationTemplates.pm	Bug 8015: (follow-up) don't require userenv	2013-10-31 22:51:13 +00:00
Matcher.pm
Members.pm
Message.pm	Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Message.pm	2012-09-20 12:01:39 +02:00
NewsChannels.pm
Output.pm	Bug 10016: force zero browser-side caching of SCO pages	2013-10-21 18:05:12 +00:00
Overdues.pm	Bug 2720 - Overdues which debar automatically should undebar automatically when returned	2013-10-31 01:53:22 +00:00
Patroncards.pm	Bug 8315 - remove use C4::* version	2012-07-13 14:17:20 +02:00
Print.pm
Ratings.pm	Bug 7941 : Fix version numbers in modules	2012-06-11 17:29:38 +02:00
Record.pm
Reports.pm
Reserves.pm
Review.pm
Ris.pm
RotatingCollections.pm
Scheduler.pm
Scrubber.pm
Search.pm	Merge branch 'new/bug11269'	2013-11-19 16:27:29 +00:00
Serials.pm	Bug 11168: fix regression that broke exporting serial claims to CSV	2013-10-31 16:10:48 +00:00
Service.pm	POD Cleanups	2010-06-09 08:38:59 -04:00
ShelfBrowser.pm
SMS.pm
SocialData.pm
SQLHelper.pm	Bug 11221: ensure that SQLHelper uses NULL rather than 0000-00-00 as default date value	2013-11-19 15:29:08 +00:00
Stats.pm
Suggestions.pm
Tags.pm
Templates.pm
TmplToken.pm	Bug 7941 : Fix version numbers in modules	2012-06-11 17:29:38 +02:00
TmplTokenType.pm	Revert "Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm"	2012-09-20 13:29:59 +02:00
TTParser.pm	Bug 5327 : Follow up for TTParser test	2012-07-12 16:06:21 +02:00
UploadedFile.pm
VirtualShelves.pm	Bug 10386: improvements to VirtualShelves.t	2013-06-28 05:19:49 -07:00
XISBN.pm
XSLT.pm