Tomas Cohen Arazi
8fe707769a
To test: - Run: $ prove t/db_dependent/Holds/LocalHoldsPriority.t => FAIL: Tests raise lots of warnings - Apply the patch - Run: $ prove t/db_dependent/Holds/LocalHoldsPriority.t => SUCCESS: Tests pass, and no warnings! - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
127 lines
4.1 KiB
Perl
Executable file
127 lines
4.1 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
use Modern::Perl;
|
|
|
|
use t::lib::Mocks;
|
|
use C4::Context;
|
|
|
|
use Test::More tests => 6;
|
|
use MARC::Record;
|
|
use C4::Biblio;
|
|
use C4::Items;
|
|
use C4::Members;
|
|
use Koha::Database;
|
|
|
|
use t::lib::TestBuilder;
|
|
|
|
BEGIN {
|
|
use FindBin;
|
|
use lib $FindBin::Bin;
|
|
use_ok('C4::Reserves');
|
|
}
|
|
|
|
my $schema = Koha::Database->schema;
|
|
$schema->storage->txn_begin;
|
|
|
|
my $builder = t::lib::TestBuilder->new;
|
|
|
|
my $library1 = $builder->build({ source => 'Branch', });
|
|
my $library2 = $builder->build({ source => 'Branch', });
|
|
my $library3 = $builder->build({ source => 'Branch', });
|
|
my $library4 = $builder->build({ source => 'Branch', });
|
|
my $itemtype = $builder->build(
|
|
{ source => 'Itemtype',
|
|
value => { notforloan => undef, rentalcharge => 0 }
|
|
}
|
|
)->{itemtype};
|
|
|
|
|
|
|
|
my $borrowers_count = 5;
|
|
|
|
# Create a helper biblio
|
|
my ( $bibnum, $title, $bibitemnum ) = create_helper_biblio();
|
|
# Create a helper item for the biblio.
|
|
my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
|
|
{ homebranch => $library4->{branchcode},
|
|
holdingbranch => $library3->{branchcode},
|
|
itype => $itemtype
|
|
},
|
|
$bibnum
|
|
);
|
|
|
|
|
|
my @branchcodes = ( $library1->{branchcode}, $library2->{branchcode}, $library3->{branchcode}, $library4->{branchcode}, $library3->{branchcode}, $library4->{branchcode} );
|
|
|
|
# Create some borrowers
|
|
my @borrowernumbers;
|
|
foreach ( 1 .. $borrowers_count ) {
|
|
my $borrowernumber = AddMember(
|
|
firstname => 'my firstname',
|
|
surname => 'my surname ' . $_,
|
|
categorycode => 'S',
|
|
branchcode => $branchcodes[$_],
|
|
);
|
|
push @borrowernumbers, $borrowernumber;
|
|
}
|
|
|
|
my $biblionumber = $bibnum;
|
|
|
|
# Create five item level holds
|
|
my $i = 1;
|
|
foreach my $borrowernumber (@borrowernumbers) {
|
|
AddReserve(
|
|
$branchcodes[$i],
|
|
$borrowernumber,
|
|
$biblionumber,
|
|
my $bibitems = q{},
|
|
my $priority = $i,
|
|
my $resdate,
|
|
my $expdate,
|
|
my $notes = q{},
|
|
$title,
|
|
my $checkitem,
|
|
my $found,
|
|
);
|
|
|
|
$i++;
|
|
}
|
|
|
|
my ($status, $reserve, $all_reserves);
|
|
|
|
t::lib::Mocks::mock_preference( 'LocalHoldsPriority', 0 );
|
|
($status, $reserve, $all_reserves) = CheckReserves($itemnumber);
|
|
ok( $reserve->{borrowernumber} eq $borrowernumbers[0], "Received expected results with LocalHoldsPriority disabled" );
|
|
|
|
t::lib::Mocks::mock_preference( 'LocalHoldsPriority', 1 );
|
|
|
|
t::lib::Mocks::mock_preference( 'LocalHoldsPriorityPatronControl', 'PickupLibrary' );
|
|
t::lib::Mocks::mock_preference( 'LocalHoldsPriorityItemControl', 'homebranch' );
|
|
($status, $reserve, $all_reserves) = CheckReserves($itemnumber);
|
|
ok( $reserve->{borrowernumber} eq $borrowernumbers[2], "Received expected results with PickupLibrary/homebranch" );
|
|
|
|
t::lib::Mocks::mock_preference( 'LocalHoldsPriorityPatronControl', 'PickupLibrary' );
|
|
t::lib::Mocks::mock_preference( 'LocalHoldsPriorityItemControl', 'holdingbranch' );
|
|
($status, $reserve, $all_reserves) = CheckReserves($itemnumber);
|
|
ok( $reserve->{borrowernumber} eq $borrowernumbers[1], "Received expected results with PickupLibrary/holdingbranch" );
|
|
|
|
t::lib::Mocks::mock_preference( 'LocalHoldsPriorityPatronControl', 'HomeLibrary' );
|
|
t::lib::Mocks::mock_preference( 'LocalHoldsPriorityItemControl', 'holdingbranch' );
|
|
($status, $reserve, $all_reserves) = CheckReserves($itemnumber);
|
|
ok( $reserve->{borrowernumber} eq $borrowernumbers[1], "Received expected results with HomeLibrary/holdingbranch" );
|
|
|
|
t::lib::Mocks::mock_preference( 'LocalHoldsPriorityPatronControl', 'HomeLibrary' );
|
|
t::lib::Mocks::mock_preference( 'LocalHoldsPriorityItemControl', 'homebranch' );
|
|
($status, $reserve, $all_reserves) = CheckReserves($itemnumber);
|
|
ok( $reserve->{borrowernumber} eq $borrowernumbers[2], "Received expected results with HomeLibrary/homebranch" );
|
|
|
|
# Helper method to set up a Biblio.
|
|
sub create_helper_biblio {
|
|
my $bib = MARC::Record->new();
|
|
my $title = 'Silence in the library';
|
|
$bib->append_fields(
|
|
MARC::Field->new( '100', ' ', ' ', a => 'Moffat, Steven' ),
|
|
MARC::Field->new( '245', ' ', ' ', a => $title ),
|
|
);
|
|
return ( $bibnum, $title, $bibitemnum ) = AddBiblio( $bib, '' );
|
|
}
|