Jonathan Druart
d2a045b9d5
At several places we got the following error if we use numbers too big for Number::Format Template process failed: undef error - round() overflow. Try smaller precision or use Math::BigFloat at /home/koha/src/Koha/Number/Price.pm line 44 It make the app explodes. The goal here is to handle these errors gracefully and easily. Test plan: - Add a manual fine to a patron of 100000000000000 - Create a patron category with an enrolment fee of 123456789012345 Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
130 lines
4.8 KiB
Perl
130 lines
4.8 KiB
Perl
use Modern::Perl;
|
|
|
|
use Test::More tests => 31;
|
|
|
|
use Test::MockModule;
|
|
use t::lib::Mocks;
|
|
|
|
# Number formating depends by default on system environement
|
|
# See http://search.cpan.org/~wrw/Number-Format/Format.pm
|
|
use POSIX qw(setlocale LC_NUMERIC);
|
|
|
|
use Koha::Acquisition::Currencies;
|
|
my $budget_module = Test::MockModule->new('Koha::Acquisition::Currencies');
|
|
my $currency;
|
|
$budget_module->mock( 'get_active', sub { return $currency; } );
|
|
use_ok('Koha::Number::Price');
|
|
|
|
my $orig_locale = setlocale(LC_NUMERIC);
|
|
my $format = {
|
|
p_cs_precedes => 1, # Force to place the symbol at the beginning
|
|
p_sep_by_space => 0, # Force to not add a space between the symbol and the number
|
|
};
|
|
t::lib::Mocks::mock_preference( 'CurrencyFormat', 'US' );
|
|
$currency = Koha::Acquisition::Currency->new({
|
|
currency => 'USD',
|
|
symbol => '$',
|
|
rate => 1,
|
|
active => 1,
|
|
});
|
|
|
|
is( Koha::Number::Price->new->format( $format ), '0.00', 'US: format 0' );
|
|
is( Koha::Number::Price->new(3)->format( $format ), '3.00', 'US: format 3' );
|
|
is( Koha::Number::Price->new(1234567890)->format( $format ),
|
|
'1,234,567,890.00', 'US: format 1234567890' );
|
|
|
|
is( Koha::Number::Price->new(100000000000000)->format, '100000000000000', 'Numbers too big are not formatted');
|
|
|
|
# FIXME This should be display symbol, but it was the case before the creation of this module
|
|
is( Koha::Number::Price->new->format( { %$format, with_symbol => 1 } ),
|
|
'0.00', 'US: format 0 with symbol' );
|
|
is( Koha::Number::Price->new(3)->format( { %$format, with_symbol => 1 } ),
|
|
'3.00', 'US: format 3 with symbol' );
|
|
is(
|
|
Koha::Number::Price->new(1234567890)
|
|
->format( { %$format, with_symbol => 1 }, 'US: format 1234567890 with symbol' ),
|
|
'1,234,567,890.00'
|
|
);
|
|
|
|
is( Koha::Number::Price->new->unformat, '0', 'US: unformat 0' );
|
|
is( Koha::Number::Price->new(3)->unformat, '3', 'US: unformat 3' );
|
|
is( Koha::Number::Price->new(1234567890)->unformat,
|
|
'1234567890', 'US: unformat 1234567890' );
|
|
|
|
SKIP: {
|
|
# Bug 18900 - Check params are not from system environement
|
|
setlocale(LC_NUMERIC, "fr_FR.UTF-8");
|
|
my $current_locale = setlocale(LC_NUMERIC);
|
|
|
|
skip "fr_FR.UTF-8 locale required for tests and missing", 2
|
|
unless $current_locale eq 'fr_FR.UTF-8';
|
|
|
|
is( Koha::Number::Price->new(12345678.9)->format( { %$format, with_symbol => 1 } ),
|
|
'12,345,678.90', 'US: format 12,345,678.90 with symbol' );
|
|
is( Koha::Number::Price->new('12,345,678.90')->unformat,
|
|
'12345678.9', 'US: unformat 12345678.9' );
|
|
setlocale(LC_NUMERIC, $orig_locale);
|
|
}
|
|
|
|
t::lib::Mocks::mock_preference( 'CurrencyFormat', 'FR' );
|
|
$currency = Koha::Acquisition::Currency->new({
|
|
currency => 'EUR',
|
|
symbol => '€',
|
|
rate => 1,
|
|
active => 1,
|
|
});
|
|
|
|
# Actually,the price formating for France is 3,00€
|
|
# How put the symbol at the end with Number::Format?
|
|
is( Koha::Number::Price->new->format( $format ), '0,00', 'FR: format 0' );
|
|
is( Koha::Number::Price->new(3)->format( $format ), '3,00', 'FR: format 3' );
|
|
is(
|
|
Koha::Number::Price->new(1234567890)->format( $format ),
|
|
'1 234 567 890,00',
|
|
'FR: format 1234567890'
|
|
);
|
|
is( Koha::Number::Price->new->format( { %$format, with_symbol => 1 } ),
|
|
'€0,00', 'FR: format 0 with symbol' );
|
|
is( Koha::Number::Price->new(3)->format( { %$format, with_symbol => 1 } ),
|
|
'€3,00', 'FR: format 3 with symbol' );
|
|
is(
|
|
Koha::Number::Price->new(1234567890)
|
|
->format( { %$format, with_symbol => 1 }, 'FR: format 123567890 with symbol' ),
|
|
'€1 234 567 890,00'
|
|
);
|
|
|
|
is( Koha::Number::Price->new->unformat, '0', 'FR: unformat 0' );
|
|
is( Koha::Number::Price->new(3)->unformat, '3', 'FR: unformat 3' );
|
|
is( Koha::Number::Price->new(1234567890)->unformat,
|
|
'1234567890', 'FR: unformat 1234567890' );
|
|
|
|
# Price formatting for Switzerland: 1'234'567.89
|
|
t::lib::Mocks::mock_preference( 'CurrencyFormat', 'CH' );
|
|
$currency = Koha::Acquisition::Currency->new({
|
|
currency => 'nnn',
|
|
symbol => 'CHF',
|
|
rate => 1,
|
|
active => 1,
|
|
});
|
|
|
|
is( Koha::Number::Price->new->format( $format ), '0.00', 'CH: format 0' );
|
|
is( Koha::Number::Price->new(3)->format( $format ), '3.00', 'CH: format 3' );
|
|
is(
|
|
Koha::Number::Price->new(1234567890)->format( $format ),
|
|
'1\'234\'567\'890.00',
|
|
'CHF: format 1234567890'
|
|
);
|
|
is( Koha::Number::Price->new->format( { %$format, with_symbol => 1 } ),
|
|
'CHF0.00', 'CH: format 0 with symbol' );
|
|
is( Koha::Number::Price->new(3)->format( { %$format, with_symbol => 1 } ),
|
|
'CHF3.00', 'CH: format 3 with symbol' );
|
|
is(
|
|
Koha::Number::Price->new(1234567890)
|
|
->format( { %$format, with_symbol => 1 }, 'CH: format 123567890 with symbol' ),
|
|
'CHF1\'234\'567\'890.00'
|
|
);
|
|
|
|
is( Koha::Number::Price->new->unformat, '0', 'CHF: unformat 0' );
|
|
is( Koha::Number::Price->new(3)->unformat, '3', 'CHF: unformat 3' );
|
|
is( Koha::Number::Price->new(1234567890)->unformat,
|
|
'1234567890', 'CHF: unformat 1234567890' );
|