Alex Buckley
d132c10bfc
To make this work I moved the _get_sub_length function from subscription-add.pl to C4/Serials.pm so that the subscription-renew.pl script could also call it to store the sublength for the appropriate field of the subscriptions database table. Test plan: 1. Create a subscription and notice that there is a dropdown box for sub length containing the values: issues, weeks, months 2. Renew the subscription and notice that there are 3 input text boxes: 'number of num', 'number of weeks' and 'number of months' 3. Input a 'Number of weeks' value of 2 4. Query the subscription database table and notice that the value of 2 has been stored in the weeklength field for the subscription record you just renewed 5. Apply the patch 6. Renew the subscription and notice that there is now a sublength dropdown box containing issues, weeks and months 7. Set the month value to 3 8. Query the database and notice that 3 was stored in the monthlength field for the subscription record 9. Create a new subscription and select the sub length values of issues and 3 10. Query the database and notice that the numberlength field for the subscription you just created is set to 3 showing that the sublength dropbox is still working for creating a new subscription Sponsored-By: Catalyst IT Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
129 lines
4.2 KiB
Perl
129 lines
4.2 KiB
Perl
#!/usr/bin/perl
|
|
|
|
# This script includes tests for ReNewSubscription
|
|
|
|
# Copyright 2015 BibLibre, Paul Poulain
|
|
# Copyright 2018 Catalyst IT, Alex Buckley
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use Test::More tests => 7;
|
|
use Test::MockModule;
|
|
use t::lib::TestBuilder;
|
|
use t::lib::Mocks;
|
|
|
|
use C4::Serials;
|
|
|
|
use Koha::Database;
|
|
use Koha::Subscription::Histories;
|
|
|
|
my $schema = Koha::Database->new->schema;
|
|
$schema->storage->txn_begin;
|
|
|
|
my $builder = t::lib::TestBuilder->new();
|
|
|
|
# create fake numberpattern & fake periodicity
|
|
my $frequency = $builder->build({
|
|
source => 'SubscriptionFrequency',
|
|
value => {
|
|
description => "daily",
|
|
unit => "day",
|
|
unitsperissue => 1,
|
|
},
|
|
});
|
|
|
|
my $pattern = $builder->build({
|
|
source => 'SubscriptionNumberpattern',
|
|
value => {
|
|
label => 'mock',
|
|
description =>'mock',
|
|
numberingmethod => 'Issue {X}',
|
|
add1 => 1,
|
|
every1 => 1,
|
|
setto1 => 100,
|
|
}
|
|
});
|
|
|
|
my $biblio = $builder->build_sample_biblio();
|
|
|
|
# Create fake subscription, daily subscription, duration 12 months, issues startint at #100
|
|
my $subscription = $builder->build({
|
|
source => 'Subscription',
|
|
value => {
|
|
biblionumber => $biblio->biblionumber,
|
|
startdate => '2015-01-01',
|
|
enddate => '2015-12-31',
|
|
aqbooksellerid => 1,
|
|
periodicity => $frequency->{id},
|
|
numberpattern => $pattern->{id},
|
|
monthlength => 12,
|
|
},
|
|
});
|
|
|
|
my $subscriptionhistory = $builder->build({
|
|
source => 'Subscriptionhistory',
|
|
value => {
|
|
biblionumber => $biblio->biblionumber,
|
|
subscriptionid => $subscription->{subscriptionid},
|
|
histenddate => undef,
|
|
opacnote => 'Testing',
|
|
}
|
|
});
|
|
|
|
# Actual testing starts here!
|
|
# Renew the subscription and check that enddate has not been set
|
|
ReNewSubscription(
|
|
{
|
|
subscriptionid => $subscription->{subscriptionid},
|
|
startdate => "2016-01-01",
|
|
monthlength => 12
|
|
}
|
|
);
|
|
|
|
# Calculate the subscription length for the renewal for issues, days and months
|
|
my ($numberlength, $weeklength, $monthlength) = GetSubscriptionLength('issues', 7);
|
|
is ( $numberlength, 7, "Subscription length is 7 issues");
|
|
|
|
($numberlength, $weeklength, $monthlength) = GetSubscriptionLength('weeks', 7);
|
|
is ( $weeklength, 7, "Subscription length is 7 weeks");
|
|
|
|
($numberlength, $weeklength, $monthlength) = GetSubscriptionLength('months', 7);
|
|
is ( $monthlength, 7, "Subscription length is 7 months");
|
|
|
|
# Check subscription length when no value is inputted into the numeric sublength field
|
|
($numberlength, $weeklength, $monthlength) = GetSubscriptionLength('months', '');
|
|
is ($monthlength, undef, "Subscription length is undef months, invalid month data was not stored");
|
|
|
|
# Check subscription length when a letter is inputted into the numeric sublength field
|
|
($numberlength, $weeklength, $monthlength) = GetSubscriptionLength('issues', 'w');
|
|
is ($monthlength, undef, "Subscription length is undef issues, invalid issue data was not stored");
|
|
|
|
# Check subscription length when a special character is inputted into numberic sublength field
|
|
($numberlength, $weeklength, $monthlength) = GetSubscriptionLength('weeks', '!');
|
|
is ($weeklength, undef, "Subscription length is undef weeks, invalid weeks data was not stored");
|
|
|
|
# Renew the subscription and check that enddate has not been set
|
|
|
|
my $history = Koha::Subscription::Histories->find($subscription->{subscriptionid});
|
|
|
|
is ( $history->histenddate(), undef, 'subscription history not empty after renewal');
|
|
|
|
# End of tests
|
|
|
|
$schema->storage->txn_rollback;
|
|
|