Jonathan Druart
8f436a5075
C4::Koha::getframeworks returned a hashref of biblio frameworks.
It was mainly used to generate the dropdown list of frameworks.
The scripts modified in this patch did not necessary order the element
by description (frameworktext), the displays were not consistent from
one screen to another.
Using the same search method everywhere:
Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] });
We will know always get the framework in the same order.
Test plan:
Following the different pages modified by this patch, and make sure the
frameworks are displayed correctly in the dropdown list:
1/ acqui/z3950_search.pl - Create an order from an external source.
2/ admin/fieldmapping.pl - Define some mappings keyword / MARC field
3/ admin/marctagstructure.pl - On the MARC frameworks admin page, select
another framework than the default one and click on the 'Search' button
4/ catalogue/MARCdetail.pl - On the MARC defail page, change the
framework you want to use to display the record
5/ cataloguing/addbiblio.pl - Add or edit a biblio record, change its
framework. When editing, the framework of the record should be selected
by default
6/ cataloguing/addbooks.pl - Go on the cataloguing home page and click
on the "New record" button. You should see all the frameworks
7/ cataloguing/merge.pl - Select 2 biblio records to merge. On the first
step (select the merge reference), you should be allowed to select the
framework to use.
8/ tools/inventory.pl - On the inventory page, the "Item statuses" part
should be populated as before this patch
9/ tools/manage-marc-import.pl - Stage records for import. Before
importing them into the catalog, you should see the framework dropdown
list.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Works Ok.
No errors
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
68 lines
2.1 KiB
Perl
Executable file
68 lines
2.1 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
# Copyright 2009 SARL BibLibre
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use strict;
|
|
use warnings;
|
|
use CGI qw ( -utf8 );
|
|
use C4::Auth;
|
|
use C4::Biblio;
|
|
use C4::Koha;
|
|
use C4::Output;
|
|
|
|
use Koha::BiblioFrameworks;
|
|
|
|
my $query = new CGI;
|
|
|
|
my $frameworkcode = $query->param('framework') || "";
|
|
my $field = $query->param('fieldname');
|
|
my $fieldcode = $query->param('marcfield');
|
|
my $subfieldcode = $query->param('marcsubfield');
|
|
my $op = $query->param('op') || q{};
|
|
my $id = $query->param('id');
|
|
|
|
my ($template, $loggedinuser, $cookie)
|
|
= get_template_and_user({template_name => "admin/fieldmapping.tt",
|
|
query => $query,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => {parameters => 'parameters_remaining_permissions'},
|
|
debug => 1,
|
|
});
|
|
|
|
if($op eq "delete" and $id){
|
|
DeleteFieldMapping($id);
|
|
print $query->redirect("/cgi-bin/koha/admin/fieldmapping.pl?framework=".$frameworkcode);
|
|
exit;
|
|
}
|
|
|
|
# insert operation
|
|
if($field and $fieldcode){
|
|
SetFieldMapping($frameworkcode, $field, $fieldcode, $subfieldcode);
|
|
}
|
|
|
|
my $fieldloop = GetFieldMapping($frameworkcode);
|
|
|
|
my $frameworks = Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] });
|
|
my $framework = $frameworks->search( { frameworkcode => $frameworkcode } )->next;
|
|
$template->param(
|
|
frameworks => $frameworks,
|
|
framework => $framework,
|
|
fields => $fieldloop,
|
|
);
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|