a3c64f62c0
When background_jobs_worker.pl spawns a new child process, it needs to
explicitly reinitialize the random seed - otherwise each child process
will inherit the same random seed from the parent process, and any
randomization will produce identical results each time.
This patch adds a call to srand immediately after the fork to
reinitialize the seed. Note that child processes should not call
srand with no parameter anywhere else, as the Perl documentation
indicates that srand should not be called with no parameter more than
once per process.
To test:
1. Apply the logging patch only
2. Set system preferences:
a. RealTimeHoldsQueue -> Enable
b. RandomizeHoldsQueueWeight -> in random order
3. Watch the logs for the staff interface
in ktd:
ktd --shell
koha-intra-err
4. Place a hold. Note that the logs display the branch list before and
after it is randomized.
5. Place some more holds. Note that the branch order after randomization
is identical each time.
6. Apply both patches and restart_all
7. Repeat steps 3-5.
-> Note that the branch order before randomization hasn't changed
-> Note that the branch order after randomization is now different
each time.
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
|
||
|---|---|---|
| .. | ||
| admin | ||
| bin | ||
| cronjobs | ||
| devel | ||
| interface_customization | ||
| maintenance | ||
| migration_tools | ||
| release_notes | ||
| search_tools | ||
| translator | ||
| workers | ||
| add_date_fields_to_marc_records.pl | ||
| add_statistics_borrowers_categorycode.pl | ||
| batchCompareMARCvsFrameworks.pl | ||
| batchdeletebiblios.pl | ||
| batchDeleteUnusedSubfields.pl | ||
| batchImportMARCWithBiblionumbers.pl | ||
| batchRebuildBiblioTables.pl | ||
| batchRebuildItemsTables.pl | ||
| batchRepairMissingBiblionumbers.pl | ||
| check_sysprefs.pl | ||
| commit_file.pl | ||
| export_borrowers.pl | ||
| export_records.pl | ||
| exportauth.pl | ||
| import_patrons.pl | ||
| koha-install-log | ||
| link_bibs_to_authorities.pl | ||
| load_yaml.pl | ||
| mod_zebraqueue.pl | ||
| perlmodule_ls.pl | ||
| perlmodule_rm.pl | ||
| process_ill_updates.pl | ||
| recreateIssueStatistics.pl | ||
| sax_parser_print.pl | ||
| sax_parser_test.pl | ||
| sip_cli_emulator.pl | ||
| stage_file.pl | ||
| z3950_responder.pl | ||