Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/koha-tmpl/intranet-tmpl/prog/en/includes
History
Jonathan Druart be691d86e3 Bug 21096: Do not display loggedinusername in template 
This patch is a little fix for a much bigger hidden issues.

The original issue:
1. Set the firstname and surname values of a paontr to utf-8 characters
("wide characters"), for instance 月月
2. Use this patron to login at the staff interface
=> In the header the logged in patron's info (concat of firstname and
surname) are displayed correctly
3. Hit whatever link
=> In the header the info are now displayed incorrectly
("ææ")

What happens?
After that the user loggin, loggedinusername is set with the value from
the DB (borrowers.userid)
On next hits it is picked from the session (which contains the decoded
utf8 value, see first lines of C4::Context->set_userenv)
From C4::Auth::checkauth:
834             $s_userid = $session->param('id') // ''

The quick fix is to use the logged_in_user variable in the template, but
it seems that issues may occurred if external authentication is used
(ldap, shib, cas). Could someone test this?

Test plan:
Make sure the original issue is fixed

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-08-30 13:40:31 +00:00
..
catalogue Bug 13618: Fix item search 2018-08-17 15:55:12 +00:00
csv_headers Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
modals Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
str Bug 21068: Remove NorwegianPatronDB related code 2018-08-30 13:40:29 +00:00
virtualshelves/merge Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
account_offset_type.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
accounttype.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
acquisitions-add-to-basket.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
acquisitions-menu.inc Bug 11911: Add a separate permission for managing suggestions 2018-07-23 15:34:20 +00:00
acquisitions-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
acquisitions-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
additem.js.inc
admin-items-search-field-form.inc Bug 13618: Remove filter when assigning array 2018-08-17 16:53:56 +00:00
admin-menu.inc Bug 7651: (follow-up) Correct visibility on admin sidebar 2018-07-18 17:45:21 +00:00
adv-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
auth-finder-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
authorities-search-results.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
authorities-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
authorities-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
authorities.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
authorities_js.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
av-build-dropbox.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
biblio-default-view.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
biblio-view-menu.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
blocked-fines.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
blocking_errors.inc Bug 13618: Remove html filter for STOP and deal with existing USE raw 2018-08-17 15:55:14 +00:00
borrower_debarments.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
branch-selector.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
browser-strings.inc
budgets-active-currency.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
budgets-admin-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
budgets-admin-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
calendar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
cat-menu.inc
cat-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
cat-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
catalog-strings.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
cataloging-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
cateditor-ui.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
cateditor-widgets-marc21.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
checkin-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
checkouts-table-footer.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
checkouts-table.inc Bug 19719: (follow-up) Show description instead of code 2018-08-22 13:22:18 +00:00
circ-menu.inc Bug 7996: Correct wrong permissions for modification log 2018-08-22 11:47:10 +00:00
circ-nav.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
circ-patron-search-results.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
circ-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
cities-admin-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
columns_settings.inc Bug 18791: Export visible columns only 2018-04-13 13:55:22 -03:00
contracts-admin-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
country-list.inc
currencies-admin-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
datatables.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
date-format.inc
delimiter_text.inc Bug 19910: Use span to make translators happy 2018-04-04 16:06:56 -03:00
doc-head-close-receipt.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
doc-head-close.inc Bug 13618: Manually replace missing .raw 2018-08-17 15:55:10 +00:00
doc-head-open.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
empty_line.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
facets.inc Bug 13618: Fix BLOCKs 2018-08-17 15:55:09 +00:00
form-blocks.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
format_price.inc
greybox.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
guided-reports-view.inc Bug 19856: Improve styling of reports sidebar 2018-03-23 11:45:38 -03:00
header.inc Bug 21096: Do not display loggedinusername in template 2018-08-30 13:40:31 +00:00
help-bottom.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
help-top.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
home-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
html_helpers.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
ill-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
installer-doc-head-close.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
installer-strings.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
intranet-bottom.inc Bug 13618: Manually replace missing .raw 2018-08-17 15:55:10 +00:00
intranetstylesheet.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
js_includes.inc Bug 13618: (follow-up) Add html filters to all the variables 2018-08-17 15:55:13 +00:00
labels-toolbar.inc Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos 2018-02-12 15:41:38 -03:00
langmenu-staff-top.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
letters-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-alt-address-style-de.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-alt-address-style-fr.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-alt-address-style-us.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-alt-contact-style-de.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-alt-contact-style-fr.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-alt-contact-style-us.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-display-address-style-de.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-display-address-style-fr.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-display-address-style-us.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-display-alt-address-style-de.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-display-alt-address-style-fr.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-display-alt-address-style-us.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-main-address-style-de.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-main-address-style-fr.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
member-main-address-style-us.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
members-menu.inc Bug 7996: Correct wrong permissions for modification log 2018-08-22 11:47:10 +00:00
members-toolbar.inc Bug 21068: Remove NorwegianPatronDB related code 2018-08-30 13:40:29 +00:00
merge-record-strings.inc
merge-record.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
messaging-preference-form.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
noadd-warnings.inc
onboarding_messages.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
page-numbers.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
password_check.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
patron-article-requests.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
patron-search-box.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
patron-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
patron-title.inc Bug 13618: Deal with span in patron-title 2018-08-17 15:55:11 +00:00
patron-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
patroncards-errors.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
patroncards-toolbar.inc Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos 2018-02-12 15:41:38 -03:00
patrons-admin-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
permissions.inc Bug 11911: Add a separate permission for managing suggestions 2018-07-23 15:34:20 +00:00
popup-bottom.inc Bug 13618: Manually replace missing .raw 2018-08-17 15:55:10 +00:00
prefs-admin-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
prefs-menu.inc Bug 19538: Move EnableAdvancedCatalogingEdtor from 'Labs' to 'Cataloging' 2018-04-11 16:45:09 -03:00
quotes-toolbar.inc
quotes-upload-toolbar.inc
reports-menu.inc Bug 19856: (follow-up) Improve styling of reports sidebar 2018-03-23 11:45:38 -03:00
reports-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
resort_form.inc
rotating-collections-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
search_indexes.inc Bug 19807: Make IntranetCatalogSearchPulldown honor IntranetNumbersPreferPhrase 2018-01-02 12:58:55 -03:00
select2.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
serials-menu.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
serials-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
serials-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
slip-print.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
strings.inc Bug 21029: Make "Suspend until:" translatable 2018-07-06 10:13:52 +00:00
subscriptions-search.inc
subtypes_unimarc.inc
suggestions-add-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
timepicker.inc
tools-item-action.inc
tools-menu.inc Bug 11317: (QA follow-up) Change tool name to be more general 2018-05-03 13:26:50 -03:00
tools-nomatch-action.inc
tools-overlay-action.inc
validator-strings.inc
vendor-menu.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
virtualshelves-toolbar.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
wysiwyg-systempreferences.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
xslt-handler.inc Bug 20272: Changes for Breeding.pm and Record.pm 2018-07-02 12:12:49 +00:00
z3950-admin-search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00
z3950_search.inc Bug 13618: Add html filters to all the variables 2018-08-17 15:55:05 +00:00