Koha/misc/cronjobs/gather_print_notices.pl
Kyle M Hall 20b5228af6 Bug 8063 - Followup - Bug fix
$OUTPUT being used but not being declared.

When trying to run this script I gat a nasty:
15:42 ~/koha.dev/koha-community (new/bug_8063 $%)$ ./misc/cronjobs/gather_print_notices.pl
Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 81.
Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 95.
Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 102.
Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 106.
Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 120.
Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 127.
Execution of ./misc/cronjobs/gather_print_notices.pl aborted due to compilation errors.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Before the patch:
$perl -wc ./misc/cronjobs/gather_print_notices.pl
Global symbol "$OUTPUT" requires explicit package name at
[...]./misc/cronjobs/gather_print_notices.pl line 81.
./misc/cronjobs/gather_print_notices.pl had compilation errors.

With this patch:
$perl -wc ./misc/cronjobs/gather_print_notices.pl
./misc/cronjobs/gather_print_notices.pl syntax OK

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-07-16 14:54:02 +02:00

130 lines
3.5 KiB
Perl
Executable file

#!/usr/bin/perl -w
# Copyright 2009 Jesse Weaver
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it under the
# terms of the GNU General Public License as published by the Free Software
# Foundation; either version 2 of the License, or (at your option) any later
# version.
#
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along
# with Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
use strict;
use warnings;
BEGIN {
# find Koha's Perl modules
# test carefully before changing this
use FindBin;
eval { require "$FindBin::Bin/../kohalib.pl" };
}
use
CGI; # NOT a CGI script, this is just to keep C4::Templates::gettemplate happy
use C4::Context;
use C4::Dates;
use C4::Debug;
use C4::Letters;
use C4::Templates;
use File::Spec;
use Getopt::Long;
sub usage {
print STDERR <<USAGE;
Usage: $0 OUTPUT_DIRECTORY
Will print all waiting print notices to
OUTPUT_DIRECTORY/notices-CURRENT_DATE.html .
-s --split Split messages into separate file by borrower home library to OUTPUT_DIRECTORY/notices-CURRENT_DATE-BRANCHCODE.html
USAGE
exit $_[0];
}
my ( $stylesheet, $help, $split );
GetOptions(
'h|help' => \$help,
's|split' => \$split,
) || usage(1);
usage(0) if ($help);
my $output_directory = $ARGV[0];
if ( !$output_directory || !-d $output_directory ) {
print STDERR
"Error: You must specify a valid directory to dump the print notices in.\n";
usage(1);
}
my $today = C4::Dates->new();
my @all_messages = @{ GetPrintMessages() };
exit unless (@all_messages);
my $OUTPUT;
if ($split) {
my %messages_by_branch;
foreach my $message (@all_messages) {
push( @{ $messages_by_branch{ $message->{'branchcode'} } }, $message );
}
foreach my $branchcode ( keys %messages_by_branch ) {
my @messages = @{ $messages_by_branch{$branchcode} };
open $OUTPUT, '>',
File::Spec->catdir( $output_directory,
"holdnotices-" . $today->output('iso') . "-$branchcode.html" );
my $template =
C4::Templates::gettemplate( 'batch/print-notices.tmpl', 'intranet',
new CGI );
$template->param(
stylesheet => C4::Context->preference("NoticeCSS"),
today => $today->output(),
messages => \@messages,
);
print $OUTPUT $template->output;
foreach my $message (@messages) {
C4::Letters::_set_message_status(
{ message_id => $message->{'message_id'}, status => 'sent' } );
}
close $OUTPUT;
}
}
else {
open $OUTPUT, '>',
File::Spec->catdir( $output_directory,
"holdnotices-" . $today->output('iso') . ".html" );
my $template =
C4::Templates::gettemplate( 'batch/print-notices.tmpl', 'intranet',
new CGI );
$template->param(
stylesheet => C4::Context->preference("NoticeCSS"),
today => $today->output(),
messages => \@all_messages,
);
print $OUTPUT $template->output;
foreach my $message (@all_messages) {
C4::Letters::_set_message_status(
{ message_id => $message->{'message_id'}, status => 'sent' } );
}
close $OUTPUT;
}