Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Main Koha release repository https://koha-community.org
39103 commits 35 branches 616 tags 1.8 GiB
Perl 45.6%
JavaScript 39.3%
HTML 7.2%
XSLT 3.7%
Vue 1.4%
Other 2.3%
Find a file
Jonathan Druart a51a4f117d Bug 26141: Remove duplicated code from search.pl 
commit 417553a9e4
  Bug 12478: starting to add search to staff client

This commit added code related to the itemtypes to the advanced search, but this code already existed.

The weird bit is:
$template->param(advancedsearchesloop => \@advancedsearchesloop);
my $types = C4::Context->preference("AdvancedSearchTypes") || "itemtypes";
my $advancedsearchesloop = prepare_adv_search_types($types);
$template->param(advancedsearchesloop => $advancedsearchesloop);

We are passing twice advancedsearchesloop to the template.

Test plan (for QA):
Review the changes and confirm that we can safely remove this code

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-08-05 17:36:28 +02:00
acqui Bug 21268: Don't remove 0 allocated funds from fund list 2020-07-30 17:44:27 +02:00
admin Bug 25873: Ignore malformed data for Elasticsearch integer fields 2020-07-31 15:07:42 +02:00
api/v1 Bug 23820: Add checkout to default to patron's home branch on club hold 2020-07-20 17:45:30 +02:00
authorities
basket
C4 Bug 26108: Only call the plugin hook if a return took place 2020-07-31 15:04:44 +02:00
catalogue Bug 26141: Remove duplicated code from search.pl 2020-08-05 17:36:28 +02:00
cataloguing Bug 24279: Disable editing lost status in items editor if item is a return claim 2020-07-27 17:05:06 +02:00
circ Bug 25765: Replace LoginBranchname and LoginBranchcode with use of Branches template plugin 2020-07-23 11:17:27 +02:00
clubs
course_reserves
debian Bug 25920: Add liblocale-codes-perl package to fix ubuntu-stable (focal) 2020-07-30 17:44:27 +02:00
docs Bug 21395: (QA follow-up) Remove some introduced issues 2020-06-29 12:37:02 +02:00
errors
etc Bug 24151: (follow-up) Rename the config key with 'bcrypt_settings' 2020-07-23 12:15:38 +02:00
ill
installer Bug 26070: DBRev 20.06.00.020 2020-07-30 17:44:27 +02:00
Koha Bug 26138: Make Koha::Plugins->call return consistent value 2020-08-05 17:36:28 +02:00
koha-tmpl Bug 24610: Compiled CSS 2020-08-03 11:57:55 +02:00
labels
members Bug 22844: Make the attribute mandatory when editing a patron 2020-07-20 16:08:22 +02:00
misc Bug 23696: take deleted biblios into account when building oai sets 2020-07-24 14:09:30 +02:00
offline_circ
opac Bug 26070: Remove GoogleIndicTransliteration system preference 2020-07-30 17:44:27 +02:00
patron_lists
patroncards Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
plugins Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
pos
reports Bug 21395: (QA follow-up) Remove some introduced issues 2020-06-29 12:37:02 +02:00
reserve
reviews
rotating_collections
serials
services
skel
suggestion
svc Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
t Bug 26043: Fix random failure from Holds.t 2020-08-05 17:36:28 +02:00
tags Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
tmp/modified_authorities
tools Bug 5087: (QA follow-up) Rename the attribute to fit later API usage 2020-07-23 10:52:10 +02:00
virtualshelves
xt Bug 22844: Fix yaml_valid.t - don't pick .json files 2020-07-21 09:47:11 +02:00
.editorconfig
.eslintrc.json
.gitignore
.htaccess
.mailmap
.perlcriticrc Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
.scss-lint.yml
about.pl Bug 24151: Rename the config key with 'bcrypt_settings' 2020-07-20 15:17:42 +02:00
changelanguage.pl
cpanfile Bug 25723: Drop DateTime::Set from cpanfile 2020-07-20 17:45:31 +02:00
fix-perl-path.PL Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
gulpfile.js
help.pl
INSTALL
Koha.pm Bug 26070: DBRev 20.06.00.020 2020-07-30 17:44:27 +02:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 2020-07-21 14:34:25 +02:00
MANIFEST.SKIP
package.json
README
README.md
README.robots
rewrite-config.PL Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 2020-07-21 14:34:25 +02:00
yarn.lock

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo