Martin Renvoize
a54646ff69
This patch corrects the handling of the 'Standard' search field in patron searches such that it accurately reflects the contents of the DefaultPatronSearchFields system preference and falls back to a hard coded list instead of always using the hard coded list. To test: 1) Empty the contents of DefaultPatronSearchFields systempreference 2) Perform a patron search from the header search 3) Inspect the patrons API request and note that we search on the default fallback fields of firstname, surname, othernames, cardnumber and userid (and some extended attributes which are historically hard coded). 4) Navigate to the memebers-home by clicking the 'Patrons' button from the main page 5) Perform another search using the filters on the left with 'Standard' selected. 6) Note the same list of search fields used as above in the patrons API request. 7) Update the DefaultPatronSearchFields systempreference adding one or more borrower fields in a comma delimited list. 8) Repeat steps 2 -> 6 but this time upon inspecting the API request you should find that only the fields in your DefaultPatronSearchFields list are searched (along with the hard coded extended attributes list). 9) Signoff Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
75 lines
4.1 KiB
PHP
75 lines
4.1 KiB
PHP
[%- BLOCK patron_fields -%]
|
|
[%- SWITCH name -%]
|
|
[%- CASE standard -%]<span>Standard</span>
|
|
[%- CASE 'borrowernumber' -%]<span>Borrowernumber</span>
|
|
[%- CASE 'cardnumber' -%]<span>Card number</span>
|
|
[%- CASE 'surname' -%]<span>Surname</span>
|
|
[%- CASE 'firstname' -%]<span>First name</span>
|
|
[%- CASE 'title' -%]<span>Salutation</span>
|
|
[%- CASE 'othernames' -%]<span>Other name</span>
|
|
[%- CASE 'initials' -%]<span>Initials</span>
|
|
[%- CASE 'streetnumber' -%]<span>Street number</span>
|
|
[%- CASE 'streettype' -%]<span>Street type</span>
|
|
[%- CASE 'address' -%]<span>Address</span>
|
|
[%- CASE 'address2' -%]<span>Address 2</span>
|
|
[%- CASE 'city' -%]<span>City</span>
|
|
[%- CASE 'state' -%]<span>State</span>
|
|
[%- CASE 'zipcode' -%]<span>ZIP/Postal code</span>
|
|
[%- CASE 'country' -%]<span>Country</span>
|
|
[%- CASE 'email' -%]<span>Primary email</span>
|
|
[%- CASE 'phone' -%]<span>Primary phone</span>
|
|
[%- CASE 'mobile' -%]<span>Mobile phone</span>
|
|
[%- CASE 'fax' -%]<span>Fax</span>
|
|
[%- CASE 'emailpro' -%]<span>Secondary email</span>
|
|
[%- CASE 'phonepro' -%]<span>Secondary phone</span>
|
|
[%- CASE 'B_streetnumber' -%]<span>Alternate street number</span>
|
|
[%- CASE 'B_streettype' -%]<span>Alternate street type</span>
|
|
[%- CASE 'B_address' -%]<span>Alternate address</span>
|
|
[%- CASE 'B_address2' -%]<span>Alternate address line 2</span>
|
|
[%- CASE 'B_city' -%]<span>Alternate city</span>
|
|
[%- CASE 'B_state' -%]<span>Alternate state</span>
|
|
[%- CASE 'B_zipcode' -%]<span>Alternate zip code</span>
|
|
[%- CASE 'B_country' -%]<span>Alternate country</span>
|
|
[%- CASE 'B_email' -%]<span>Alternate email</span>
|
|
[%- CASE 'B_phone' -%]<span>Alternate phone</span>
|
|
[%- CASE 'dateofbirth' -%]<span>Date of birth</span>
|
|
[%- CASE 'branchcode' -%]<span>Library (code)</span>
|
|
[%- CASE 'categorycode' -%]<span>Category (code)</span>
|
|
[%- CASE 'dateenrolled' -%]<span>Registration date</span>
|
|
[%- CASE 'dateexpiry' -%]<span>Expiry date</span>
|
|
[%- CASE 'gonenoaddress' -%]<span>Gone no address</span>
|
|
[%- CASE 'lost' -%]<span>Lost card</span>
|
|
[%- CASE 'debarred' -%]<span>Restricted</span>
|
|
[%- CASE 'debarredcomment' -%]<span>Restriction reason</span>
|
|
[%- CASE 'contactname' -%]<span>Guarantor surname</span>
|
|
[%- CASE 'contactfirstname' -%]<span>Guarantor firstname</span>
|
|
[%- CASE 'contacttitle' -%]<span>Guarantor title</span>
|
|
[%- CASE 'guarantorid' -%]<span>Guarantor ID</span>
|
|
[%- CASE 'borrowernotes' -%]<span>Circulation note</span>
|
|
[%- CASE 'relationship' -%]<span>Guarantor relationship</span>
|
|
[%- CASE 'sex' -%]<span>Gender</span>
|
|
[%- CASE 'flags' -%]<span>Permissions (code)</span>
|
|
[%- CASE 'userid' -%]<span>Username</span>
|
|
[%- CASE 'opacnote' -%]<span>OPAC note</span>
|
|
[%- CASE 'contactnote' -%]<span>Contact note</span>
|
|
[%- CASE 'sort1' -%]<span>Sort 1</span>
|
|
[%- CASE 'sort2' -%]<span>Sort 2</span>
|
|
[%- CASE 'altcontactfirstname' -%]<span>Alternate contact first name</span>
|
|
[%- CASE 'altcontactsurname' -%]<span>Alternate contact surname</span>
|
|
[%- CASE 'altcontactaddress1' -%]<span>Alternate contact address</span>
|
|
[%- CASE 'altcontactaddress2' -%]<span>Alternate contact address 2</span>
|
|
[%- CASE 'altcontactaddress3' -%]<span>Alternate contact city</span>
|
|
[%- CASE 'altcontactstate' -%]<span>Alternate contact state</span>
|
|
[%- CASE 'altcontactzipcode' -%]<span>Alternate contact ZIP/postal code</span>
|
|
[%- CASE 'altcontactcountry' -%]<span>Alternate contact country</span>
|
|
[%- CASE 'altcontactphone' -%]<span>Alternate contact phone</span>
|
|
[%- CASE 'smsalertnumber' -%]<span>SMS alert number</span>
|
|
[%- CASE 'sms_provider_id' -%]<span>SMS provider</span>
|
|
[%- CASE 'privacy' -%]<span>Privacy (code)</span>
|
|
[%- CASE 'privacy_guarantor_checkouts' -%]<span>Guarantor can view checkouts</span>
|
|
[%- CASE 'updated_on' -%]<span>Last updated</span>
|
|
[%- CASE 'lastseen' -%]<span>Last seen</span>
|
|
[%- CASE 'checkprevcheckout' -%]<span>Check previous checkout</span>
|
|
[%- CASE DEFAULT -%]
|
|
[%- END -%]
|
|
[%- END -%]
|