Marcel de Rooy
a58aca056b
The two new columns as mentioned in the commit message of the table revision must be used in the codebase now. Highlighting some changes in Koha::VirtualShel[f|ves]: [1] Additional methods is_public and is_private. [2] Method add_biblio did not check permissions. Does now. No impact on the interface, but one call in the unit test was affected. [3] Method remove_biblios is signficantly simplified. Removed a FIXME. [4] Method can_biblios_be_removed now redirects to can_biblios_be_added. A followup report may deal with unifying those routines. [5] Condition in get_some_shelves changed. [6] The reference to allow_add in get_shelves_containing_record can simply be removed. opac-shelves.pl and shelves.pl now pass the default setting of Owner only to the template. Templates shelves.tt and opac-shelves.tt now include the new permission field with three choices as mentioned in the table revision patch. opac-addbybiblionumber.pl and addbybiblionumber now need a check on allow_change_from_owner; search conditions slightly adjusted to the new permission scheme. Test plan: When we refer to visibility in the test plan, please check the Add to-combo on opac search results and staff results. And check opac-addbybiblionumber by clicking Save to Lists from opac results. The step 'Check delete' means: open the list in opac and check if you see the Delete button below the entries (only check, do not delete). [ 1] Create private list I01 (perm=Owner) [ 2] Check visibility: Seen. [ 3] Add a book. (Change by owner should be allowed.) [ 4] Check delete: Yes. [ 5] Edit list I01, set perm=Nobody [ 6] Check visibility: Not seen. [ 7] Check delete: No. [ 8] Share list I01 with another patron. [ 9] Check visibility for the other patron: Not seen. [10] Check delete for the other patron: No. [11] Change permission of list I01 to Anyone (by owner). [12] Check visibility for the other patron: Seen. [13] Let other patron add a book (change is allowed). [14] Let owner delete the same book again (change allowed). [15] Create public list U01 (perm=Owner) [16] Check visibility: Seen. [17] Add a book. (Change by owner should be allowed.) [18] Login as other user. Check visibility: Not seen. Check delete: No. [19] Change permission of U01 to Nobody (by owner) [20] As owner: Check visibility: Not seen. Check delete: No. [21] As other user: Check visibility: Not seen. Check delete: No. [22] Create public list U02 (perm=Anyone) [23] Add a book by owner. [24] Delete the same book by other user. Add another book. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> |
||
---|---|---|
.. | ||
clubs | ||
errors | ||
sco | ||
svc | ||
text | ||
ilsdi.tt | ||
maintenance.tt | ||
opac-account-pay-error.tt | ||
opac-account.tt | ||
opac-addbybiblionumber.tt | ||
opac-advsearch.tt | ||
opac-alert-subscribe.tt | ||
opac-auth-detail.tt | ||
opac-auth-MARCdetail.tt | ||
opac-auth.tt | ||
opac-authorities-home.tt | ||
opac-authoritiessearchresultlist.tt | ||
opac-basket.tt | ||
opac-blocked.tt | ||
opac-browser.tt | ||
opac-course-details.tt | ||
opac-course-reserves.tt | ||
opac-detail.tt | ||
opac-discharge.tt | ||
opac-downloadcart.tt | ||
opac-downloadshelf.tt | ||
opac-full-serial-issues.tt | ||
opac-ics.tt | ||
opac-idref.tt | ||
opac-imageviewer.tt | ||
opac-ISBDdetail.tt | ||
opac-issue-note.tt | ||
opac-main.tt | ||
opac-MARCdetail.tt | ||
opac-memberentry-update-submitted.tt | ||
opac-memberentry.tt | ||
opac-messaging.tt | ||
opac-mymessages.tt | ||
opac-news-rss.tt | ||
opac-opensearch.tt | ||
opac-overdrive-search.tt | ||
opac-passwd.tt | ||
opac-password-recovery.tt | ||
opac-privacy.tt | ||
opac-readingrecord.tt | ||
opac-registration-confirmation.tt | ||
opac-registration-email-sent.tt | ||
opac-registration-invalid.tt | ||
opac-request-article.tt | ||
opac-reserve.tt | ||
opac-restrictedpage.tt | ||
opac-results-grouped.tt | ||
opac-results.tt | ||
opac-retrieve-file.tt | ||
opac-review.tt | ||
opac-search-history.tt | ||
opac-sendbasket.tt | ||
opac-sendbasketform.tt | ||
opac-sendshelf.tt | ||
opac-sendshelfform.tt | ||
opac-serial-issues.tt | ||
opac-shareshelf.tt | ||
opac-shelves-rss.tt | ||
opac-shelves.tt | ||
opac-showmarc.tt | ||
opac-showreviews-rss.tt | ||
opac-showreviews.tt | ||
opac-suggestions.tt | ||
opac-tags.tt | ||
opac-tags_subject.tt | ||
opac-topissues.tt | ||
opac-user.tt |