Jonathan Druart
b9258aa903
We have our own "quote_po" sub that is stating that Locale::PO::quote is buggy because it does not deal with quoting new lines correctly. However it seems that it is fixed now. Ideally we could use Locale::PO::quote everywhere, but it does not escape tab characters: $string =~ s/\\(?!t)/\\\\/g; # \t is a tab This means the following: msgid "Tabulation (\\t)" msgstr "Tabulation (\\t)" become: -msgid "Tabulation (\t)" -msgstr "Tabulation (\t)" And we are seeing the following on Weblate: https://snipboard.io/BjQmDC.jpg Note that Locale::PO has not been updated since 2014... The real problem behind this is that we have 2 methods to quote strings. At first glance it seems that Locale::PO::quote was not used before, but with the introduction of the koha-i18n project we will have scripts that will use Locale::PO->save_file_fromarray, which uses Locale::PO->quote => Those scripts will be used on the translation server for post processing (security reason, marking potential XSS strings as fuzzy). Test plan: 0. Do not apply the patch 1. gulp po:update --lang LANG # Replace LANG with your favorite language code 2. git commit -a -m"init PO files" 3. Apply this patch 4. Repeate 1. 5. git diff => The change is about the "Tabulation" and "New line" strings from tools/csv-profiles.tt 6. Translate them (replace the \t and \n with %s) and remove the fuzzy flag 7. install the template: cd misc/translator && perl translate install LANG 8. Enable the language, use it and go to the "Nouveau profil CSV" view => Notice that the \t and \n are correctly displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> |
||
|---|---|---|
| .. | ||
| admin | ||
| bin | ||
| cronjobs | ||
| devel | ||
| interface_customization | ||
| maintenance | ||
| migration_tools | ||
| release_notes | ||
| search_tools | ||
| translator | ||
| workers | ||
| add_date_fields_to_marc_records.pl | ||
| add_statistics_borrowers_categorycode.pl | ||
| batchCompareMARCvsFrameworks.pl | ||
| batchdeletebiblios.pl | ||
| batchDeleteUnusedSubfields.pl | ||
| batchImportMARCWithBiblionumbers.pl | ||
| batchRebuildBiblioTables.pl | ||
| batchRebuildItemsTables.pl | ||
| batchRepairMissingBiblionumbers.pl | ||
| check_sysprefs.pl | ||
| commit_file.pl | ||
| export_borrowers.pl | ||
| export_records.pl | ||
| exportauth.pl | ||
| import_patrons.pl | ||
| koha-install-log | ||
| link_bibs_to_authorities.pl | ||
| load_yaml.pl | ||
| mod_zebraqueue.pl | ||
| perlmodule_ls.pl | ||
| perlmodule_rm.pl | ||
| process_ill_updates.pl | ||
| recreateIssueStatistics.pl | ||
| sax_parser_print.pl | ||
| sax_parser_test.pl | ||
| sip_cli_emulator.pl | ||
| stage_file.pl | ||
| z3950_responder.pl | ||
