b168f4a2e9
This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes almost all perlcrictic violations according to this .perlcriticrc The remaining violations are silenced out by appending a '## no critic' to the offending lines. They can still be seen by using the --force option of perlcritic This patch also modify t/00-testcritic.t to check all Perl files using the new .perlcriticrc. I'm not sure if this test script is still useful as it is now equivalent to `perlcritic --quiet .` and it looks like it is much slower (approximatively 5 times slower on my machine) Test plan: 1. Run `perlcritic --quiet .` from the root directory. It should output nothing 2. Run `perlcritic --quiet --force .`. It should output 7 errors (6 StringyEval, 1 BarewordFileHandles) 3. Run `TEST_QA=1 prove t/00-testcritic.t` 4. Read the patch. Check that all changes make sense and do not introduce undesired behaviour Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
61 lines
1.9 KiB
Perl
61 lines
1.9 KiB
Perl
#!/usr/bin/perl
|
|
|
|
# Copyright 2013 Equinox Software, Inc.
|
|
# Copyright 2014 BibLibre
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it under the
|
|
# terms of the GNU General Public License as published by the Free Software
|
|
# Foundation; either version 3 of the License, or (at your option) any later
|
|
# version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
|
|
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along
|
|
# with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
use Test::More tests => 4;
|
|
use Test::MockModule;
|
|
use CGI qw ( -utf8 );
|
|
use Koha::Cache::Memory::Lite;
|
|
|
|
BEGIN {
|
|
use_ok('C4::Languages');
|
|
}
|
|
|
|
my @languages = (); # stores the list of active languages
|
|
# for the syspref mock
|
|
my $return_undef = 0;
|
|
|
|
my $module_context = new Test::MockModule('C4::Context');
|
|
|
|
$module_context->mock(
|
|
preference => sub {
|
|
my ($self, $pref) = @_;
|
|
if ($return_undef) {
|
|
return;
|
|
} elsif ($pref =~ /language/) {
|
|
return join ',', @languages;
|
|
} else {
|
|
return 'XXX';
|
|
}
|
|
},
|
|
);
|
|
|
|
delete $ENV{HTTP_ACCEPT_LANGUAGE};
|
|
|
|
my $query = CGI->new();
|
|
@languages = ('de-DE', 'fr-FR');
|
|
is(C4::Languages::getlanguage($query), 'de-DE', 'default to first language specified in syspref (bug 10560)');
|
|
|
|
Koha::Cache::Memory::Lite->get_instance()->clear_from_cache('getlanguage');
|
|
@languages = ();
|
|
is(C4::Languages::getlanguage($query), 'en', 'default to English if no language specified in syspref (bug 10560)');
|
|
|
|
Koha::Cache::Memory::Lite->get_instance()->clear_from_cache('getlanguage');
|
|
$return_undef = 1;
|
|
is(C4::Languages::getlanguage($query), 'en', 'default to English if no database');
|