Jonathan Druart
02e2a4261c
Ready for an archaeology course? C4::Circulation::GetItemIssues is only used once, from catalogue/issuehistory.pl This call has been added by commit95d6452462Adding some more information on issuehistory. which says "Adding itemnumber to issuehistory.pl API so that one could search for issuehistory of a specific item." So it added the ability to see the item issue history but did not provide a way to access it via the interface. It's ok so far but this subroutine is broken since commitaa114f5349Bug 5549 : Only use DateTime for issues table because of this change: - my $today = C4::Dates->today('iso'); + my $today = DateTime->now( time_zome => C4::Context->tz); I let you catch the typo ;) And since this commit the subroutine explodes with "The following parameter was passed in the call to DateTime::from_epoch but was not listed in the validation options: time_zome" Since it has never been raised by someone and that the feature is hidden, I'd recommend to simply remove it. Note that the "Checked out from" column would have been wrong even if we fixed all the previous issue. Test plan: Just dig into the code and confirm what this commit message tells Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Looks fine for me. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
61 lines
1.7 KiB
Perl
Executable file
61 lines
1.7 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
|
|
use strict;
|
|
#use warnings; FIXME - Bug 2505
|
|
|
|
use CGI qw ( -utf8 );
|
|
use C4::Auth;
|
|
use C4::Output;
|
|
|
|
use C4::Circulation; # GetBiblioIssues
|
|
use C4::Biblio; # GetBiblio GetBiblioFromItemNumber
|
|
use C4::Search; # enabled_staff_search_views
|
|
|
|
my $query = new CGI;
|
|
my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "catalogue/issuehistory.tt",
|
|
query => $query,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { catalogue => 1 },
|
|
}
|
|
);
|
|
|
|
# getting cgi params.
|
|
my $params = $query->Vars;
|
|
|
|
my $biblionumber = $params->{'biblionumber'};
|
|
|
|
if (C4::Context->preference("HidePatronName")) {
|
|
$template->param(HidePatronName => 1);
|
|
}
|
|
|
|
my $issues = GetBiblioIssues($biblionumber);
|
|
my $biblio = GetBiblio($biblionumber);
|
|
$template->param(%$biblio);
|
|
|
|
$template->param(
|
|
total => scalar @$issues,
|
|
issues => $issues,
|
|
issuehistoryview => 1,
|
|
C4::Search::enabled_staff_search_views,
|
|
);
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|