Jonathan Druart
9d6d641d1f
On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. This patch is a squashed version of: Bug 17600: After export.pl Bug 17600: After perlimport Bug 17600: Manual changes Bug 17600: Other manual changes after second perlimports run Bug 17600: Fix tests And a lot of other manual changes. export.pl is a dirty script that can be found on bug 17600. "perlimport" is: git clone https://github.com/oalders/App-perlimports.git cd App-perlimports/ cpanm --installdeps . export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib" find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \; The ideas of this patch are to: * use EXPORT_OK instead of EXPORT * perltidy the EXPORT_OK list * remove '&' before the subroutine names * remove some uneeded use statements * explicitely import the subroutines we need within the controllers or modules Note that the private subroutines (starting with _) should not be exported (and not used from outside of the module except from tests). EXPORT vs EXPORT_OK (from https://www.thegeekstuff.com/2010/06/perl-exporter-examples/) """ Export allows to export the functions and variables of modules to user’s namespace using the standard import method. This way, we don’t need to create the objects for the modules to access it’s members. @EXPORT and @EXPORT_OK are the two main variables used during export operation. @EXPORT contains list of symbols (subroutines and variables) of the module to be exported into the caller namespace. @EXPORT_OK does export of symbols on demand basis. """ If this patch caused a conflict with a patch you wrote prior to its push: * Make sure you are not reintroducing a "use" statement that has been removed * "$subroutine" is not exported by the C4::$MODULE module means that you need to add the subroutine to the @EXPORT_OK list * Bareword "$subroutine" not allowed while "strict subs" means that you didn't imported the subroutine from the module: - use $MODULE qw( $subroutine list ); You can also use the fully qualified namespace: C4::$MODULE::$subroutine Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
33 lines
1.7 KiB
Raku
Executable file
33 lines
1.7 KiB
Raku
Executable file
#!/usr/bin/perl
|
|
|
|
# some simple tests of the elements of C4::External::BakerTaylor that do not require a valid username and password
|
|
|
|
use Modern::Perl;
|
|
|
|
use Test::More tests => 9;
|
|
use t::lib::Mocks;
|
|
|
|
BEGIN {
|
|
use_ok('C4::External::BakerTaylor', qw( link_url image_url content_cafe_url http_jacket_link availability ));
|
|
}
|
|
|
|
# test with mocked prefs
|
|
my $username= "testing_username";
|
|
my $password= "testing_password";
|
|
my $link_url = "http://wrongexample.com?ContentCafe.aspx?UserID=$username";
|
|
|
|
t::lib::Mocks::mock_preference( 'BakerTaylorUsername', $username );
|
|
t::lib::Mocks::mock_preference( 'BakerTaylorPassword', $password );
|
|
t::lib::Mocks::mock_preference( 'BakerTaylorBookstoreURL', $link_url );
|
|
|
|
my $image_url = "https://contentcafe2.btol.com/ContentCafe/Jacket.aspx?UserID=$username&Password=$password&Options=Y&Return=T&Type=S&Value=";
|
|
my $content_cafe = "https://contentcafe2.btol.com/ContentCafeClient/ContentCafe.aspx?UserID=$username&Password=$password&Options=Y&ItemKey=";
|
|
|
|
is( C4::External::BakerTaylor::image_url(), $image_url, "testing default image url");
|
|
is( C4::External::BakerTaylor::image_url("aa"), $image_url."aa", "testing image url construction");
|
|
is( C4::External::BakerTaylor::link_url(), $link_url, "testing default link url");
|
|
is( C4::External::BakerTaylor::link_url("bb"), "${link_url}bb", "testing link url construction");
|
|
is( C4::External::BakerTaylor::content_cafe_url(""), $content_cafe, "testing default content cafe url");
|
|
is( C4::External::BakerTaylor::content_cafe_url("cc"), "${content_cafe}cc", "testing content cafe url construction");
|
|
is( C4::External::BakerTaylor::http_jacket_link(""), undef, "testing empty http jacket link");
|
|
is( C4::External::BakerTaylor::availability(""), undef, "testing empty availability");
|