3dc883a1cc
When registering a phone number for SMS alerts, the number goes through
a regex filter to make sure the number is valid. One of the formats used
in Europe is 00 AAA XXXXXXXXX (A = country indicator) and it is not
supported.
This patch adjusts the regex to either accept 00 AAA XXXXXXXXX or
+AAAXXXXXXXXX in this case. (Note : +AAA and 00AAA are mutually exclusive).
To test:
1) You need to have installed a SMSAlert plugin. Make sure the
SMSSendDriver syspref is also set up with your SMS plugin of choice.
2) Pick a patron and edit its profile.
3) In the messaging preferences fieldset, under SMS number, enter any
number with the format 00 AAA XXXXXXXXX (ie : 00111123456789).
Try to save the modification : you should have an error message.
4) Try instead a number with the format +AAAXXXXXXXXX (ie :
111123456789), that one should be accepted.
5) Save your modification then check that the number has been changed.
6) Apply patch.
7) Repeat step 3 to 5.
8) Observe the error is gone.
9) Try it once more with the format +00 AAA XXXXXXXXX (+00111123456789),
that format should not be accepted: this is intentional.
10) Sign off.
Thanks-to: Didier Gautheron <didier.gautheron@biblibre.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
|
||
|---|---|---|
| .. | ||
| pages | ||
| acq.js | ||
| acquisitions-menu.js | ||
| additem.js | ||
| addorderiso2709.js | ||
| admin-menu.js | ||
| ajax.js | ||
| audio_alerts.js | ||
| auth-finder-search.js | ||
| authorities-detail-modal.js | ||
| authtype.js | ||
| automatic_item_modification_by_age.js | ||
| background-job-progressbar.js | ||
| basket.js | ||
| basketgroup.js | ||
| biblio_framework.js | ||
| browser.js | ||
| calendar.js | ||
| cart.js | ||
| cashup_modal.js | ||
| catalog.js | ||
| cataloging.js | ||
| cataloging_additem.js | ||
| categories.js | ||
| charts.js | ||
| checkouts.js | ||
| datatables.js | ||
| desk_selection.js | ||
| elasticsearch-mappings.js | ||
| file-upload.js | ||
| funds_sorts.js | ||
| holds.js | ||
| ill-availability-partner.js | ||
| ill-availability.js | ||
| ill-list-table.js | ||
| item_search_fields.js | ||
| letter.js | ||
| localcovers.js | ||
| mana.js | ||
| marc_modification_templates.js | ||
| marc_subfields_structure.js | ||
| members-menu.js | ||
| members.js | ||
| merge-record.js | ||
| messaging-preference-form.js | ||
| offlinecirc.js | ||
| onboarding.js | ||
| patron-webcam.js | ||
| recalls.js | ||
| register_selection.js | ||
| resolve_claim_modal.js | ||
| rotating-collections.js | ||
| select2.js | ||
| serials-toolbar.js | ||
| showpredictionpattern.js | ||
| sms_providers.js | ||
| staff-global.js | ||
| subscription-add.js | ||
| table_filters.js | ||
| tools-menu.js | ||
| upload-images.js | ||
| viewlog.js | ||
| xmlControlfield.js | ||
| z3950_search.js | ||