Koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/sms_providers.tt
Julian Maurice ed7543287b Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere
Having to write [% KOHA_VERSION %] for each url is bad because:
- It's easily forgettable when adding new <script> or <link>
- It prevents grep'ing for the full filename
- It violates the DRY principle
- If at some point we want to change the "force js and css reload"
  mechanism, it will be tedious

This patch:
- adds a Template::Toolkit plugin that generates <script> and
  <link> tags for JS and CSS files, and inserts automatically the Koha
  version in the filename
- use the new plugin to remove all occurences of [% KOHA_VERSION %]
- remove the code that was adding KOHA_VERSION as a template variable

Test plan:
1. Apply patch
2. Go to several different pages in Koha (opac and intranet) while
   checking your browser's dev tools (there should be no 404 for JS and
   CSS files, and the Koha version should appear in filenames) and the
   server logs (there should be no "File not found")
3. `git grep KOHA_VERSION` should return nothing
4. prove t/db_dependent/Koha/Template/Plugin/Asset.t

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2018-04-13 11:49:44 -03:00

109 lines
4.9 KiB
Text

[% USE Asset %]
[% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %]
<title>Koha &rsaquo; Administration &rsaquo; SMS cellular providers</title>
[% INCLUDE 'doc-head-close.inc' %]
</head>
<body id="admin_sms_providers" class="admin">
[% INCLUDE 'header.inc' %]
[% INCLUDE 'prefs-admin-search.inc' %]
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> &rsaquo; SMS cellular providers</div>
<div id="doc3" class="yui-t2">
<div id="bd">
<div id="yui-main">
<div class="yui-b">
<div id="toolbar" class="btn-toolbar">
<a class="btn btn-default btn-sm" id="new_provider" href="#"><i class="fa fa-plus"></i> New SMS provider</a>
</div>
<h2>SMS cellular providers</h2>
[% IF providers.size %]
<table id="providerst">
<thead>
<tr>
<th>Name</th>
<th>Domain</th>
<th title="Patrons using this provider">Patrons</th>
<th>&nbsp;</th>
</tr>
</thead>
<tbody>
[% FOREACH p IN providers %]
<tr>
<td id="name_[% p.id %]">[% p.name %]</td>
<td id="domain_[% p.id %]">[% p.domain %]</td>
<td id="patrons_using_[% p.id %]">[% p.patrons_using %]</td>
<td class="actions">
<a class="btn btn-default btn-xs edit" href="#" id="edit_[% p.id %]" data-providerid="[% p.id %]">
<i class="fa fa-pencil"></i> Edit
</a>
<a class="btn btn-default btn-xs delete" href="#" data-providerid="[% p.id %]" data-patrons_using="[% p.patrons_using %]" id="delete_[% p.id %]">
<i class="fa fa-trash"></i> Delete
</a>
</td>
</tr>
[% END %]
</tbody>
</table>
[% ELSE %]
<div class="dialog message">
There are no SMS cellular providers defined.
</div>
[% END %]
<div id="sms_add_form">
<form id="sms_form" action="sms_providers.pl" method="post" class="validated">
<fieldset class="rows">
<legend>Add an SMS cellular provider</legend>
<input type="hidden" id="id" name="id" value="" />
<input type="hidden" id="op" name="op" value="add_update" />
<ol>
<li>
<label for="name" class="required">Name: </label>
<input type="text" id="name" name="name" required="required" />
<span class="required">Required</span>
</li>
<li>
<label for="domain" class="required">Domain: </label>
<input type="text" id="domain" name="domain" required="required" size="40"/>
<span class="required">Required</span>
</li>
</ol>
</fieldset>
<fieldset class="action">
<input type="submit" id="submit_save" value="Submit" />
<input type="submit" value="Submit" id="submit_update" />
<a class="cancel cancel_edit" id="cancel" href="sms_providers.pl">Cancel</a>
</fieldset>
</form>
</div>
</div>
</div>
<div class="yui-b">
[% INCLUDE 'admin-menu.inc' %]
</div>
</div>
</div>
[% MACRO jsinclude BLOCK %]
[% Asset.js("js/admin-menu.js") %]
<script type="text/javascript">
var MSG_SMS_PATRONS_USING = _("Are you sure you want to delete %s? %s patron(s) are using it!");
var MSG_SMS_DELETE_CONFIRM = _("Are you sure you want to delete %s?");
var LABEL_SMS_ADD_PROVIDER = _("Add an SMS cellular provider");
var LABEL_SMS_EDIT_PROVIDER = _("Edit provider %s");
</script>
[% Asset.js("js/sms_providers.js") %]
[% END %]
[% INCLUDE 'intranet-bottom.inc' %]