Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Agustin Moyano a998ba5714
Bug 22284: Control hold groups in C4::Reserves 
This patch modifies C4::Reserves to control when hold group options where selected
in smart rules.
In CanItemBeReserved adds 2 new error status messages
1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group
2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group
Also CheckReserves is modified when item's priority is defined, to control by hold
group when required.
Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when
required.

To test:
1) Apply this patch
2) prove t/db_dependent/Holds.t
SUCCESS => Result: PASS
3) Sign off

Sponsored-by: VOKAL
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2020-01-03 12:58:03 +00:00
..
Acquisition Bug 23523: unitprice tax column values are not populated if entered upon ordering 2019-11-05 08:11:29 +00:00
api/v1 Bug 24232: Regression tests 2019-12-20 12:07:09 +00:00
Auth Bug 20128: (QA follow-up) Corrections to haspermission 2019-04-17 12:25:26 +00:00
Authority Bug 14769: Put ControlledIndicators to work 2018-04-12 10:50:35 -03:00
Biblio Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls 2019-07-15 11:28:08 +01:00
Circulation Bug 24138: Fix calculation of suspension days when a limit is set 2019-12-10 16:14:50 +00:00
CourseReserves Bug 22142: Do not revert data if 'unchanged' was set 2019-08-13 11:22:13 +01:00
Creators Bug 21281: (QA follow-up) Introduce _add_backtics 2018-09-26 15:22:57 +00:00
cronjobs Bug 24268: Unit tests 2019-12-20 12:05:47 +00:00
data Bug 11677: Use zebra not-onloan-count index for availability limit 2019-08-20 15:00:16 +01:00
Exporter Bug 22155: Adapt uses of biblio_metadata.marcflavour to schema 2019-01-30 11:35:34 +00:00
Holds Bug 18928: Update new occurrences 2019-07-01 14:57:10 +01:00
Illrequest Bug 20750: Add unit tests 2019-03-15 19:07:08 +00:00
Items Bug 24030: Remove OldWay comparaison from GetItemsForInventory.t 2019-11-13 13:25:24 +00:00
Koha Bug 21684: Adjust some tests 2020-01-03 10:58:51 +00:00
Labels Bug 21798: replace gimme_a_biblio with build_sample_biblio 2019-01-28 18:53:28 +00:00
LDAP
Letters Bug 23765: Do not display localized templates if TranslateNotices is off 2019-11-13 13:36:45 +00:00
Members Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
OAI Bug 22155: Adapt uses of biblio_metadata.marcflavour to schema 2019-01-30 11:35:34 +00:00
Patron Bug 14570: Make it possible to add multiple guarantors to a record 2019-08-20 16:04:48 +01:00
Record Bug 24029: Remove "Truncated incorrect DOUBLE value: '01e'" from marcrecord2csv.t 2019-11-13 13:22:11 +00:00
Reports Bug 24164: Unit test 2019-12-13 14:00:03 +00:00
Reserves Bug 21181: Unit tests 2019-07-05 08:39:09 +01:00
Search Bug 22048: Use set_password in tests 2019-01-25 20:15:31 +00:00
selenium Bug 23903: (QA follow-up) Fix selenium tests 2019-11-04 11:04:51 +00:00
Serials Bug 7047: (QA follow-up) Fix tests 2019-12-23 12:07:15 +00:00
SIP Bug 24175: Simplify tests 2019-12-23 10:56:46 +00:00
Template/Plugin Bug 21824: Add KohaDates method 'output_preference' to make it easy to store formatted dates in TT variable 2019-11-01 08:52:09 +00:00
Utils Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
www Bug 24144: (bug 23836 follow-up) Fix regressions.t tests 2019-12-02 17:13:27 +00:00
XSLT_Handler
00-strict.t Bug 19817: Remove local help files + edit help feature 2018-09-06 17:32:27 +00:00
01-test_dbic.t
Accounts.t Bug 23181: Extend unit tests 2019-11-04 14:20:26 +00:00
Acquisition.t Bug 14669: Add search option for managing library to orders search 2019-10-08 14:04:48 +01:00
Amazon.t
ArticleRequests.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
AudioAlerts.t
Auth.t Bug 24145: (bug 22543 follow-up) Fix Auth.t 2019-12-02 17:13:27 +00:00
Auth_with_cas.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Auth_with_ldap.t Bug 18947: LDAP - do not assume anonymous bind if no user or password 2018-08-20 14:40:13 +00:00
AuthorisedValues.t Bug 23272: Adapt controller and tests 2019-09-13 08:04:15 +01:00
AuthoritiesMarc.t
BackgroundJob.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Barcodes.t
Barcodes_ValueBuilder.t Bug 21937: Add test to show autoBarcode annual increment bug 2019-04-19 14:32:17 +00:00
Biblio.t Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
Bookseller.t Bug 21817: Fix 2 failing tests 2019-01-02 20:18:30 +00:00
Breeding.t Bug 24267: (QA follow-up) Remove two calls, add transaction 2020-01-02 14:04:45 +00:00
Budgets.t Bug 10577: Improve semantics of GetBudgetPeriod() 2019-03-28 12:46:14 +00:00
Cache.t Bug 22808: Move Cache.t to db_dependent 2019-05-07 10:50:00 +00:00
Calendar.t
Charset.t Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls 2019-07-15 11:28:08 +01:00
check_kohastructure.t
check_sysprefs.t
Circulation.t Bug 24075: Unit tests 2019-11-22 15:08:28 +00:00
Clubs.t
ColumnsSettings.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Context.t
Contract.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
CourseReserves.t Bug 21603: Remove incorrect GROUP BY from C4::CourseReserves 2018-10-26 16:33:14 +00:00
db_structure.t
DecreaseLoanHighHolds.t Bug 22493: Clean up DecreaseLoanHighHolds.t 2019-03-15 12:17:59 +00:00
default_search_class.pl
Filter_MARC_ViewPolicy.t Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls 2019-07-15 11:28:08 +01:00
Fines.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
FrameworkPlugin.t
Heading.t Bug 21826: Move Heading tests to db_dependent since they require database connection 2019-01-25 20:13:39 +00:00
Heading_MARC21.t
Hold.t Bug 21478: (QA follow-up) Make sure tests don't fail randomly 2019-01-28 16:06:26 +00:00
Holds.t Bug 22284: Control hold groups in C4::Reserves 2020-01-03 12:58:03 +00:00
HoldsQueue.t Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules 2019-07-01 14:56:44 +01:00
Holidays.t
Illcomments.t Bug 18591: Allow any number of comments on ILLs 2018-10-27 13:15:58 +00:00
Illrequestattributes.t
Illrequests.t Bug 22280: Add a unit test 2019-10-01 14:44:50 +01:00
ILSDI_Services.t Bug 23805: Update accounttype references in tests 2019-10-24 17:35:19 +01:00
ImportBatch.t Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls 2019-07-15 11:28:08 +01:00
ImportExportFramework.t Bug 21749: (QA follow-up) Add more tests for ImportFramework 2018-11-15 12:47:36 +00:00
Installer.t Bug 22472: Add tests 2019-04-11 13:34:09 +00:00
Items.t Bug 23233: (follow-up) Correct test description 2019-12-16 11:09:24 +00:00
Items_DelItemCheck.t Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
Koha.t
Koha_Authority.t
Koha_Database.t
Koha_Elasticsearch.t Bug 18235: (follow-up) fix tests and remove trailing space 2019-03-28 15:57:32 +00:00
Koha_ExternalContent_OverDrive.t Bug 21567: Move Koha_ExternalContent_OverDrive.t to db_dependent 2018-11-16 13:04:57 +00:00
Koha_ExternalContent_RecordedBooks.t Bug 17602: RecordedBooks Integration to Koha 2018-10-01 13:56:38 +00:00
Koha_Misc_Files.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Languages.t Bug 18213: Add language facets to Elasticsearch 2019-03-28 15:57:32 +00:00
Letters.t Bug 8000: (QA follow-up) Two lastminute fixes 2019-04-29 15:08:47 +00:00
LibraryGroups.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Linker_Default.t Bug 21450: (QA follow-up) remove a couple of unused variables to make QA script happy 2019-05-30 10:13:38 +00:00
Linker_FirstMatch.t
Log.t Bug 22917: Fix typo in another test file 2019-05-23 14:47:41 +00:00
MarcModificationTemplates.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
Members.t Bug 23579: (RM follow-up) Fix failing tests 2019-10-25 13:13:26 +01:00
MungeMarcPrice.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
NewsChannels.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Overdues.t Bug 22521: Update fines handling to use accountline.status 2019-04-17 16:49:36 +00:00
Passwordrecovery.t
Patroncards.t Bug 22878: Add tests 2019-05-15 12:10:52 +00:00
PatronLists.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
Patrons.t Bug 17168: (QA follow-up) Only remove guarantor relationship if not Child AND not Professional 2019-10-26 07:37:42 +01:00
QueryParser.t
Record.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
RecordProcessor_EmbedSeeFromHeadings.t
RefundLostItemFeeRule.t Bug 18930: (RM follow-up) Restore primary key find 2019-07-16 13:53:54 +01:00
Reports.t
Reserves.t Bug 23964: (follow-up) We should check for only active holds when determining to set waiting 2019-11-25 16:38:16 +00:00
rollingloans.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
RotatingCollections.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Search.t Bug 22581: (RM follow-up) Add sysprefs to Search.t 2019-11-04 10:45:19 +00:00
Serials.t Bug 23416: Add PreserveSerialNotes system preference 2019-08-12 14:35:18 +01:00
Serials_2.t Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber 2018-07-18 15:49:47 +00:00
Service.t
ShelfBrowser.t Bug 21133: Fix use statements order 2018-07-31 16:28:02 -03:00
Sitemapper.t Bug 21015: Remove unecessary 'use Koha::Schema' statements in t/ 2018-11-08 02:18:48 +00:00
Stats.t Bug 21683: (follow-up) Remove last occurences of statistics.proccode 2019-03-21 18:19:23 +00:00
StockRotationItems.t Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationRotas.t Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationStages.t Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
SuggestionEngine_ExplodedTerms.t
Suggestions.t Bug 14973: Check existing biblio when submitting a purchase suggestion (opac side) 2020-01-02 12:30:56 +00:00
sysprefs.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
Tags.t Bug 21846: Simplify ugly double for loops 2019-03-15 12:27:44 +00:00
Templates.t Bug 20727: Move temporary_directory() to C4::Context 2018-06-22 16:10:09 +00:00
TestBuilder.t Bug 24062: Make sure TestBuilder will stop generate X or other invalid category's types 2019-11-19 15:17:08 +00:00
Upload.t Bug 19633: Use alphanumeric error codes in upload 2018-08-10 10:10:46 +00:00
UsageStats.t Bug 23233: (RM follow-up) Rename syspref in test 2019-12-17 09:08:45 +00:00
Virtualshelves.t Bug 21684: Adjust some tests 2020-01-03 10:58:51 +00:00
XISBN.t Bug 22721: Remove frameworkcode parameter in GetMarcFromKohaField calls 2019-07-15 11:28:08 +01:00
XSLT.t Bug 23414: Replace delimiter of regexs to ease readability 2019-11-06 17:14:48 +00:00
XSLT_Handler.t Bug 20272: Replace error numbers by codes in XSLT_Handler 2018-07-02 12:12:48 +00:00
zebra_config.pl Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00