Koha/patroncards/edit-profile.pl
Jonathan Druart a70980d825 Bug 17900: Fix possible SQL injection in patron cards template editing
To recreate:
/cgi-bin/koha/patroncards/edit-template.pl?op=edit&element_id=23%20and%201%3d2+union+all+select+1,user(),@@version+--%20

Look at the Profile dropdown list.

To fix this problem and to make sure it does not appears anywhere else
in the label and patroncards modules, I have refactored the way the
queries are built in C4::Creators::Lib
Now all of the subroutine takes a hashref in parameters with a 'fields'
and 'filters' parameters.
From these 2 parameters the new internal subroutine _build_query will
build the query and use placeholders.

Test plan:
1/ Make sure you do not recreate the vulnerability with this patch
applied.
2/ With decent data in the labels and patroncards modules, compare all
the different view (undef the New and Manage button groups) with and
without this patch applied.
=> You should not see any differences.

This vulnerability has been reported by MDSec.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-01-30 11:19:55 +00:00

108 lines
3.8 KiB
Perl
Executable file

#!/usr/bin/perl
#
# Copyright 2006 Katipo Communications.
# Parts Copyright 2009 Foundations Bible College.
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use strict;
use warnings;
use CGI qw ( -utf8 );
use C4::Auth qw(get_template_and_user);
use C4::Output qw(output_html_with_http_headers);
use C4::Creators::Lib qw(get_all_templates get_unit_values);
use C4::Patroncards::Profile;
my $cgi = new CGI;
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
template_name => "patroncards/edit-profile.tt",
query => $cgi,
type => "intranet",
authnotrequired => 0,
flagsrequired => { catalogue => 1 },
debug => 1,
}
);
my $op = $cgi->param('op') || '';
my $profile_id = $cgi->param('profile_id') || $cgi->param('element_id');
my $profile = undef;
my $template_list = undef;
my @label_template = ();
my $units = get_unit_values();
if ($op eq 'edit') {
$profile = C4::Patroncards::Profile->retrieve(profile_id => $profile_id);
$template_list = get_all_templates({ fields => [ qw( template_id template_code profile_id ) ] });
}
elsif ($op eq 'save') {
my @params = (
printer_name => scalar $cgi->param('printer_name'),
paper_bin => scalar $cgi->param('paper_bin'),
offset_horz => scalar $cgi->param('offset_horz'),
offset_vert => scalar $cgi->param('offset_vert'),
creep_horz => scalar $cgi->param('creep_horz'),
creep_vert => scalar $cgi->param('creep_vert'),
units => scalar $cgi->param('units'),
);
if ($profile_id) { # if a label_id was passed in, this is an update to an existing layout
$profile = C4::Patroncards::Profile->retrieve(profile_id => $profile_id);
$profile->set_attr(@params);
$profile->save();
}
else { # if no label_id, this is a new layout so insert it
$profile = C4::Patroncards::Profile->new(@params);
$profile->save();
}
print $cgi->redirect("manage.pl?card_element=profile");
exit;
}
else { # if we get here, this is a new layout
$profile = C4::Patroncards::Profile->new();
}
if ($profile_id) {
@label_template = grep{($_->{'profile_id'} == $profile->get_attr('profile_id')) && ($_->{'template_id'} == $profile->get_attr('template_id'))} @$template_list;
}
foreach my $unit (@$units) {
if ($unit->{'type'} eq $profile->get_attr('units')) {
$unit->{'selected'} = 1;
}
}
# if new layout, there will be no profile id, so shouldn't look for it
if ( $profile_id && $profile->get_attr('profile_id') > 0 ) {
$template->param( profile_id => $profile->get_attr('profile_id') );
}
$template->param(
label_template => $label_template[0]->{'template_code'} || '',
printer_name => $profile->get_attr('printer_name'),
paper_bin => $profile->get_attr('paper_bin'),
offset_horz => $profile->get_attr('offset_horz'),
offset_vert => $profile->get_attr('offset_vert'),
creep_horz => $profile->get_attr('creep_horz'),
creep_vert => $profile->get_attr('creep_vert'),
units => $units,
op => $op,
);
output_html_with_http_headers $cgi, $cookie, $template->output;