Koha/Koha/Filter/MARC/EmbedItems.pm
Jonathan Druart fafcbff015 Bug 27673: Fix encoding issues
There is a difference between YAML::Load and YAML::XS::Load
From YAML::XS pod:
"YAML::XS only deals with streams of utf8 octets"

Test plan:
We are going to test 1 occurence and QA will confirm others don't
contain typos.
0. Don't apply the patches
1. Create a new itemtype with code=❤️
2. Create a new item using this itemtype (to biblionumber=1 will work)
3. Fill OpacHiddenItems with
 itype: [❤️]
4. Search for "street shuffle" or any terms that will return the biblio
Notice that the item is there (there is an error in logs)
5. Apply the patches
6. Repeat 4 and confirm that the item is now hidden

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-02-16 14:54:50 +01:00

91 lines
2.1 KiB
Perl

package Koha::Filter::MARC::EmbedItems;
# Copyright 2019 Theke Solutions
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
=head1 NAME
Koha::Filter::MARC::EmbedItems - Appends item information on MARC::Record objects.
=head1 SYNOPSIS
my $biblio = Koha::Biblios->find(
$biblio_id,
{ prefetch => [ items, metadata ] }
);
my $opachiddenitems_rules;
eval {
my $yaml = C4::Context->preference('OpacHiddenItems') . "\n\n";
$opachiddenitems_rules = YAML::XS::Load(Encode::encode_utf8($yaml));
};
my @items = grep { !$_->hidden_in_opac({ rules => $opachiddenitems_rules }) @{$biblio->items};
my $record = $biblio->metadata->record;
my $processor = Koha::RecordProcessor->new(
{
filters => ('EmbedItems'),
options => {
items => \@items
}
}
);
$processor->process( $record );
=head1 DESCRIPTION
Filter to embed items information into MARC::Record objects.
=cut
use Modern::Perl;
use C4::Biblio;
use base qw(Koha::RecordProcessor::Base);
our $NAME = 'EmbedItems';
=head2 filter
Embed items into the MARC::Record object.
=cut
sub filter {
my $self = shift;
my $record = shift;
return unless defined $record and ref($record) eq 'MARC::Record';
my $items = $self->{params}->{options}->{items};
my $mss = $self->{params}->{options}->{mss}
// C4::Biblio::GetMarcSubfieldStructure( '', { unsafe => 1 } );
my @item_fields;
foreach my $item ( @{$items} ) {
push @item_fields, $item->as_marc_field( { mss => $mss } );
}
$record->append_fields(@item_fields);
return $record;
}
1;