ed7543287b
Having to write [% KOHA_VERSION %] for each url is bad because: - It's easily forgettable when adding new <script> or <link> - It prevents grep'ing for the full filename - It violates the DRY principle - If at some point we want to change the "force js and css reload" mechanism, it will be tedious This patch: - adds a Template::Toolkit plugin that generates <script> and <link> tags for JS and CSS files, and inserts automatically the Koha version in the filename - use the new plugin to remove all occurences of [% KOHA_VERSION %] - remove the code that was adding KOHA_VERSION as a template variable Test plan: 1. Apply patch 2. Go to several different pages in Koha (opac and intranet) while checking your browser's dev tools (there should be no 404 for JS and CSS files, and the Koha version should appear in filenames) and the server logs (there should be no "File not found") 3. `git grep KOHA_VERSION` should return nothing 4. prove t/db_dependent/Koha/Template/Plugin/Asset.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
102 lines
3.2 KiB
Text
102 lines
3.2 KiB
Text
[% USE Asset %]
|
|
[% SET footerjs = 1 %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Administration › Koha to MARC mapping</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
[% Asset.css("css/datatables.css") %]
|
|
</head>
|
|
|
|
<body id="admin_koha2marclinks" class="admin">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'prefs-admin-search.inc' %]
|
|
|
|
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> › <a href="/cgi-bin/koha/admin/koha2marclinks.pl">Koha to MARC Mapping</a></div>
|
|
|
|
<div id="doc3" class="yui-t2">
|
|
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
<div class="yui-b">
|
|
|
|
<h1>Koha to MARC mapping</h1>
|
|
<br/>
|
|
<form action="/cgi-bin/koha/admin/koha2marclinks.pl" method="post" id="koha2marc">
|
|
|
|
[% IF error_add %]
|
|
<div class="dialog alert">Failed to add mapping for [% error_info %]</div>
|
|
[% END %]
|
|
|
|
<table id="kohafields">
|
|
<thead><tr>
|
|
<th>Koha field</th>
|
|
<th>Tag</th>
|
|
<th>Subfield</th>
|
|
<th>Lib</th>
|
|
<th> </th>
|
|
</tr></thead>
|
|
<tbody>
|
|
[% FOREACH loo IN loop %]
|
|
<tr>
|
|
<td>[% loo.kohafield %]</td>
|
|
<td>[% loo.tagfield %]</td>
|
|
<td>[% loo.tagsubfield %]</td>
|
|
<td>[% loo.liblibrarian %]</td>
|
|
<td class="actions">
|
|
[% IF !loo.readonly %]
|
|
<a onclick="AddFld('[% loo.kohafield %]');" class="btn btn-default btn-xs"><i class="fa fa-plus"></i> Add</a>
|
|
[% IF loo.tagfield %] <a onclick="RemFld('[% loo.tagfield %]','[% loo.tagsubfield %]');" class="btn btn-default btn-xs"><i class="fa fa-remove"></i> Remove</a> [% END %]
|
|
[% END %]
|
|
</td>
|
|
</td>
|
|
</tr>
|
|
[% END %]
|
|
</tbody>
|
|
</table>
|
|
|
|
<input id="remove_field" name="remove_field" type="hidden" value=""/>
|
|
<input id="add_field" name="add_field" type="hidden" value=""/>
|
|
|
|
</form>
|
|
|
|
</div>
|
|
</div>
|
|
|
|
<div class="yui-b">
|
|
[% INCLUDE 'admin-menu.inc' %]
|
|
</div>
|
|
|
|
</div>
|
|
|
|
[% MACRO jsinclude BLOCK %]
|
|
[% INCLUDE 'datatables.inc' %]
|
|
[% Asset.js("js/admin-menu.js") %]
|
|
<script type="text/javascript">
|
|
function AddFld(kohafield) {
|
|
var fieldstr = prompt( _("Adding a mapping for: %s.").format(kohafield) + "\n" + _("Please enter field tag and subfield code, separated by a comma. (For control fields: add '@' as subfield code.)\nThe change will be applied immediately.") );
|
|
var temp = fieldstr.split(',');
|
|
if( temp.length == 2 ) {
|
|
$('#add_field').val( kohafield+','+fieldstr );
|
|
$('#koha2marc').submit();
|
|
} else {
|
|
alert( _("Invalid input. Enter something like: 245,a") );
|
|
}
|
|
}
|
|
|
|
function RemFld(tagfield, subfield ) {
|
|
if( confirm( _("Mapping will be removed for: %s.").format(tagfield + subfield) + "\n" + _("The change will be applied immediately." ))) {
|
|
$('#remove_field').val(tagfield+','+subfield);
|
|
$('#koha2marc').submit();
|
|
}
|
|
}
|
|
$(document).ready(function() {
|
|
$("#kohafields").dataTable($.extend(true, {}, dataTablesDefaults, {
|
|
"aoColumnDefs": [
|
|
{ "aTargets": [ -1 ], "bSortable": false, "bSearchable": false },
|
|
],
|
|
"paging": false
|
|
} ));
|
|
|
|
});
|
|
</script>
|
|
[% END %]
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|