Nick Clemens
acb0fdb688
This fixes an issue in the way we calculate the check for hold policy 'from_home_library'
Currently we change the comparison based on ReservesControlBranch, however, that should
only control the rule we fetch, not how we compare
When ReservesControlBranch is set to "patron's home library" we compare the patron's branch to
the patron's branch, this is useless and means we pass the check for all branches all of the time
We should instead compare the patron's branch to the item's branch, and only fetch the rule using ReservesControlBranch
To test:
1 - Have a record with an item from library A and library B
2 - Set the 'Default checkout, hold and return policy'->Hold policy->From home library for all libraries
and ensure you have no branch specific/itemtype specific rules set
3 - Attempt to place a hold on the record for a patron from library B
4 - Note that only the library B item is holdable - place a title level hold (do not choose an item)
5 - Check in the item from library A
6 - It fills the hold - This is incorrect - ignore the hold
7 - Apply patch
8 - Restart all the things
9 - Check in the item from library A
10 - No hold found
11 - Check in the item from library B
12 - Hold found, correctly
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Bug 28503: Clarify what ReservesControlBranch controls
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
|
||
|---|---|---|
| .. | ||
| preferences | ||
| searchengine/elasticsearch | ||
| additional-fields.tt | ||
| admin-home.tt | ||
| adveditorshortcuts.tt | ||
| aqbudgetperiods.tt | ||
| aqbudgets.tt | ||
| aqcontract.tt | ||
| aqplan.tt | ||
| audio_alerts.tt | ||
| auth_subfields_structure.tt | ||
| auth_tag_structure.tt | ||
| authorised_values.tt | ||
| authtypes.tt | ||
| background_jobs.tt | ||
| biblio_framework.tt | ||
| branch_transfer_limits.tt | ||
| branches.tt | ||
| cash_registers.tt | ||
| categories.tt | ||
| checkmarc.tt | ||
| cities.tt | ||
| classsources.tt | ||
| clone-rules.tt | ||
| columns_settings.tt | ||
| credit_types.tt | ||
| currency.tt | ||
| debit_types.tt | ||
| desks.tt | ||
| didyoumean.tt | ||
| edi_accounts.tt | ||
| edi_ean_accounts.tt | ||
| item_circulation_alerts.tt | ||
| items_search_field.tt | ||
| items_search_fields.tt | ||
| itemtypes.tt | ||
| koha2marclinks.tt | ||
| library_groups.tt | ||
| localization.tt | ||
| marc_subfields_structure.tt | ||
| marctagstructure.tt | ||
| matching-rules.tt | ||
| oai_set_mappings.tt | ||
| oai_sets.tt | ||
| overdrive.tt | ||
| patron-attr-types.tt | ||
| preferences.tt | ||
| share_content.tt | ||
| smart-rules.tt | ||
| sms_providers.tt | ||
| smtp_servers.tt | ||
| sru_modmapping.tt | ||
| sru_modmapping_auth.tt | ||
| systempreferences.tt | ||
| transfer_limits.tt | ||
| transport-cost-matrix.tt | ||
| usage_statistics.tt | ||
| z3950servers.tt | ||