Koha/opac
Jonathan Druart ae02cf97e4 Bug 19366: Do not block patron's detail update if EmailMustBeUnique
If the pref PatronSelfRegistrationEmailMustBeUnique is set ("consider"),
a patron is not allowed to register with an existing email address.
The existing code is wrong and reject a patron that is updating their
personal details with "This email address already exists in our
database.", even if the patron did not modify their email address.

This is caused by the query we made, we must search for patron with this
email address but who is not the current patron.

Test plan:
- Set PatronSelfRegistrationEmailMustBeUnique to "consider"
- Register a new patron with an existing email address
=> you should not be allowed
- Use a non-existent email address
=> You should be allowed
- Edit your patron details
- Modify some infos
=> Should pass
- Modify your email address with an existing one
=> You should not be allowed to do that

Followed test plan, patches worked as described
Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-09-29 12:36:59 -03:00
..
clubs Bug 12461 - Add patron clubs feature 2017-04-28 08:37:44 -04:00
errors
external/overdrive
rss
sco Bug 12691: Use Koha.Preference in Self-Checkout 2017-09-07 14:03:45 -03:00
svc Bug 16892: Address error checking in comment #47 2017-08-25 10:51:25 -03:00
ilsdi.pl
maintenance.pl
oai.pl
opac-account-pay-paypal-return.pl Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
opac-account-pay-return.pl Bug 19173: Make OPAC online payments pluggable 2017-09-19 14:15:52 -03:00
opac-account-pay.pl Bug 19173: Make OPAC online payments pluggable 2017-09-19 14:15:52 -03:00
opac-account.pl Bug 19173: Add opac payment and marc conversion plugins to the pulldown filter list 2017-09-19 14:15:52 -03:00
opac-addbybiblionumber.pl Bug 18262: Koha::Biblio - Remove GetBiblioData - part 1 2017-07-14 12:22:23 -03:00
opac-alert-subscribe.pl Bug 10357: Do not change the alerttype 2017-04-21 10:58:33 -04:00
opac-article-request-cancel.pl
opac-authorities-home.pl Bug 18204 - Authority searches are not saved in Search history 2017-05-28 22:12:01 -04:00
opac-authoritiesdetail.pl Bug 18149: Move CountUsage calls to Koha namespace 2017-09-19 11:47:32 -03:00
opac-basket.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-blocked.pl
opac-browser.pl Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes 2017-07-05 13:42:21 -03:00
opac-changelanguage.pl Bug 18946 [QA Followup] - code cleanup 2017-09-01 13:02:26 -03:00
opac-course-details.pl
opac-course-reserves.pl
opac-detail.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-discharge.pl Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
opac-downloadcart.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-downloadshelf.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-export.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-ics.pl
opac-idref.pl
opac-image.pl
opac-imageviewer.pl Bug 18260: Koha::Biblio - Remove GetBiblio 2017-07-10 13:03:38 -03:00
opac-ISBDdetail.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-issue-note.pl Bug 18938: (bug 17829 follow-up) Replace 2 occurrences of GetMember left behind 2017-07-14 12:19:13 -03:00
opac-main.pl
opac-MARCdetail.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-memberentry.pl Bug 19366: Do not block patron's detail update if EmailMustBeUnique 2017-09-29 12:36:59 -03:00
opac-messaging.pl Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
opac-modrequest-suspend.pl
opac-modrequest.pl Bug 19059: Move C4::Reserves::CancelReserve to Koha::Hold->cancel 2017-09-12 12:42:58 -03:00
opac-mymessages.pl
opac-news-rss.pl
opac-overdrive-search.pl Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
opac-passwd.pl Bug 17829: (followup) Fix small rebasing errors 2017-07-10 13:14:34 -03:00
opac-password-recovery.pl Bug 18616 - The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username 2017-07-06 14:52:53 -03:00
opac-patron-image.pl
opac-privacy.pl
opac-ratings-ajax.pl
opac-ratings.pl
opac-readingrecord.pl Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
opac-registration-verify.pl Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
opac-renew.pl Bug 18572 - QA Followup 2017-07-24 13:38:31 -03:00
opac-request-article.pl
opac-reserve.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-restrictedpage.pl
opac-retrieve-file.pl
opac-review.pl Bug 18262: Koha::Biblio - Remove GetBiblioData - part 1 2017-07-14 12:22:23 -03:00
opac-search-history.pl BUG 18505: opac-search-history does not respect opacPublic 2017-05-08 10:16:20 -04:00
opac-search.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-sendbasket.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-sendshelf.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-serial-issues.pl Bug 10357: Do not change the alerttype 2017-04-21 10:58:33 -04:00
opac-shareshelf.pl Bug 17762: Send lang to GetPreparedLetter 2017-05-09 20:56:41 +00:00
opac-shelves.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-showmarc.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-showreviews.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-suggestions.pl Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
opac-tags.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-tags_subject.pl Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes 2017-07-05 13:42:21 -03:00
opac-topissues.pl Bug 17835: Replace GetItemTypes with Koha::ItemTypes 2017-04-14 10:43:51 -04:00
opac-user.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
tracklinks.pl
unapi Bug 17797: Add XSLT_Handler in opac/unapi 2017-09-01 13:00:06 -03:00