Jonathan Druart
9d6d641d1f
On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. This patch is a squashed version of: Bug 17600: After export.pl Bug 17600: After perlimport Bug 17600: Manual changes Bug 17600: Other manual changes after second perlimports run Bug 17600: Fix tests And a lot of other manual changes. export.pl is a dirty script that can be found on bug 17600. "perlimport" is: git clone https://github.com/oalders/App-perlimports.git cd App-perlimports/ cpanm --installdeps . export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib" find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \; The ideas of this patch are to: * use EXPORT_OK instead of EXPORT * perltidy the EXPORT_OK list * remove '&' before the subroutine names * remove some uneeded use statements * explicitely import the subroutines we need within the controllers or modules Note that the private subroutines (starting with _) should not be exported (and not used from outside of the module except from tests). EXPORT vs EXPORT_OK (from https://www.thegeekstuff.com/2010/06/perl-exporter-examples/) """ Export allows to export the functions and variables of modules to user’s namespace using the standard import method. This way, we don’t need to create the objects for the modules to access it’s members. @EXPORT and @EXPORT_OK are the two main variables used during export operation. @EXPORT contains list of symbols (subroutines and variables) of the module to be exported into the caller namespace. @EXPORT_OK does export of symbols on demand basis. """ If this patch caused a conflict with a patch you wrote prior to its push: * Make sure you are not reintroducing a "use" statement that has been removed * "$subroutine" is not exported by the C4::$MODULE module means that you need to add the subroutine to the @EXPORT_OK list * Bareword "$subroutine" not allowed while "strict subs" means that you didn't imported the subroutine from the module: - use $MODULE qw( $subroutine list ); You can also use the fully qualified namespace: C4::$MODULE::$subroutine Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
288 lines
6.7 KiB
Perl
288 lines
6.7 KiB
Perl
package C4::Serials::Numberpattern;
|
|
|
|
# Copyright 2011-2013 Biblibre SARL
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use strict;
|
|
use warnings;
|
|
|
|
use C4::Context;
|
|
|
|
use vars qw(@ISA @EXPORT);
|
|
|
|
BEGIN {
|
|
|
|
require Exporter;
|
|
@ISA = qw(Exporter);
|
|
@EXPORT = qw(
|
|
GetSubscriptionNumberpatterns
|
|
GetSubscriptionNumberpattern
|
|
GetSubscriptionNumberpatternByName
|
|
AddSubscriptionNumberpattern
|
|
ModSubscriptionNumberpattern
|
|
DelSubscriptionNumberpattern
|
|
|
|
GetSubscriptionsWithNumberpattern
|
|
);
|
|
}
|
|
|
|
|
|
=head1 NAME
|
|
|
|
C4::Serials::Numberpattern - Serials numbering pattern module
|
|
|
|
=head1 FUNCTIONS
|
|
|
|
=head2 GetSubscriptionNumberpatterns
|
|
|
|
@results = GetSubscriptionNumberpatterns;
|
|
this function get all subscription number patterns entered in table
|
|
|
|
=cut
|
|
|
|
sub GetSubscriptionNumberpatterns {
|
|
my $dbh = C4::Context->dbh;
|
|
my $query = qq{
|
|
SELECT *
|
|
FROM subscription_numberpatterns
|
|
ORDER by displayorder
|
|
};
|
|
my $sth = $dbh->prepare($query);
|
|
$sth->execute;
|
|
my $results = $sth->fetchall_arrayref({});
|
|
|
|
return @$results;
|
|
}
|
|
|
|
=head2 GetSubscriptionNumberpattern
|
|
|
|
$result = GetSubscriptionNumberpattern($numberpatternid);
|
|
this function get the data of the subscription numberpatterns which id is $numberpatternid
|
|
|
|
=cut
|
|
|
|
sub GetSubscriptionNumberpattern {
|
|
my $numberpatternid = shift;
|
|
my $dbh = C4::Context->dbh;
|
|
my $query = qq(
|
|
SELECT *
|
|
FROM subscription_numberpatterns
|
|
WHERE id = ?
|
|
);
|
|
my $sth = $dbh->prepare($query);
|
|
$sth->execute($numberpatternid);
|
|
|
|
return $sth->fetchrow_hashref;
|
|
}
|
|
|
|
=head2 GetSubscriptionNumberpatternByName
|
|
|
|
$result = GetSubscriptionNumberpatternByName($name);
|
|
this function get the data of the subscription numberpatterns which name is $name
|
|
|
|
=cut
|
|
|
|
sub GetSubscriptionNumberpatternByName {
|
|
my $name = shift;
|
|
my $dbh = C4::Context->dbh;
|
|
my $query = qq(
|
|
SELECT *
|
|
FROM subscription_numberpatterns
|
|
WHERE label = ?
|
|
);
|
|
my $sth = $dbh->prepare($query);
|
|
my $rv = $sth->execute($name);
|
|
|
|
return $sth->fetchrow_hashref;
|
|
}
|
|
|
|
=head2 AddSubscriptionNumberpattern
|
|
|
|
=over 4
|
|
|
|
=item C<$numberpatternid> = &AddSubscriptionNumberpattern($numberpattern)
|
|
|
|
Add a new numberpattern
|
|
|
|
=item C<$frequency> is a hashref that contains values of the number pattern
|
|
|
|
=item Only label and numberingmethod are mandatory
|
|
|
|
=back
|
|
|
|
=cut
|
|
|
|
sub AddSubscriptionNumberpattern {
|
|
my $numberpattern = shift;
|
|
|
|
unless(
|
|
ref($numberpattern) eq 'HASH'
|
|
&& defined $numberpattern->{'label'}
|
|
&& $numberpattern->{'label'} ne ''
|
|
&& defined $numberpattern->{'numberingmethod'}
|
|
&& $numberpattern->{'numberingmethod'} ne ''
|
|
) {
|
|
return;
|
|
}
|
|
|
|
# FIXME label, description and numberingmethod must be mandatory
|
|
my @keys;
|
|
my @values;
|
|
foreach (qw/ label description numberingmethod displayorder
|
|
label1 label2 label3 add1 add2 add3 every1 every2 every3
|
|
setto1 setto2 setto3 whenmorethan1 whenmorethan2 whenmorethan3
|
|
numbering1 numbering2 numbering3 /) {
|
|
if(exists $numberpattern->{$_}) {
|
|
push @keys, $_;
|
|
push @values, $numberpattern->{$_};
|
|
}
|
|
}
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
my $query = "INSERT INTO subscription_numberpatterns";
|
|
$query .= '(' . join(',', @keys) . ')';
|
|
$query .= ' VALUES (' . ('?,' x (scalar(@keys)-1)) . '?)';
|
|
my $sth = $dbh->prepare($query);
|
|
my $rv = $sth->execute(@values);
|
|
|
|
if(defined $rv) {
|
|
return $dbh->last_insert_id(undef, undef, "subscription_numberpatterns", undef);
|
|
}
|
|
|
|
return $rv;
|
|
}
|
|
|
|
=head2 ModSubscriptionNumberpattern
|
|
|
|
=over 4
|
|
|
|
=item &ModSubscriptionNumberpattern($numberpattern)
|
|
|
|
Modifies a numberpattern
|
|
|
|
=item C<$frequency> is a hashref that contains values of the number pattern
|
|
|
|
=item Only id is mandatory
|
|
|
|
=back
|
|
|
|
=cut
|
|
|
|
sub ModSubscriptionNumberpattern {
|
|
my $numberpattern = shift;
|
|
|
|
unless(
|
|
ref($numberpattern) eq 'HASH'
|
|
&& defined $numberpattern->{'id'}
|
|
&& $numberpattern->{'id'} > 0
|
|
&& (
|
|
(defined $numberpattern->{'label'}
|
|
&& $numberpattern->{'label'} ne '')
|
|
|| !defined $numberpattern->{'label'}
|
|
)
|
|
&& (
|
|
(defined $numberpattern->{'numberingmethod'}
|
|
&& $numberpattern->{'numberingmethod'} ne '')
|
|
|| !defined $numberpattern->{'numberingmethod'}
|
|
)
|
|
) {
|
|
return;
|
|
}
|
|
|
|
my @keys;
|
|
my @values;
|
|
foreach (qw/ label description numberingmethod displayorder
|
|
label1 label2 label3 add1 add2 add3 every1 every2 every3
|
|
setto1 setto2 setto3 whenmorethan1 whenmorethan2 whenmorethan3
|
|
numbering1 numbering2 numbering3 /) {
|
|
if(exists $numberpattern->{$_}) {
|
|
push @keys, $_;
|
|
push @values, $numberpattern->{$_};
|
|
}
|
|
}
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
my $query = "UPDATE subscription_numberpatterns";
|
|
$query .= ' SET ' . join(' = ?,', @keys) . ' = ?';
|
|
$query .= ' WHERE id = ?';
|
|
my $sth = $dbh->prepare($query);
|
|
|
|
return $sth->execute(@values, $numberpattern->{'id'});
|
|
}
|
|
|
|
=head2 DelSubscriptionNumberpattern
|
|
|
|
=over 4
|
|
|
|
=item &DelSubscriptionNumberpattern($numberpatternid)
|
|
|
|
Delete a number pattern
|
|
|
|
=back
|
|
|
|
=cut
|
|
|
|
sub DelSubscriptionNumberpattern {
|
|
my $numberpatternid = shift;
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
my $query = qq{
|
|
DELETE FROM subscription_numberpatterns
|
|
WHERE id = ?
|
|
};
|
|
my $sth = $dbh->prepare($query);
|
|
$sth->execute($numberpatternid);
|
|
}
|
|
|
|
=head2 GetSubscriptionsWithNumberpattern
|
|
|
|
my @subs = GetSubscriptionsWithNumberpattern($numberpatternid);
|
|
|
|
Returns all subscriptions that are using a particular numbering pattern
|
|
|
|
=cut
|
|
|
|
sub GetSubscriptionsWithNumberpattern {
|
|
my ($numberpatternid) = @_;
|
|
|
|
return unless $numberpatternid;
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
my $query = qq{
|
|
SELECT *
|
|
FROM subscription
|
|
LEFT JOIN biblio ON subscription.biblionumber = biblio.biblionumber
|
|
WHERE numberpattern = ?
|
|
};
|
|
my $sth = $dbh->prepare($query);
|
|
my @results;
|
|
if ($sth->execute($numberpatternid)) {
|
|
@results = @{ $sth->fetchall_arrayref({}) };
|
|
}
|
|
return @results;
|
|
}
|
|
|
|
|
|
1;
|
|
|
|
__END__
|
|
|
|
=head1 AUTHOR
|
|
|
|
Koha Development team <info@koha.org>
|
|
|
|
=cut
|