Jonathan Druart
018de8802d
Warning: This area is a mess, especially with date management. For the same reasons as other "Remove C4::Dates from*" patches, this one will deal with the serials module. Note that this patch add the datepicker on 3 input fields (on serials/subscription-detail.tt and serials/subscription-renew.tt). There was also weird behavior when the dates were invalid. Now default to undefined. But with the datepicker it will reduce the number of cases even if the user is still allowed to fill invalid dates. Test plan: 1/ Create a subscription, fill the first issue pub date and the subscription start date. You can fill or not the end date. Play with the numbering pattern and confirm that there are generated as before this patch. 2/ On the check expiration page, confirm that the dates are correctly displayed. 3/ Renew the subscription and confirm that the behavior is correct. 4/ Go on the subscription history page and confirm you have now the datepicker plugin set on the 2 date fields. QA notes: The startdate, histstartdate and enddate are not used in the serials-collection template, this patch removes them from the pl script. Tested on top of 15166 15168 15171, full browser reload for date pickers. Note for 4/: It is the link in tab planning on subscription detail page, near "Manual history" (if manual history is enabled). Works as advertised. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
89 lines
2.9 KiB
Perl
Executable file
89 lines
2.9 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright 2011-2013 Biblibre SARL
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
=head1 NAME
|
|
|
|
subscription-history.pl
|
|
|
|
=head1 DESCRIPTION
|
|
|
|
Modify subscription history
|
|
|
|
=cut
|
|
|
|
use Modern::Perl;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use C4::Auth;
|
|
use C4::Output;
|
|
|
|
use C4::Biblio;
|
|
use C4::Serials;
|
|
use Koha::DateUtils;
|
|
|
|
my $input = new CGI;
|
|
my ($template, $loggedinuser, $cookie, $flags) = get_template_and_user( {
|
|
template_name => 'serials/subscription-history.tt',
|
|
query => $input,
|
|
type => 'intranet',
|
|
authnotrequired => 0,
|
|
flagsrequired => { 'serials' => 'edit_subscription' },
|
|
debug => 1,
|
|
} );
|
|
|
|
my $subscriptionid = $input->param('subscriptionid');
|
|
my $op = $input->param('op');
|
|
|
|
if(!defined $subscriptionid || $subscriptionid eq '') {
|
|
print $input->redirect('/cgi-bin/koha/serials/serials-home.pl');
|
|
exit;
|
|
}
|
|
|
|
if($op && $op eq 'mod') {
|
|
my $histstartdate = $input->param('histstartdate');
|
|
my $histenddate = $input->param('histenddate');
|
|
my $receivedlist = $input->param('receivedlist');
|
|
my $missinglist = $input->param('missinglist');
|
|
my $opacnote = $input->param('opacnote');
|
|
my $librariannote = $input->param('librariannote');
|
|
|
|
$histstartdate = output_pref( { str => $histstartdate, dateonly => 1, dateformat => 'iso' } );
|
|
$histenddate = output_pref( { str => $histenddate, dateonly => 1, dateformat => 'iso' } );
|
|
|
|
ModSubscriptionHistory( $subscriptionid, $histstartdate, $histenddate, $receivedlist, $missinglist, $opacnote, $librariannote );
|
|
|
|
print $input->redirect("/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=$subscriptionid");
|
|
exit;
|
|
} else {
|
|
my $history = GetSubscriptionHistoryFromSubscriptionId($subscriptionid);
|
|
my $biblio = GetBiblio($history->{'biblionumber'});
|
|
|
|
$template->param(
|
|
subscriptionid => $subscriptionid,
|
|
title => $biblio->{'title'},
|
|
histstartdate => $history->{'histstartdate'},
|
|
histenddate => $history->{'histenddate'},
|
|
receivedlist => $history->{'recievedlist'},
|
|
missinglist => $history->{'missinglist'},
|
|
opacnote => $history->{'opacnote'},
|
|
librariannote => $history->{'librariannote'},
|
|
);
|
|
|
|
output_html_with_http_headers $input, $cookie, $template->output;
|
|
}
|