Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/koha-tmpl/intranet-tmpl/prog/en/includes
History
Jonathan Druart b0dc5fc0f3 Bug 15498: Let the user choose the CSV profile to export circ history 
The way the export options are displayed at the bottom of the checkouts table
was not consistent.
Prior to this patch set, they are display if ExportRemoveFields or
ExportWithCsvProfile is set.
It does not make any sense, the user could want to export the checkouts in
iso2709 format without having to define a csv profile and fill the pref.

Moreover the behavior of this pref did not match its description: it's used as
a default CSV profile when exporting records from the export tools or the
command line.

This patch set adds a new pref ExportCircHistory and remove
ExportWithCsvProfile. The new pref is set if ExportWithCsvProfile or
ExportRemoveFields were set.
A new dropdown list with the CSV profile list will be displayed in the
export area, at the bottom of the checkouts table.

Note that now --csv_profile_id is mandatory for the export command line
(misc/export_records.pl) if the export format is csv.

Test plan:
0/ Do not execute the DB entry
1/ Clear both ExportWithCsvProfile and ExportRemoveFields prefs
2/ Execute the DB entry
3/ ExportCircHistory should not be set and the export options should not
be displayed at the bottom of the checkouts table.
4/ Remove the pref
  DELETE FROM systempreferences WHERE variable='ExportCircHistory';
and reinsert the previous one, with a value:
  INSERT INTO systempreferences (variable, value) VALUES
  ('ExportWithCsvProfile', 'something');
Execute the DB entry again
=> The now pref should be now set
5/ Export some checkouts using the CSV entry
6/ Note that the export tool and commandline script still work using the
csv format. You have to provide a --csv_profile_id option to make it
work.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-03-31 11:13:47 +00:00
..
catalogue Bug 16914: Rely on TT for newlines 2016-12-22 20:26:54 +00:00
csv_headers Bug 13321: Csv export - Display rrp and ecost with and without taxes 2016-10-28 13:46:08 +00:00
virtualshelves/merge
acquisitions-add-to-basket.inc
acquisitions-menu.inc Bug 17972 - Reformat acquisitions sidebar menu with acquisitions and administration sections 2017-02-17 12:05:08 +00:00
acquisitions-search.inc Bug 16557 - Remove the use of "onclick" from several include files 2016-06-24 13:51:01 +00:00
acquisitions-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
additem.js.inc Bug 14752 - (QA followup) Remove annoying modal, use dialog box instead 2016-09-13 17:21:05 +00:00
admin-items-search-field-form.inc Bug 17537: Fix valid-templates.t for some include files 2016-11-04 11:03:48 +00:00
admin-menu.inc Bug 17794: Menu items in Tools menu and Admin menu not showing bold when active but not on linked page 2017-01-13 11:35:29 +00:00
adv-search.inc Bug 16549 - Remove the use of "onclick" from header search forms 2016-06-24 13:48:24 +00:00
auth-finder-search.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
authorities-search-results.inc Bug 16677 - Use abbr for authorities linked headings 2016-07-08 14:28:07 +00:00
authorities-search.inc Bug 16549 - Remove the use of "onclick" from header search forms 2016-06-24 13:48:24 +00:00
authorities-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
authorities.inc Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues 2016-02-11 19:39:53 +00:00
authorities_js.inc
av-build-dropbox.inc Bug 17847: Replace C4::Koha::GetAuthvalueDropbox with Koha::AuthorisedValues 2017-03-31 10:12:37 +00:00
biblio-default-view.inc
biblio-view-menu.inc Bug 14610 - Add and update scripts 2016-10-26 12:15:14 +00:00
blocked-fines.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
borrower_debarments.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
branch-selector.inc Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
browser-strings.inc
budgets-active-currency.inc Bug 15049: (followup) Add warning about "No active currency" 2015-12-30 23:34:34 +00:00
budgets-admin-search.inc Bug 15758: Koha::Libraries - Remove GetBranchesLoop 2016-09-08 14:36:02 +00:00
budgets-admin-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
calendar.inc Bug 17524: Fix datepicker check for iso dates 2016-11-02 10:57:48 +00:00
cat-menu.inc
cat-search.inc Bug 16903 - Multiple class attributes on catalog search tab 2016-09-02 14:03:42 +00:00
cat-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
cataloging-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
cateditor-ui.inc Bug 16239: Followup - remove unusable js from cateditor-ui.inc 2017-01-13 14:41:24 +00:00
cateditor-widgets-marc21.inc Bug 11559: (followup) Fix import bugs, display/parsing issues 2015-10-27 12:18:00 -03:00
checkin-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
checkouts-table-footer.inc Bug 15975 (QA Followup) Fix colspan for footer 2016-09-25 15:41:36 +00:00
checkouts-table.inc Bug 15498: Let the user choose the CSV profile to export circ history 2017-03-31 11:13:47 +00:00
circ-menu.inc Bug 5670: Housebound Readers Module 2016-10-21 18:17:57 +00:00
circ-nav.inc Bug 16530: Add a new method to the Branches TT Plugin to avoid c/p 2017-03-03 18:34:36 +00:00
circ-patron-search-results.inc Bug 14874 - Add ability to search for patrons by date of birth from checkout and patron quick searches 2016-10-27 13:21:13 +00:00
circ-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
cities-admin-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
columns_settings.inc Bug 15921: Do not include datatables js/css files twice 2016-03-24 15:50:02 +00:00
contracts-admin-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
country-list.inc Bug 14608: Move country list to an include file 2017-03-22 23:51:30 +00:00
currencies-admin-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
datatables.inc Bug 16242 - Move staff client JavaScript out of language directory 2016-04-29 14:32:42 +00:00
date-format.inc Bug 12072: Make datepicker and templates to be aware of dmydot format 2015-11-19 13:15:19 -03:00
doc-head-close-receipt.inc Bug 16241 - Move staff client CSS out of language directory 2016-04-29 13:54:37 +00:00
doc-head-close.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
doc-head-open.inc Bug 13948: Prevent explosion when Template::Plugin::Stash not installed 2015-07-28 10:30:21 -03:00
facets.inc Bug 17169 - Use CCODE descriptions instead of codes 2017-03-22 19:24:23 +00:00
form-blocks.inc
format_price.inc Bug 16768: (followup) Add Swiss format for datatables (format_price.inc) 2016-06-24 14:00:03 +00:00
greybox.inc Revert "Bug 8992: Use the existing greybox plugin in interface/theme" 2015-04-29 12:07:23 -03:00
guided-reports-view.inc
header.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
help-bottom.inc Bug 16557 - Remove the use of "onclick" from several include files 2016-06-24 13:51:01 +00:00
help-top.inc Bug 16553 - Incorrect path to jQueryUI file in help template 2016-05-23 17:17:16 +00:00
home-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
html_helpers.inc Bug 15803: Koha::AuthorisedValues - Remove C4::Koha::GetAuthorisedValueCategories 2016-10-28 16:35:52 +00:00
installer-doc-head-close.inc Bug 16241 - Move staff client CSS out of language directory 2016-04-29 13:54:37 +00:00
intranet-bottom.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
intranetstylesheet.inc Bug 16241 - Move staff client CSS out of language directory 2016-04-29 13:54:37 +00:00
js_includes.inc Bug 17870 - Call to include file incorrectly moved into the footer 2017-01-13 11:27:39 +00:00
labels-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
letters-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
member-alt-address-style-de.inc Bug 17559: Fixed HTML element ID of B_streetnumber 2016-11-18 14:16:43 +00:00
member-alt-address-style-us.inc Bug 17559: Fixed HTML element ID of B_streetnumber 2016-11-18 14:16:43 +00:00
member-alt-contact-style-de.inc Bug 15373: Changing Zip to ZIP on OPAC and Intranet 2015-12-30 16:30:35 +00:00
member-alt-contact-style-us.inc Bug 15373: Changing Zip to ZIP on OPAC and Intranet 2015-12-30 16:30:35 +00:00
member-display-address-style-de.inc Bug 15542: Change for the German style address format 2016-01-23 19:15:08 +00:00
member-display-address-style-us.inc Bug 16779: Move road type after address in US style address formatting (main address) 2016-07-08 13:09:55 +00:00
member-display-alt-address-style-de.inc Bug 10760: Alternate Address: Display street number and street type 2016-07-08 13:45:41 +00:00
member-display-alt-address-style-us.inc Bug 10760: (followup) Move street type after address 2016-07-08 13:45:42 +00:00
member-main-address-style-de.inc Bug 16157: Move the selected flag from GetAuthorisedValues to the templates 2016-04-07 00:16:09 +00:00
member-main-address-style-us.inc Bug 16157: Move the selected flag from GetAuthorisedValues to the templates 2016-04-07 00:16:09 +00:00
members-menu.inc Bug 5670: [QA Followup] Housebound link from patron edit. 2016-10-21 18:18:00 +00:00
members-toolbar.inc Bug 17874: Bug 16239 followup - polishing things 2017-01-13 14:42:27 +00:00
merge-record-strings.inc Bug 8064: Change the way target record is built. 2015-11-09 15:08:57 -03:00
merge-record.inc Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues 2016-02-11 19:39:53 +00:00
messaging-preference-form.inc Bug 16557 - Remove the use of "onclick" from several include files 2016-06-24 13:51:01 +00:00
nl-search-form.tt
noadd-warnings.inc Bug 17082: Translatability: Fix sentence splitting in member.tt 2016-08-10 13:49:48 +00:00
page-numbers.inc Bug 18005: Re-styled pagination on search results with Bootstrap 2017-02-07 17:48:10 +00:00
patron-article-requests.inc Bug 14610 - Follow-up 2016-10-26 12:15:23 +00:00
patron-search-box.inc Bug 17418 - Move staff client home page JavaScript to the footer 2016-12-16 11:53:39 +00:00
patron-search.inc Bug 15407: Koha::Patron::Categories - replace C4::Category->all 2016-09-08 13:29:03 +00:00
patron-title.inc Bug 17365: Fix XSS in moremember.pl and memberentry.pl 2016-10-11 16:19:56 +00:00
patron-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
patroncards-errors.inc Bug 17181: Check for duplicate image names when uploading image to patron card creator 2017-01-13 12:28:07 +00:00
patroncards-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
patrons-admin-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
permissions.inc Revert "Bug 12461 - Add patron clubs feature" 2017-02-26 20:41:27 -05:00
popup-bottom.inc
prefs-admin-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
prefs-menu.inc Bug 11559: Rancor: advanced cataloging interface 2015-10-27 12:17:39 -03:00
printers-admin-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
quotes-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
quotes-upload-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
reports-menu.inc Bug 6934: Fix code in CashRegisterStats (dataTables pagination, more accurate descriptions, add a delimiter pull down, change C4::Dates to Koha::DateUtils) 2016-10-28 11:50:24 +00:00
reports-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
resort_form.inc
rotating-collections-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
search_indexes.inc
select2.inc Bug 13501: Highlight select2 control if field is required and value is missing 2016-09-02 16:25:04 +00:00
serials-menu.inc Bug 10855: Search subscriptions by additional fields 2015-10-02 15:10:30 -03:00
serials-search.inc Bug 17025: Fix XSS in serials-search.pl 2016-08-10 13:17:19 +00:00
serials-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
slip-print.inc Revert bug 13618 - "Prevent XSS in the Staff Client and the OPAC" due to performance issues 2016-02-11 19:39:53 +00:00
strings.inc Bug 15581: Change wording for auto too late 2016-11-02 10:28:58 +00:00
subscriptions-search.inc Bug 17537: Fix valid-templates.t for some include files 2016-11-04 11:03:48 +00:00
subtypes_unimarc.inc Bug 16557 - Remove the use of "onclick" from several include files 2016-06-24 13:51:01 +00:00
suggestions-add-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
timepicker.inc
tools-item-action.inc
tools-menu.inc Revert "Bug 12461 - Add patron clubs feature" 2017-02-26 20:41:27 -05:00
tools-nomatch-action.inc
tools-overlay-action.inc
validator-strings.inc
vendor-menu.inc
virtualshelves-toolbar.inc Bug 16239: Update templates 2017-01-13 14:41:22 +00:00
wysiwyg-systempreferences.inc Bug 16241 - Move staff client CSS out of language directory 2016-04-29 13:54:37 +00:00
z3950-admin-search.inc Bug 14902 - Add qualifier menu to staff side "Search the Catalog" 2016-07-08 13:57:59 +00:00
z3950_search.inc Bug 16812: Revise JS script for z3950_search.tts and remove onclick events 2016-07-15 15:24:57 +00:00