b168f4a2e9
This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes almost all perlcrictic violations according to this .perlcriticrc The remaining violations are silenced out by appending a '## no critic' to the offending lines. They can still be seen by using the --force option of perlcritic This patch also modify t/00-testcritic.t to check all Perl files using the new .perlcriticrc. I'm not sure if this test script is still useful as it is now equivalent to `perlcritic --quiet .` and it looks like it is much slower (approximatively 5 times slower on my machine) Test plan: 1. Run `perlcritic --quiet .` from the root directory. It should output nothing 2. Run `perlcritic --quiet --force .`. It should output 7 errors (6 StringyEval, 1 BarewordFileHandles) 3. Run `TEST_QA=1 prove t/00-testcritic.t` 4. Read the patch. Check that all changes make sense and do not introduce undesired behaviour Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
59 lines
1.4 KiB
Perl
59 lines
1.4 KiB
Perl
package C4::ClassSplitRoutine::RegEx;
|
|
|
|
# Copyright 2018 Koha Development Team
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use C4::Debug;
|
|
|
|
=head1 NAME
|
|
|
|
C4::ClassSplitRoutine::RegEx - regex call number sorting key routine
|
|
|
|
=head1 SYNOPSIS
|
|
|
|
use C4::ClassSplitRoutine;
|
|
|
|
my $cn_sort = C4::ClassSplitRoutine::RegEx::split_callnumber($cn_item, $regexs);
|
|
|
|
=head1 FUNCTIONS
|
|
|
|
=head2 split_callnumber
|
|
|
|
my $cn_split = C4::ClassSplitRoutine::RegEx::split_callnumber($cn_item, $regexs);
|
|
|
|
=cut
|
|
|
|
sub split_callnumber {
|
|
my ($cn_item, $regexs) = @_;
|
|
|
|
for my $regex ( @$regexs ) {
|
|
eval "\$cn_item =~ $regex"; ## no critic (StringyEval)
|
|
}
|
|
my @lines = split "\n", $cn_item;
|
|
|
|
return @lines;
|
|
}
|
|
|
|
1;
|
|
|
|
=head1 AUTHOR
|
|
|
|
Koha Development Team <http://koha-community.org/>
|
|
|
|
=cut
|