b1a52b2918
Revised patch according to QA comments. No more dependent from bz 9780.
At present, merging records breaks the link order/record, except
if an item of the deleted record is used in the order.
This is a serious issue for libraries creating items on receipt.
This patch moves existing orders from deleted record to destination record.
It creates a new function Acquisitions::GetOrdersByBiblionumber,
that could be used by other patches later.
To test :
Check the problem :
1. Set syspref AcqCreateItem = Create an item when receiving an order
1. Create a basket with one order
2. Put the record used by this order in a list
3. Put an other record in the list
4. Merge the 2 records, keeping as a reference the record NOT used in the order
5. In the order, you will see for that order "Deleted bibliographic information..."
6. Apply the patch
7. Repeat steps 1-4
8. In the order, you will see the title/author of the kept record.
9. Set syspref AcqCreateItem = Create an item when placing an order
10. Repeat steps 1-4 (an item will be created)
11. In the oreder, you will see the title/author of the kept record
(it is already the case at present. the patch should not alter this behavior)
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test plan, test suite and QA script pass.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
100 lines
3.7 KiB
Perl
Executable file
100 lines
3.7 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
#
|
|
# This Koha test module is a stub!
|
|
# Add more tests here!!!
|
|
|
|
use strict;
|
|
use warnings;
|
|
use Data::Dumper;
|
|
use POSIX qw(strftime);
|
|
|
|
use C4::Bookseller qw( GetBookSellerFromId );
|
|
|
|
use Test::More tests => 42;
|
|
|
|
BEGIN {
|
|
use_ok('C4::Acquisition');
|
|
}
|
|
|
|
my $booksellerid = 1;
|
|
my $booksellerinfo = GetBookSellerFromId( $booksellerid );
|
|
# diag( Data::Dumper->Dump( [ $booksellerinfo ], [ 'booksellerinfo' ] ) );
|
|
SKIP: {
|
|
skip 'No booksellers in database, cannot test baskets', 2 unless $booksellerinfo;
|
|
my ($basket, $basketno);
|
|
ok($basketno = NewBasket(1,1), "NewBasket( 1 , 1 ) returns $basketno");
|
|
ok($basket = GetBasket($basketno), "GetBasket($basketno) returns $basket");
|
|
}
|
|
|
|
|
|
my $supplierid = 1;
|
|
my $grouped = 0;
|
|
my $orders = GetPendingOrders( $supplierid, $grouped );
|
|
isa_ok( $orders, 'ARRAY' );
|
|
|
|
# testing GetOrdersByBiblionumber
|
|
# result should be undef if no params
|
|
my @ordersbybiblionumber = GetOrdersByBiblionumber();
|
|
is(@ordersbybiblionumber,0,'GetOrdersByBiblionumber : no argument, return undef');
|
|
# TODO : create 2 orders using the same biblionumber, and check the result of GetOrdersByBiblionumber
|
|
# if a record is used in at least one order, result should be an array with at least one element
|
|
SKIP: {
|
|
skip 'No Orders, cannot test GetOrdersByBiblionumber', 3 unless( scalar @$orders );
|
|
my $testorder = @$orders[0];
|
|
my $testbiblio = $testorder->{'biblionumber'};
|
|
my @listorders = GetOrdersByBiblionumber($testbiblio);
|
|
isa_ok( ref @listorders, 'ARRAY','GetOrdersByBiblionumber : result is an array' );
|
|
ok( scalar (@listorders) >0,'GetOrdersByBiblionumber : result contains at least one element' );
|
|
my @matched_biblios = grep {$_->{biblionumber} == $testbiblio} @listorders;
|
|
ok ( @matched_biblios == @listorders, "all orders match");
|
|
}
|
|
|
|
my @lateorders = GetLateOrders(0);
|
|
SKIP: {
|
|
skip 'No Late Orders, cannot test AddClaim', 1 unless @lateorders;
|
|
my $order = $lateorders[0];
|
|
AddClaim( $order->{ordernumber} );
|
|
my $neworder = GetOrder( $order->{ordernumber} );
|
|
is( $neworder->{claimed_date}, strftime( "%Y-%m-%d", localtime(time) ), "AddClaim : Check claimed_date" );
|
|
}
|
|
|
|
SKIP: {
|
|
skip 'No relevant orders in database, cannot test baskets', 33 unless( scalar @$orders );
|
|
# diag( Data::Dumper->Dump( [ $orders ], [ 'orders' ] ) );
|
|
my @expectedfields = qw( basketno
|
|
biblioitemnumber
|
|
biblionumber
|
|
invoiceid
|
|
budgetdate
|
|
cancelledby
|
|
closedate
|
|
creationdate
|
|
currency
|
|
datecancellationprinted
|
|
datereceived
|
|
ecost
|
|
entrydate
|
|
firstname
|
|
freight
|
|
gstrate
|
|
listprice
|
|
notes
|
|
ordernumber
|
|
purchaseordernumber
|
|
quantity
|
|
quantityreceived
|
|
rrp
|
|
sort1
|
|
sort2
|
|
subscriptionid
|
|
supplierreference
|
|
surname
|
|
timestamp
|
|
title
|
|
totalamount
|
|
unitprice );
|
|
my $firstorder = $orders->[0];
|
|
for my $field ( @expectedfields ) {
|
|
ok( exists( $firstorder->{ $field } ), "This order has a $field field" );
|
|
}
|
|
}
|